terra-abstract-modal - npm Package Compare versions

Comparing version 3.29.0 to 3.30.0

CHANGELOG.md

@@ -5,2 +5,7 @@ # Changelog
 
+## 3.30.0 - (November 24, 2020)
+
+* Changed
+  * Update wdio tests to remove deprecated Terra.it helpers
+
 ## 3.29.0 - (November 10, 2020)
@@ -7,0 +12,0 @@

package.json

 {
   "name": "terra-abstract-modal",
   "main": "lib/AbstractModal.js",
-  "version": "3.29.0",
+  "version": "3.30.0",
   "description": "The abstract modal is a structural component that provides the ability to display portal'd content in a layer above the app.",
@@ -56,3 +56,3 @@ "repository": {
   },
-  "gitHead": "88d3580c37b3965d3b563623e6a8d4843a913d85"
+  "gitHead": "d0ee0429f344f88e18510d71dac0e4797eafd465"
 }

tests/wdio/abstract-modal-spec.js

@@ -5,5 +5,4 @@ const selector = '#root';
   describe('Default Modal', () => {
-    before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/default-abstract-modal'));
-
     it('clicks to open modal', () => {
+      browser.url('/raw/tests/terra-abstract-modal/abstract-modal/default-abstract-modal');
       browser.click('button');
@@ -41,5 +40,4 @@ expect(browser.getAttribute('#root', 'inert')).to.equal('true');
   describe('Fullscreen Modal', () => {
-    before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/fullscreen-abstract-modal'));
-
     it('clicks to open modal', () => {
+      browser.url('/raw/tests/terra-abstract-modal/abstract-modal/fullscreen-abstract-modal');
       browser.click('button');
@@ -77,6 +75,7 @@ expect(browser.getAttribute('#root', 'inert')).to.equal('true');
   describe('Disabled Close On Esc', () => {
-    before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-disable-close-on-esc'));
+    it('displays an open modal', () => {
+      browser.url('/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-disable-close-on-esc');
+      Terra.validates.element('open', { selector });
+    });
 
-    Terra.it.validatesElement('open', { selector });
-
     it('attempts to close modal with ESC', () => {
@@ -92,6 +91,7 @@ browser.keys('Escape');
   describe('Disabled Close On Outside Click', () => {
-    before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-disable-close-on-outside-click'));
+    it('displays an open modal', () => {
+      browser.url('/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-disable-close-on-outside-click');
+      Terra.validates.element('open', { selector });
+    });
 
-    Terra.it.validatesElement('open', { selector });
-
     it('attempts to close modal with outside click', () => {
@@ -109,5 +109,4 @@ browser.moveToObject('[class*="ModalOverlay"]', 235, 5)
     describe('Focusable Content', () => {
-      before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/default-abstract-modal'));
-
       it('clicks to open modal', () => {
+        browser.url('/raw/tests/terra-abstract-modal/abstract-modal/default-abstract-modal');
         browser.click('button');
@@ -156,5 +155,4 @@ });
     describe('No Focusable Content', () => {
-      before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-no-focusable-content'));
-
       it('does focus on the modal when opened', () => {
+        browser.url('/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-no-focusable-content');
         expect(browser.hasFocus('[aria-modal="true"][role="dialog"]')).to.be.true;
@@ -168,7 +166,6 @@ Terra.validates.element({ selector });
 Terra.describeViewports('Abstract Modal', ['enormous'], () => {
-  describe('Content Overflow', () => {
-    before(() => browser.url('/#/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-content-overflow'));
-
-    Terra.it.validatesElement({ selector });
+  it('displays abstract modal with content overflow', () => {
+    browser.url('/raw/tests/terra-abstract-modal/abstract-modal/abstract-modal-content-overflow');
+    Terra.validates.element('content overflow', { selector });
   });
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

160591

increased by0.08%

Lines of code

2537

increased by0.16%

No dependency changes