terra-button - npm Package Compare versions

Comparing version 3.60.0 to 3.60.1

CHANGELOG.md

@@ -5,2 +5,7 @@ # Changelog
 
+## 3.60.1 - (December 14, 2021)
+
+* Changed
+  * TabIndex is honored unless the button is disabled.
+
 ## 3.60.0 - (November 2, 2021)
@@ -7,0 +12,0 @@

lib/Button.js

 "use strict";
 
-function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
+function _typeof(obj) { "@babel/helpers - typeof"; return _typeof = "function" == typeof Symbol && "symbol" == typeof Symbol.iterator ? function (obj) { return typeof obj; } : function (obj) { return obj && "function" == typeof Symbol && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }, _typeof(obj); }
 
@@ -42,5 +42,5 @@ Object.defineProperty(exports, "__esModule", {
 
-function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _defineProperties(Constructor.prototype, protoProps); if (staticProps) _defineProperties(Constructor, staticProps); return Constructor; }
+function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _defineProperties(Constructor.prototype, protoProps); if (staticProps) _defineProperties(Constructor, staticProps); Object.defineProperty(Constructor, "prototype", { writable: false }); return Constructor; }
 
-function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function"); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, writable: true, configurable: true } }); if (superClass) _setPrototypeOf(subClass, superClass); }
+function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function"); } Object.defineProperty(subClass, "prototype", { value: Object.create(superClass && superClass.prototype, { constructor: { value: subClass, writable: true, configurable: true } }), writable: false }); if (superClass) _setPrototypeOf(subClass, superClass); }
 
@@ -395,3 +395,3 @@ function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
         disabled: isDisabled,
-        tabIndex: isDisabled ? '-1' : undefined,
+        tabIndex: isDisabled ? '-1' : customProps.tabIndex,
         "aria-disabled": isDisabled,
@@ -398,0 +398,0 @@ "aria-label": ariaLabel,

package.json

 {
   "name": "terra-button",
   "main": "lib/Button.js",
-  "version": "3.60.0",
+  "version": "3.60.1",
   "description": "The terra-button component provides users a way to trigger actions in the UI.",
@@ -47,3 +47,3 @@ "repository": {
   },
-  "gitHead": "655ea257dfb8649b5c003eeb580bd9f377227cc5"
+  "gitHead": "7e2b4ffb8f4db441bf7489958f1a5a588a727272"
 }

src/Button.jsx

@@ -310,3 +310,3 @@ import React from 'react';
         disabled={isDisabled}
-        tabIndex={isDisabled ? '-1' : undefined}
+        tabIndex={isDisabled ? '-1' : customProps.tabIndex}
         aria-disabled={isDisabled}
@@ -313,0 +313,0 @@ aria-label={ariaLabel}

tests/jest/Button.test.jsx

@@ -87,2 +87,7 @@ import React from 'react';
 
+it('should render with tabIndex when set', () => {
+  const button = shallow(<Button text="Tab Index" tabIndex="-1" />);
+  expect(button).toMatchSnapshot();
+});
+
 // Prop Tests
@@ -89,0 +94,0 @@ it('should have the class neutral', () => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

145701

increased by0.25%

Lines of code

1051

increased by0.48%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes