tify - npm Package Compare versions

Comparing version 0.20.1 to 0.20.5

package.json

 {
   "name": "tify",
-  "version": "0.20.1",
+  "version": "0.20.5",
   "description": "TIFY is a slim and mobile-friendly IIIF document viewer.",
@@ -13,3 +13,3 @@ "homepage": "https://github.com/subugoe/tify",
   },
-  "author": "Tobias Schäfer / SUB Göttingen <[e-mail]>",
+  "author": "SUB Göttingen <[e-mail]>",
   "license": "AGPL-3.0",
@@ -16,0 +16,0 @@ "scripts": {

src/main.js

@@ -45,3 +45,2 @@ import Vue from 'vue';
 		case 'language':
-		case 'title':
 			if (typeof window.tifyOptions[key] !== 'string') {
@@ -51,2 +50,3 @@ throw new Error(`TIFY option "${key}" must be a string`);
 			break;
+		case 'title':
 		case 'manifest':
@@ -53,0 +53,0 @@ case 'stylesheet':

src/mixins/structures.js

@@ -57,2 +57,3 @@ module.exports = {
 		},
+
 		currentStructure() {
@@ -71,13 +72,20 @@ if (!Array.isArray(this.$root.manifest.structures)) {
 			const { length } = this.$root.manifest.structures;
+			let indexOfStructureWithSmallestRange;
+			let smallestRange;
 			for (let i = 0; i < length; i += 1) {
-				const { canvases } = this.$root.manifest.structures[i];
+				const structure = this.$root.manifest.structures[i];
+				const { canvases } = structure;
 				if (canvases.some(canvasId => currentCanvasIds.indexOf(canvasId) > -1)) {
-					return this.$root.manifest.structures[i];
+					if (structure.firstPage && structure.lastPage) {
+						const currentRange = structure.lastPage - structure.firstPage;
+						if ((currentRange < smallestRange) || !smallestRange) {
+							indexOfStructureWithSmallestRange = i;
+							smallestRange = currentRange;
+							if (smallestRange === 0) break;
+						}
+					}
 				}
 			}
-			return false;
-		},
-		currentStructureMetadata() {
-			if (this.currentStructure.metadata && this.currentStructure.metadata.length) {
-				return this.currentStructure.metadata;
+			if (typeof indexOfStructureWithSmallestRange === 'number' && indexOfStructureWithSmallestRange >= 0) {
+				return this.$root.manifest.structures[indexOfStructureWithSmallestRange];
 			}
@@ -87,3 +95,12 @@
 		},
+
+		currentStructureLabel() {
+			const { label } = this.currentStructure;
+			return label;
+		},
+		currentStructureMetadata() {
+			const { metadata } = this.currentStructure;
+			return metadata;
+		},
 	},
 };

test/e2e/specs/info.spec.js

@@ -36,1 +36,14 @@ Feature('Info');
 });
+
+Scenario('Show metadata of a nested structure', (I) => {
+	I.amOnPage('http://localhost:8080/?manifest=http://localhost:8081/manifest/gdz-DE_611_BF_5619_1801_1806.json');
+	I.waitForElement('.tify-app_main');
+	I.click('Next page');
+	I.click('Next page');
+	I.click('Next page');
+	I.click('Next page');
+
+	I.click('Info');
+	I.see('Current Element');
+	I.see('[Brief des Barons von Asch an Heyne vom 29.01./10.02.1801]', '.tify-info_section.-metadata.-structure');
+});

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1334870

increased by44.11%

Number of package files

117

increased by0.86%

Lines of code

10196

increased by0.26%

Worsened metrics

Number of medium supply chain risk alerts

3

increased by50%

No dependency changes