tsc-watch - npm Package Compare versions

Comparing version 1.0.24 to 1.0.25

CHANGELOG.md

 # @gilamran/tsc-watch CHANGELOG
 
+## v1.0.25 - 20/07/2018
+* Fixed hadErrors check (Thanks to @tombousso)
+
 ## v1.0.24 - 20/07/2018
@@ -4,0 +7,0 @@ * Killing onFail and onSuccess after compilation

lib/tsc-watch.js

@@ -76,17 +76,8 @@ #!/usr/bin/env node
 
-function killAllProcesses() {
-  killFailureProcess().then(() => {
-    Signal.emitFail();
-    if (onFailureCommand) {
-      failureProcess = runCommand(onFailureCommand);
-      failureProcessExited = new Promise(resolve => {
-        failureProcess.on('exit', code => {
-          resolve(code);
-        });
-      });
+function killAllProcesses(emitSuccess, emitFail) {
+  killAllSuccessProcesses().then(() => {
+    if (emitSuccess) {
+      Signal.emitSuccess();
     }
-  });
 
-  killAllSuccessProcesses().then(() => {
-    Signal.emitSuccess();
     if (firstTime && onFirstSuccessCommand) {
@@ -109,2 +100,17 @@ firstTime = false;
   });
+
+  killFailureProcess().then(() => {
+    if (emitFail) {
+      Signal.emitFail();
+    }
+    
+    if (onFailureCommand) {
+      failureProcess = runCommand(onFailureCommand);
+      failureProcessExited = new Promise(resolve => {
+        failureProcess.on('exit', code => {
+          resolve(code);
+        });
+      });
+    }
+  });
 }
@@ -179,3 +185,3 @@
   if (compilationComplete) {
-    killAllProcesses();
+    killAllProcesses(hadErrors === false, hadErrors === true);
   }
@@ -195,3 +201,3 @@ });
 
-tscProcess.on('exit', () => killAllProcesses());
+tscProcess.on('exit', () => killAllProcesses(false, false));
 process.on('SIGTERM', () => tscProcess.kill(0));

package.json

 {
   "name": "tsc-watch",
-  "version": "1.0.24",
+  "version": "1.0.25",
   "description": "The TypeScript compiler with onSuccess command",
@@ -5,0 +5,0 @@ "scripts": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

17038

increased by1.26%

Lines of code

356

increased by1.14%

No dependency changes