tsc-watch - npm Package Compare versions

Comparing version 1.1.37 to 2.0.0

CHANGELOG.md

 # @gilamran/tsc-watch CHANGELOG
 
+## v2.0.0 - 12/2/2019
+
+As many users requested, from now on `--onFirstSuccess` process will not get killed, only when tsc-watch is killed. (Based on @amir-arad's PR)
+This version fixes Issue #20, #21 and #50.
+
 ## v1.1.37 - 8/2/2019
@@ -4,0 +9,0 @@

example/main.js

 setInterval(() => console.log(Math.random()), 1000);

example/main.ts

 setInterval(() => console.log(Math.random()), 1000);

lib/args-manager.js

@@ -0,0 +0,0 @@ function removeRunnerArgs(args) {

lib/client.js

@@ -0,0 +0,0 @@ const { fork } = require('child_process');

lib/killer.js

@@ -0,0 +0,0 @@ const psTree = require('ps-tree');

lib/stdout-manipulator.js

@@ -0,0 +0,0 @@ const stripAnsi = require('strip-ansi');

lib/tsc-watch.js

 #!/usr/bin/env node
 
 'use strict';
-const killer = require('./killer');
 const nodeCleanup = require('node-cleanup');
 const spawn = require('cross-spawn');
-const stringArgv = require('string-argv');
+const run = require('./runner');
 const { extractArgs } = require('./args-manager');
@@ -13,51 +12,19 @@ const { manipulate, detectState, isClear, print } = require('./stdout-manipulator');
 let firstTime = true;
-let firstSuccessProcess = null;
-let firstSuccessProcessExited = null;
-let successProcess = null;
-let successProcessExited = null;
-let failureProcess = null;
-let failureProcessExited = null;
 
-let { onFirstSuccessCommand, onSuccessCommand, onFailureCommand, noColors, noClear, compiler, args } = extractArgs(process.argv);
-function runCommand(fullCommand) {
-  if (fullCommand) {
-    const parts = stringArgv(fullCommand);
-    const exec = parts[0];
-    const args = parts.splice(1);
-    return spawn(exec, args, {
-      stdio: 'inherit',
-    });
-  }
-}
+let firstSuccessKiller = null;
+let successKiller = null;
+let failureKiller = null;
 
-function killAllProcesses() {
-  return Promise.all([killAllSuccessProcesses(), killFailureProcess()]);
-}
+let { onFirstSuccessCommand, onSuccessCommand, onFailureCommand, noColors, noClear, compiler, args } = extractArgs(
+  process.argv,
+);
 
-function killAllSuccessProcesses() {
-  const promises = [];
-  if (firstSuccessProcess) {
-    promises.push(killer(firstSuccessProcess).then(() => (firstSuccessProcess = null)));
-    promises.push(firstSuccessProcessExited.then(() => (firstSuccessProcessExited = null)));
-  }
-
-  if (successProcess) {
-    promises.push(killer(successProcess).then(() => (successProcess = null)));
-    promises.push(successProcessExited.then(() => (successProcessExited = null)));
-  }
-
-  return Promise.all(promises);
+function killProcesses(killAll) {
+  return Promise.all([
+    killAll && firstSuccessKiller ? firstSuccessKiller() : null,
+    successKiller ? successKiller() : null,
+    failureKiller ? failureKiller() : null,
+  ]);
 }
 
-function killFailureProcess() {
-  const promises = [];
-
-  if (failureProcess) {
-    promises.push(killer(failureProcess).then(() => (failureProcess = null)));
-    promises.push(failureProcessExited.then(() => (failureProcessExited = null)));
-  }
-
-  return Promise.all(promises);
-}
-
 let bin;
@@ -85,8 +52,7 @@ try {
   if (compilationComplete) {
-    killAllProcesses().then(() => {
+    killProcesses(false).then(() => {
       if (compilationError) {
         Signal.emitFail();
         if (onFailureCommand) {
-          failureProcess = runCommand(onFailureCommand);
-          failureProcessExited = new Promise(resolve => failureProcess.on('exit', resolve));
+          failureKiller = run(onFailureCommand);
         }
@@ -97,7 +63,5 @@ } else {
           firstTime = false;
-          firstSuccessProcess = runCommand(onFirstSuccessCommand);
-          firstSuccessProcessExited = new Promise(resolve => firstSuccessProcess.on('exit', resolve));
+          firstSuccessKiller = run(onFirstSuccessCommand);
         } else if (onSuccessCommand) {
-          successProcess = runCommand(onSuccessCommand);
-          successProcessExited = new Promise(resolve => successProcess.on('exit', resolve));
+          successKiller = run(onSuccessCommand);
         }
@@ -121,4 +85,4 @@ }
 nodeCleanup((_exitCode, signal) => {
-  killAllProcesses();
+  killProcesses(true);
   tscProcess.kill(signal);
 });

package.json

 {
   "name": "tsc-watch",
-  "version": "1.1.37",
+  "version": "2.0.0",
   "description": "The TypeScript compiler with onSuccess command",
@@ -29,3 +29,3 @@ "scripts": {
     "singleQuote": true,
-    "printWidth": 240
+    "printWidth": 120
   },
@@ -32,0 +32,0 @@ "dependencies": {

README.md

@@ -12,2 +12,4 @@ # The TypeScript compiler with `--onSuccess` argument
 
+All above `COMMAND`s will be killed on process exit
+
 ## Install
@@ -14,0 +16,0 @@

test/args-manager.it.js

@@ -0,0 +0,0 @@ const { expect } = require('chai');

test/client.it.js

@@ -0,0 +0,0 @@ const { expect } = require('chai');

test/driver.js

@@ -0,0 +0,0 @@ const { fork } = require('child_process');

test/tsc-watch.it.js

@@ -0,0 +0,0 @@ const { expect } = require('chai');

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of package files

22

increased by4.76%

Number of lines in readme file

77

increased by2.67%

Worsened metrics

Total package byte prevSize

23421

decreased by-4.81%

Lines of code

452

decreased by-2.38%

No dependency changes