universal-analytics - npm Package Compare versions

Comparing version 0.3.2 to 0.3.3

lib/index.js

@@ -34,3 +34,3 @@
 	this._context = context || {};
-	
+
 	this.tid = tid || this.options.tid;
@@ -345,3 +345,3 @@ this.cid = this._determineCid(cid, this.options.cid, (this.options.strictCidFormat !== false));
 			self._log("Finished sending tracking calls")
-			fn.call(self, err);
+			fn.call(self, err || null, count - 1);
 		});
@@ -348,0 +348,0 @@ },

package.json

 {
   "name": "universal-analytics",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "A node module for Google's Universal Analytics tracking",
@@ -5,0 +5,0 @@ "main": "index.js",

test/index.js

@@ -65,3 +65,3 @@
 
-		visitor.should.not.have.properties('tid')
+		visitor.should.have.property('tid', undefined);
 		utils.isUuid(visitor.cid).should.equal(true, "A valid random UUID should have been generated")
@@ -68,0 +68,0 @@ visitor.options.should.eql(options)

test/send.js

@@ -38,2 +38,3 @@
 			fn.thisValues[0].should.equal(visitor, "callback should be called in the context of the visitor instance");
+			fn.args[0].should.eql([null, 0], "no error, no requests");
 		});
@@ -51,2 +52,3 @@
 				fn.thisValues[0].should.equal(visitor, "callback should be called in the context of the visitor instance");
+				fn.args[0].should.eql([null, 3], "no error, 3 requests");
 
@@ -53,0 +55,0 @@ post.callCount.should.equal(paramSets.length, "each param set should have been POSTed");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

120372

increased by0.13%

Lines of code

2249

increased by0.09%

No dependency changes