universal-analytics - npm Package Compare versions

Comparing version 0.4.15 to 0.4.16

AcceptableParams.md

@@ -288,7 +288,7 @@ # Acceptable parameters
 
-##E vent Action
+## Event Action
 
 Pass as: `eventAction` or `ea`
 
-Optional.Specifies the event action. Must not be empty.
+Optional. Specifies the event action. Must not be empty.
 
@@ -295,0 +295,0 @@

HISTORY.md

 # History
 
+## 0.4.16
+
+- Removed async, underscore dependencies
+
 ## 0.4.15 / 2017-08-10
@@ -4,0 +8,0 @@

lib/index.js

 
-var async = require("async");
-var _ = require("underscore");
 var request = require("request");
@@ -145,3 +143,3 @@ var uuid = require("uuid");
 
-    params = _.extend({}, this._persistentParams || {}, params);
+    params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -189,3 +187,3 @@ params.dp = path || params.dp || this._context.dp;
 
-      params = _.extend({}, this._persistentParams || {}, params);
+      params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -229,3 +227,3 @@ params.cd = screenName || params.cd || this._context.cd;
 
-    params = _.extend({}, this._persistentParams || {}, params);
+    params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -275,3 +273,3 @@ params.ec = category || params.ec || this._context.ec;
 
-    params = _.extend({}, this._persistentParams || {}, params);
+    params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -321,3 +319,3 @@ params.ti = transaction || params.ti || this._context.ti;
 
-    params = _.extend({}, this._persistentParams || {}, params);
+    params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -360,3 +358,3 @@ params.ip = price || params.ip || this._context.ip;
 
-    params = _.extend({}, this._persistentParams || {}, params);
+    params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -399,3 +397,3 @@ params.exd = description || params.exd || this._context.exd;
 
-    params = _.extend({}, this._persistentParams || {}, params);
+    params = Object.assign({}, this._persistentParams || {}, params);
 
@@ -419,6 +417,2 @@ params.utc = category || params.utc || this._context.utc;
 
-    var test = function () {
-      return self._queue.length > 0;
-    }
-
     var getBody = function(params) {
@@ -428,3 +422,11 @@ return params.map(function(x) { return querystring.stringify(x); }).join("\n");
 
-    var iterator = function (fn) {
+    var onFinish = function (err) {
+      self._log("Finished sending tracking calls")
+      fn.call(self, err || null, count - 1);
+    }
+
+    var iterator = function () {
+      if (!self._queue.length) {
+        return onFinish(null);
+      }
       var params = [];
@@ -444,3 +446,3 @@
 
-      var options = _.extend({}, self.options.requestOptions, {
+      var options = Object.assign({}, self.options.requestOptions, {
         body: getBody(params),
@@ -450,10 +452,12 @@ headers: self.options.headers || {}
 
-      request.post(path, options, fn);
+      request.post(path, options, nextIteration);
     }
 
-    async.whilst(test, iterator, function (err) {
-      self._log("Finished sending tracking calls")
-      fn.call(self, err || null, count - 1);
-    });
+    function nextIteration(err) {
+      if (err) return onFinish(err);
+      iterator();
+    }
 
+    iterator();
+
   },
@@ -470,3 +474,3 @@
 
-    _.extend(params, {
+    Object.assign(params, {
       v: config.protocolVersion,
@@ -473,0 +477,0 @@ tid: this.tid,

package.json

 {
   "name": "universal-analytics",
-  "version": "0.4.15",
+  "version": "0.4.16",
   "description": "A node module for Google's Universal Analytics tracking",
@@ -20,5 +20,3 @@ "main": "index.js",
   "dependencies": {
-    "async": "1.2.x",
     "request": "2.x",
-    "underscore": "1.x",
     "uuid": "^3.0.0"
@@ -25,0 +23,0 @@ },

test/_enqueue.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/event.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/exception.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/index.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/item.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/middleware.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/pageview.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/send.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/set.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/timing.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

test/transaction.js

 
-var _ = require("underscore");
 var request = require("request");
@@ -4,0 +3,0 @@ var qs = require("querystring");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Dependency count

2

decreased by-50%

Worsened metrics

Total package byte prevSize

165948

decreased by-0.22%

Number of package files

22

decreased by-4.35%

Lines of code

2648

decreased by-0.3%

Dependency changes

• - Removedasync@1.2.x

• - Removedunderscore@1.x

• - Removedasync@1.2.1(transitive)

• - Removedunderscore@1.13.7(transitive)