universal-analytics - npm Package Compare versions

Comparing version 0.5.2 to 0.5.3

HISTORY.md

		# History

		## 0.5.3

		- Refactored request sending to no use JSON.stringify
		- Removed chapter regarding requestOptions that are no longer available since 0.5
		- Fixed UUID test errors

		## 0.5.2
		@@ -4,0 +10,0 @@

lib/index.js

		@@ -438,12 +438,9 @@

		var path = config.hostname + (useBatchPath ? config.batchPath :config.path);
		var path = config.hostname + (useBatchPath ? config.batchPath : config.path);

		debug("%d: %o", count++, params);

		var options = Object.assign({}, self.options.requestOptions, {
		body: getBody(params),
		headers: self.options.headers \|\| {}
		});
		var body = getBody(params);

		request.post(path, options, nextIteration);
		request.post(path, body, self.options.headers, nextIteration);
		}
		@@ -450,0 +447,0 @@

lib/request.js

		@@ -31,12 +31,3 @@ `use strict`
		*/
		function request(path, method, data, headers = '', callback) {
		if (typeof data === 'function') {
		callback = data;
		data = '';
		} else if (typeof headers === 'function') {
		callback = headers;
		headers = {};
		}

		const postData = typeof data === "object" ? JSON.stringify(data) : data;
		function request(path, method, body, headers = {}, callback) {
		const { hostname, port, pathname } = url.parse(path);
		@@ -60,3 +51,3 @@ const options = {

		req.write(postData);
		req.write(body);

		@@ -63,0 +54,0 @@ req.end();

package.json

		{
		"name": "universal-analytics",
		"version": "0.5.2",
		"version": "0.5.3",
		"description": "A node module for Google's Universal Analytics tracking",
		@@ -5,0 +5,0 @@ "main": "index.js",

README.md

		@@ -581,13 +581,5 @@ universal-analytics

		In order to add additional options to the request a `requestOptions` hash can be provided as part of the constructor options. `unviversal-analytics` uses the [`request`](https://www.npmjs.com/package/request) library. Therefor [any option available for that library](https://www.npmjs.com/package/request#requestoptions-callback) can be provided via the `requestOptions`.
		Due to the removal of the `request` package, request options are no longer available as of 0.5.

		```javascript
		var visitor = ua('UA-XXXX-XX', {
		requestOptions: {
		proxy: "…"
		}
		});
		```


		# Shortcuts
		@@ -594,0 +586,0 @@

test/index.js

		@@ -13,2 +13,3 @@

		const v4Regex = new RegExp(/^[0-9A-F]{8}-[0-9A-F]{4}-4[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}$/i);

		@@ -89,12 +90,6 @@ describe("ua", function () {

		var next = sinon.spy(uuid, 'v4')

		var visitor = ua(options);

		next.calledOnce.should.equal(true, "next() should've been called once")
		var generatedCid = next.returnValues[0]
		uuid.v4.restore()

		visitor.cid.should.not.equal(options.cid)
		visitor.cid.should.equal(generatedCid)
		visitor.cid.should.match(v4Regex)
		});
		@@ -109,9 +104,4 @@

		var next = sinon.spy(uuid, 'v4')

		var visitor = ua(options);

		next.called.should.equal(false, "next() should't be called")
		uuid.v4.restore()

		visitor.cid.should.equal(options.cid)
		@@ -118,0 +108,0 @@ });

test/send.js

		@@ -20,3 +20,3 @@
		beforeEach(function () {
		post = sinon.stub(request, "post").callsArg(2);
		post = sinon.stub(request, "post").callsArg(3);
		});
		@@ -61,3 +61,3 @@
		(parsedUrl.protocol + "//" + parsedUrl.host).should.equal(config.hostname);
		args[1].body.should.equal(qs.stringify(params));
		args[1].should.equal(qs.stringify(params));
		}
		@@ -152,3 +152,3 @@
		var params = paramSets;
		var formParams = args[1].body.split("\n");
		var formParams = args[1].split("\n");
		formParams.should.have.lengthOf(3);
		@@ -178,3 +178,3 @@ formParams[0].should.equal(qs.stringify(params[0]));

		var body = post.args[0][1].body;
		var body = post.args[0][1];

		@@ -205,9 +205,8 @@ body.split("\n").should.have.lengthOf(2);
		var parsedUrl = url.parse(post.args[0][0]);
		var options = post.args[0][1];
		var headers = post.args[0][2];

		(parsedUrl.protocol + "//" + parsedUrl.host).should.equal(config.hostname);

		options.should.have.keys("headers","body")
		options.headers.should.have.key("User-Agent");
		options.headers["User-Agent"].should.equal("Test User Agent");
		headers.should.have.key("User-Agent");
		headers["User-Agent"].should.equal("Test User Agent");

		@@ -214,0 +213,0 @@ done();

New alerts