urdf-loader - npm Package Compare versions

Comparing version 0.7.2 to 0.7.3

CHANGELOG.md

@@ -7,2 +7,10 @@ # Changelog
 
+## [0.7.3] - 2019-11-08
+### Fixed
+- Incorrect handling of empty "texture" tags that caused materials to display improperly.
+
+## [0.7.2] - 2019-09-29
+### Changed
+- Caltech license copy.
+
 ## [0.7.1] - 2019-06-29
@@ -9,0 +17,0 @@ ### Fixed

package.json

 {
   "name": "urdf-loader",
-  "version": "0.7.2",
+  "version": "0.7.3",
   "description": "URDF Loader for THREE.js and webcomponent viewer",
@@ -5,0 +5,0 @@ "main": "umd/URDFLoader.js",

README.md

 # javascript urdf-loader
 
 [![npm version](https://img.shields.io/npm/v/urdf-loader.svg?style=flat-square)](https://www.npmjs.com/package/urdf-loader)
-[![travis build](https://img.shields.io/travis/gkjohnson/urdf-loaders.svg?style=flat-square)](https://travis-ci.org/gkjohnson/urdf-loaders)
+[![travis build](https://img.shields.io/travis/gkjohnson/urdf-loaders.svg?style=flat-square)](https://travis-ci.com/gkjohnson/urdf-loaders)
 [![lgtm code quality](https://img.shields.io/lgtm/grade/javascript/g/gkjohnson/urdf-loaders.svg?style=flat-square&label=code-quality)](https://lgtm.com/projects/g/gkjohnson/urdf-loaders/)
@@ -6,0 +6,0 @@

src/URDFLoader.js

@@ -325,7 +325,13 @@ import * as THREE from 'three';
 
-                    const loader = new THREE.TextureLoader(manager);
+                    // The URDF spec does not require that the <texture/> tag include
+                    // a filename attribute so skip loading the texture if not provided.
                     const filename = n.getAttribute('filename');
-                    const filePath = resolvePath(filename);
-                    material.map = loader.load(filePath);
+                    if (filename) {
 
+                        const loader = new THREE.TextureLoader(manager);
+                        const filePath = resolvePath(filename);
+                        material.map = loader.load(filePath);
+
+                    }
+
                 }
@@ -332,0 +338,0 @@ });

umd/URDFLoader.js

@@ -587,7 +587,13 @@ (function (global, factory) {
 
-                        const loader = new THREE.TextureLoader(manager);
+                        // The URDF spec does not require that the <texture/> tag include
+                        // a filename attribute so skip loading the texture if not provided.
                         const filename = n.getAttribute('filename');
-                        const filePath = resolvePath(filename);
-                        material.map = loader.load(filePath);
+                        if (filename) {
 
+                            const loader = new THREE.TextureLoader(manager);
+                            const filePath = resolvePath(filename);
+                            material.map = loader.load(filePath);
+
+                        }
+
                     }
@@ -594,0 +600,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

249922

increased by0.41%

Lines of code

2838

increased by0.28%

No dependency changes