vega-lite - npm Package Compare versions

Comparing version 0.6.8 to 0.6.9

bower.json

 {
   "name": "vega-lite",
   "main": "vega-lite.js",
-  "version": "0.6.8",
+  "version": "0.6.9",
   "homepage": "https://github.com/uwdata/vega-lite",
@@ -6,0 +6,0 @@ "authors": [

gulp/tests.js

@@ -8,3 +8,3 @@ 'use strict';
 // runs the tests
-gulp.task('test', function() {
+gulp.task('test', ['jshint'], function() {
   return gulp.src(['test/**/*.spec.js'], { read: false })
@@ -11,0 +11,0 @@ .pipe(mocha())

gulpfile.js

@@ -7,5 +7,3 @@ 'use strict';
   src: 'src',
-  dist: 'dist',
-  tmp: '.tmp',
-  e2e: 'e2e'
+  test: 'test'
 };
@@ -12,0 +10,0 @@

package.json

 {
   "name": "vega-lite",
   "author": "Jeffrey Heer, Dominik Moritz, Kanit \"Ham\" Wongsuphasawat",
-  "version": "0.6.8",
+  "version": "0.6.9",
   "collaborators": [
@@ -37,2 +37,3 @@ "Kanit Wongsuphasawat <[e-mail]> (http://kanitw.yellowpigz.com)",
     "gulp-git": "^1.2.3",
+    "gulp-jshint": "^1.10.0",
     "gulp-load-plugins": "^0.10.0",
@@ -46,2 +47,3 @@ "gulp-rename": "^1.2.0",
     "gulp-util": "^3.0.2",
+    "jshint-stylish": "^1.0.2",
     "lodash": "^2.4.1",
@@ -48,0 +50,0 @@ "mocha": "^2.1.0",

src/compile/aggregate.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util');
+require('../globals');
 
+var util = require('../util');
+
 module.exports = aggregates;
@@ -7,0 +8,0 @@

src/compile/axis.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util'),
+require('../globals');
+
+var util = require('../util'),
   setter = util.setter,
@@ -133,2 +134,4 @@ getter = util.getter,
 function axis_title(def, name, encoding, layout, opt) {
+  // jshint unused:false
+
   var maxlength = null,
@@ -158,2 +161,4 @@ fieldTitle = encoding.fieldTitle(name);
 function axis_labels(def, name, encoding, layout, opt) {
+  // jshint unused:false
+
   var fn;
@@ -160,0 +165,0 @@ // add custom label for time type

src/compile/bin.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util');
+require('../globals');
 
@@ -10,3 +9,2 @@ module.exports = binning;
   opt = opt || {};
-  var bins = {};
 
@@ -13,0 +11,0 @@ if (!spec.transform) spec.transform = [];

src/compile/compile.js

@@ -5,3 +5,3 @@ 'use strict';
 
-var globals = require('../globals');
+require('../globals');
 
@@ -8,0 +8,0 @@ module.exports = compile;

src/compile/facet.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util');
+require('../globals');
 
+var util = require('../util');
+
 var axis = require('./axis'),
@@ -7,0 +8,0 @@ groupdef = require('./group').def,

src/compile/filter.js

 'use strict';
 
-var globals = require('../globals');
+require('../globals');
 
@@ -5,0 +5,0 @@ var filter = module.exports = {};

src/compile/layout.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util'),
-  setter = util.setter,
-  schema = require('../schema/schema'),
-  time = require('./time'),
-  vlfield = require('../field');
+require('../globals');
 
+var util = require('../util'),
+  setter = util.setter;
+
 module.exports = vllayout;
@@ -11,0 +9,0 @@

src/compile/legend.js

 'use strict';
 
-var global = require('../globals'),
-  time = require('./time');
+require('../globals');
 
+var time = require('./time');
+
 var legend = module.exports = {};
@@ -10,3 +11,2 @@
   var defs = [];
-
   // TODO: support alpha
@@ -13,0 +13,0 @@

src/compile/marks.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util'),
-  vlscale = require('./scale');
+require('../globals');
 
@@ -96,2 +94,4 @@ var marks = module.exports = {};
 function bar_props(e, layout, style) {
+  // jshint unused:false
+
   var p = {};
@@ -220,3 +220,4 @@
 
-function line_props(e, layout, style) {
+function line_props(e,layout, style) {
+  // jshint unused:false
   var p = {};
@@ -258,2 +259,3 @@
 function area_props(e, layout, style) {
+  // jshint unused:false
   var p = {};
@@ -260,0 +262,0 @@

src/compile/scale.js

 'use strict';
-
-var globals = require('../globals'),
-  util = require('../util'),
+require('../globals');
+var util = require('../util'),
   time = require('./time');
@@ -74,2 +73,3 @@
 function scale_range(s, encoding, layout, style, opt) {
+  // jshint unused:false
   var spec = encoding.scale(s.name);
@@ -76,0 +76,0 @@ switch (s.name) {

src/compile/sort.js

 'use strict';
 
-var globals = require('../globals');
+require('../globals');
 
@@ -9,2 +9,4 @@ module.exports = addSortTransforms;
 function addSortTransforms(spec, encoding, stats, opt) {
+  // jshint unused:false
+
   var datasetMapping = {};
@@ -11,0 +13,0 @@ var counter = 0;

src/compile/stack.js

 "use strict";
 
-var globals = require('../globals'),
-  util = require('../util'),
-  marks = require('./marks');
+require('../globals');
 
+var  marks = require('./marks');
+
 module.exports = stacking;
@@ -8,0 +8,0 @@

src/compile/style.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util'),
-  vlfield = require('../field'),
-  Encoding = require('../Encoding');
+require('../globals');
 
+var vlfield = require('../field');
+
 module.exports = function(encoding, stats) {
@@ -9,0 +8,0 @@ return {

src/compile/subfacet.js

 'use strict';
 
-var global = require('../globals');
+require('../globals');
 
@@ -5,0 +5,0 @@ var groupdef = require('./group').def;

src/compile/template.js

 'use strict';
 
-var globals = require('../globals');
+require('../globals');
 
 var groupdef = require('./group').def,
-  vldata = require('../data'),
   vlfield = require('../field');
@@ -12,2 +11,3 @@
 function template(encoding, layout, stats) {
+  // jshint unused:false
 
@@ -14,0 +14,0 @@ var data = {name: RAW, format: {}},

src/compile/time.js

 'use strict';
 
-var globals = require('../globals'),
-  util = require('../util');
+var util = require('../util');
 
@@ -9,2 +8,3 @@ module.exports = time;
 function time(spec, encoding, opt) {
+  // jshint unused:false
   var timeFields = {}, timeFn = {};
@@ -11,0 +11,0 @@

src/consts.js

 'use strict';
 
-var globals = require('./globals');
+require('./globals');
 
@@ -5,0 +5,0 @@ var consts = module.exports = {};

src/data.js

 'use strict';
 
-var vldata = module.exports = {},
-  vlfield = require('./field'),
-  util = require('./util');
+var vldata = module.exports = {};
 
@@ -7,0 +5,0 @@ /** Mapping from datalib's inferred type to Vega-lite's type */

src/enc.js

@@ -7,3 +7,2 @@ // utility for enc
   c = consts.shorthand,
-  time = require('./compile/time'),
   vlfield = require('./field'),
@@ -59,3 +58,3 @@ util = require('./util'),
 vlenc.reduce = function(enc, f, init) {
-  var r = init, i = 0, k;
+  var r = init;
   encTypes.forEach(function(k) {
@@ -73,3 +72,3 @@ if (vlenc.has(enc, k)) {
 vlenc.fields = function(enc) {
-  return vlenc.reduce(enc, function (m, field, encType) {
+  return vlenc.reduce(enc, function (m, field) {
     var fieldList = m[field.name] = m[field.name] || [],
@@ -76,0 +75,0 @@ containsType = fieldList.containsType = fieldList.containsType || {};

src/Encoding.js

 'use strict';
 
-var globals = require('./globals'),
-  consts = require('./consts'),
+require('./globals');
+
+var consts = require('./consts'),
   util = require('./util'),
   vlfield = require('./field'),
   vlenc = require('./enc'),
-  schema = require('./schema/schema'),
-  time = require('./compile/time');
+  schema = require('./schema/schema');
 
-var Encoding = module.exports = (function() {
-
+module.exports = (function() {
   function Encoding(marktype, enc, data, config, filter, theme) {
@@ -273,3 +272,3 @@ var defaults = schema.instantiate();
 
-  Encoding.alwaysNoOcclusion = function(spec, stats) {
+  Encoding.alwaysNoOcclusion = function(spec) {
     // FIXME raw OxQ with # of rows = # of O
@@ -276,0 +275,0 @@ return vlenc.isAggregate(spec.enc);

src/schema/schemagen.js

@@ -0,1 +1,3 @@
+'use strict';
+
 var schema = require('./schema').schema,
@@ -2,0 +4,0 @@ json3 = require('../../lib/json3-compactstringify.js');

src/vl.js

 'use strict';
 
-var globals = require('./globals'),
-    util = require('./util'),
+require('./globals');
+
+var util = require('./util'),
     consts = require('./consts');
@@ -6,0 +7,0 @@

test/compile/sort.spec.js

 'use strict';
 
-var expect = require('chai').expect,
-  _ = require('lodash');
+var expect = require('chai').expect;
 
@@ -6,0 +5,0 @@ var vlsort = require('../../src/compile/sort'),

test/compile/stack.spec.js

@@ -6,3 +6,2 @@ 'use strict';
 var compile = require('../../src/compile/compile'),
-  Encoding = require('../../src/Encoding'),
   util = require('../../src/util');
@@ -28,10 +27,2 @@
 
-var spec_stackXOnly = {
-  "marktype": "bar",
-  "enc": {
-    "x": {"type": "Q","name": "Cost__Other","aggr": "avg"},
-    "color": {"type": "O","name": "Effect__Amount_of_damage"}
-  }
-};
-
 var spec_stackBinX = {
@@ -38,0 +29,0 @@ "marktype": "bar",

test/compile/time.spec.js

 'use strict';
 
-var expect = require('chai').expect,
-  _ = require('lodash');
+var expect = require('chai').expect;
 
@@ -6,0 +5,0 @@ var time = require('../../src/compile/time'),

test/data.spec.js

 'use strict';
-
-var assert = require('assert');
-var data = require('../src/data'),
-  vlfield = require('../src/field');

test/schema.spec.js

@@ -5,3 +5,2 @@ 'use strict';
   ZSchema = require("z-schema"),
-  _ = require('lodash'),
   inspect = require('util').inspect;
@@ -13,2 +12,3 @@
 
+/*jshint -W121 */
 String.prototype.endsWith = function(suffix) {
@@ -15,0 +15,0 @@ return this.indexOf(suffix, this.length - suffix.length) !== -1;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8648615

Number of package files

92

increased by2.22%

Worsened metrics

Dev dependency count

26

increased by8.33%

Lines of code

141901

decreased by-0.01%

No dependency changes