vega-lite - npm Package Compare versions

Comparing version 5.5.1--canary.8475.a9d1dc5.0 to 5.5.1--canary.8475.ccc3007.0

build/src/compile/mark/init.js

@@ -99,15 +99,13 @@ import { isBinned, isBinning } from '../../bin';
                         }
-                        else {
-                            return 'vertical';
-                        }
                     }
+                    return 'vertical';
                 }
-                // If x is range and y is non-range, non-bin Q, x is likely a prebinned field
+                // If x is range and y is non-range, non-bin Q
                 if (!y2) {
-                    if (isFieldDef(x) && isBinned(x.bin)) {
-                        return 'vertical';
+                    if ((isFieldDef(y) && y.type === QUANTITATIVE && !isBinning(y.bin)) || isNumericDataDef(y)) {
+                        if (isFieldDef(x) && isBinned(x.bin)) {
+                            return 'vertical';
+                        }
                     }
-                    else {
-                        return 'horizontal';
-                    }
+                    return 'horizontal';
                 }
@@ -114,0 +112,0 @@ }

package.json

 {
   "name": "vega-lite",
   "author": "Dominik Moritz, Kanit \"Ham\" Wongsuphasawat, Arvind Satyanarayan, Jeffrey Heer",
-  "version": "5.5.1--canary.8475.a9d1dc5.0",
+  "version": "5.5.1--canary.8475.ccc3007.0",
   "collaborators": [
@@ -6,0 +6,0 @@ "Kanit Wongsuphasawat (http://kanitw.yellowpigz.com)",

src/compile/mark/init.ts

@@ -131,15 +131,15 @@ import {Orientation, SignalRef} from 'vega';
               return 'horizontal';
-            } else {
-              return 'vertical';
             }
           }
+          return 'vertical';
         }
 
-        // If x is range and y is non-range, non-bin Q, x is likely a prebinned field
+        // If x is range and y is non-range, non-bin Q
         if (!y2) {
-          if (isFieldDef(x) && isBinned(x.bin)) {
-            return 'vertical';
-          } else {
-            return 'horizontal';
+          if ((isFieldDef(y) && y.type === QUANTITATIVE && !isBinning(y.bin)) || isNumericDataDef(y)) {
+            if (isFieldDef(x) && isBinned(x.bin)) {
+              return 'vertical';
+            }
           }
+          return 'horizontal';
         }
@@ -146,0 +146,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

9353356

increased by0.01%

Worsened metrics

Lines of code

115673

No dependency changes