victory-core - npm Package Compare versions

Comparing version 36.8.1 to 36.8.2

CHANGELOG.md

 # victory-core
 
+## 36.8.2
+
+### Patch Changes
+
+- Fix the label background position when using dy fns ([#2720](https://github.com/FormidableLabs/victory/pull/2720))
+
+* Migrate victory-legend to TypeScript ([#2712](https://github.com/FormidableLabs/victory/pull/2712))
+
 ## 36.8.1
@@ -4,0 +12,0 @@

es/victory-label/victory-label.js

@@ -446,3 +446,3 @@ import _isEmpty from "lodash/isEmpty";
     dy: dy,
-    originalDy: props.dy,
+    originalDy: Helpers.evaluateProp(props.dy, props),
     transform: transform,
@@ -449,0 +449,0 @@ x: x,

es/victory-util/add-events.d.ts

@@ -30,3 +30,3 @@ import React from "react";
     animateComponent(props: TProps, defaultAnimationWhitelist: string[]): React.ReactElement;
-    getComponentProps(component: React.ReactElement, type: string, index: number): TProps;
+    getComponentProps(component: React.ReactNode, type: string, index: string | number): TProps;
     dataKeys: string[];
@@ -94,3 +94,3 @@ }
         getAllEvents(props: any): any;
-        getComponentProps(component: any, type: any, index: any): any;
+        getComponentProps(component: React.ReactNode, type: string, index: string | number): any;
         renderContainer(component: any, children: any): React.DetailedReactHTMLElement<any, HTMLElement>;
@@ -97,0 +97,0 @@ animateComponent(props: TProps, defaultAnimationWhitelist: string[]): React.ReactElement;

es/victory-util/add-events.js

@@ -317,2 +317,4 @@ import _without from "lodash/without";
 
+        var currentProps = component && typeof component === "object" && "props" in component ? component.props : undefined;
+
         if (this.hasEvents) {
@@ -324,3 +326,3 @@ var baseEvents = this.getEvents(this.props, type, key);
             key: id
-          }, this.getEventState(key, type), this.getSharedEventState(key, type), component.props, baseProps, {
+          }, this.getEventState(key, type), this.getSharedEventState(key, type), currentProps, baseProps, {
             id: id
@@ -339,3 +341,3 @@ });
           key: id
-        }, component.props, baseProps, {
+        }, currentProps, baseProps, {
           id: id
@@ -342,0 +344,0 @@ });

lib/victory-label/victory-label.js

@@ -474,3 +474,3 @@ "use strict";
     dy: dy,
-    originalDy: props.dy,
+    originalDy: Helpers.evaluateProp(props.dy, props),
     transform: transform,
@@ -477,0 +477,0 @@ x: x,

lib/victory-util/add-events.d.ts

@@ -30,3 +30,3 @@ import React from "react";
     animateComponent(props: TProps, defaultAnimationWhitelist: string[]): React.ReactElement;
-    getComponentProps(component: React.ReactElement, type: string, index: number): TProps;
+    getComponentProps(component: React.ReactNode, type: string, index: string | number): TProps;
     dataKeys: string[];
@@ -94,3 +94,3 @@ }
         getAllEvents(props: any): any;
-        getComponentProps(component: any, type: any, index: any): any;
+        getComponentProps(component: React.ReactNode, type: string, index: string | number): any;
         renderContainer(component: any, children: any): React.DetailedReactHTMLElement<any, HTMLElement>;
@@ -97,0 +97,0 @@ animateComponent(props: TProps, defaultAnimationWhitelist: string[]): React.ReactElement;

lib/victory-util/add-events.js

@@ -329,2 +329,4 @@ "use strict";
 
+        var currentProps = component && typeof component === "object" && "props" in component ? component.props : undefined;
+
         if (this.hasEvents) {
@@ -335,3 +337,3 @@ var baseEvents = this.getEvents(this.props, type, key);
             key: id
-          }, this.getEventState(key, type), this.getSharedEventState(key, type), component.props, baseProps, {
+          }, this.getEventState(key, type), this.getSharedEventState(key, type), currentProps, baseProps, {
             id: id
@@ -348,3 +350,3 @@ });
           key: id
-        }, component.props, baseProps, {
+        }, currentProps, baseProps, {
           id: id
@@ -351,0 +353,0 @@ });

package.json

 {
   "name": "victory-core",
-  "version": "36.8.1",
+  "version": "36.8.2",
   "description": "Victory Core",
@@ -26,3 +26,3 @@ "keywords": [
     "react-fast-compare": "^3.2.0",
-    "victory-vendor": "^36.8.1"
+    "victory-vendor": "^36.8.2"
   },
@@ -29,0 +29,0 @@ "peerDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3133946

increased by0.04%

Lines of code

61626

increased by0.02%

Dependency changes

• Updatedvictory-vendor@^36.8.2