videocontext - npm Package Compare versions

Comparing version 0.38.1 to 0.38.2

package.json

 {
   "name": "videocontext",
-  "version": "0.38.1",
+  "version": "0.38.2",
   "description": "A WebGL & HTML5 graph based video composition library",
@@ -5,0 +5,0 @@ "keywords":["video", "context", "composition", "timeline", "html5", "webgl"],

src/SourceNodes/imagenode.js

@@ -44,3 +44,3 @@ //Matthew Shotton, R&D User Experience,© BBC 2015
             console.debug("Error with element", this._element);
-            this._state === SOURCENODESTATE.error;
+            this._state = SOURCENODESTATE.error;
             //Event though there's an error ready should be set to true so the node can output transparenn
@@ -47,0 +47,0 @@ this._ready = true;

src/SourceNodes/sourcenode.js

@@ -351,3 +351,3 @@ //Matthew Shotton, R&D User Experience,© BBC 2015
 
-        if (currentTime >= this._startTime && this._state !== STATE.paused){
+        if (currentTime >= this._startTime && this._state !== STATE.paused && this._state !== STATE.error){
             if (this._state !== STATE.playing) this._triggerCallbacks("play");
@@ -354,0 +354,0 @@ this._state = STATE.playing;

src/SourceNodes/videonode.js

@@ -15,6 +15,2 @@ //Matthew Shotton, R&D User Experience,© BBC 2015
         this._videoElementCache = videoElementCache;
-        // if (this._videoElementCache){
-            // this._isResponsibleForElementLifeCycle = true;
-            //this._element.currentTime = this._sourceOffset;
-        // }
         this._playbackRate = 1.0;
@@ -80,3 +76,5 @@ this._playbackRateUpdated = true;
             } else{
-                this._ready = false;
+                if(this._state !== SOURCENODESTATE.error){
+                    this._ready = false;
+                }
             }
@@ -104,3 +102,3 @@ return;
                 console.debug("Error with element", this._element);
-                this._state === SOURCENODESTATE.error;
+                this._state = SOURCENODESTATE.error;
                 //Event though there's an error ready should be set to true so the node can output transparenn
@@ -112,3 +110,3 @@ this._ready = true;
             //If the element doesn't exist for whatever reason enter the error state.
-            this._state === SOURCENODESTATE.error;
+            this._state = SOURCENODESTATE.error;
             this._ready = true;
@@ -115,0 +113,0 @@ this._triggerCallbacks("error");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

6688359

Lines of code

25337

decreased by-0.04%

No dependency changes