viewmodel - npm Package Compare versions

Comparing version 1.5.14 to 1.5.15

lib/databases/mongodb.js

@@ -48,30 +48,36 @@ 'use strict';
 
-    var server;
+    var connectionUrl;
 
-    if (options.servers && Array.isArray(options.servers)){
-      var servers = [];
+    if (options.url) {
+      connectionUrl = options.url;
+    } else {
+      var members = options.servers
+        ? options.servers
+        : [{host: options.host, port: options.port}];
 
-      options.servers.forEach(function(item){
-        if(item.host && item.port) {
-          servers.push(new mongo.Server(item.host, item.port, item.options));
-        }
-      });
+      var memberString = _(members).map(function(m) { return m.host + ':' + m.port });
+      var authString = options.username && options.password
+        ? options.username + ':' + options.password + '@'
+        : '';
+      var optionsString = options.authSource
+        ? '?authSource=' + options.authSource
+        : '';
 
-      server = new mongo.ReplSet(servers);
-    } else {
-      server = new mongo.Server(options.host, options.port, options.options);
+      connectionUrl = 'mongodb://' + authString + memberString + '/' + options.dbName + optionsString;
     }
 
-    this.db = new mongo.Db(options.dbName, server, { safe: true });
-    this.db.on('close', function() {
-      self.emit('disconnect');
-      self.stopHeartbeat();
-    });
+    var client = new mongo.MongoClient();
 
-    this.db.open(function (err, client) {
+    client.connect(connectionUrl, options.options, function(err, db) {
       if (err) {
         if (callback) callback(err);
       } else {
+        self.db = db;
+
+        self.db.on('close', function() {
+          self.emit('disconnect');
+          self.stopHeartbeat();
+        });
+
         var finish = function (err) {
-          self.client = client;
           self.isConnected = true;
@@ -88,10 +94,3 @@ if (!err) {
 
-        if (options.authSource && options.username) {
-          // Authenticate with authSource
-          client.authenticate(options.username, options.password, {authSource: options.authSource}, finish);
-        } else if (options.username) {
-          client.authenticate(options.username, options.password, finish);
-        } else {
-          finish();
-        }
+        finish();
       }
@@ -98,0 +97,0 @@ });

package.json

 {
   "author": "adrai",
   "name": "viewmodel",
-  "version": "1.5.14",
+  "version": "1.5.15",
   "private": false,
@@ -6,0 +6,0 @@ "main": "index.js",

README.md

@@ -40,2 +40,3 @@ # Introduction
       	    // password: 'secret'                          // optional
+            // url: 'mongodb://user:pass@host:port/db?opts // optional
         },
@@ -42,0 +43,0 @@ function(err, repository) {

releasenotes.md

@@ -0,1 +1,4 @@
+## [v1.5.15](https://github.com/adrai/node-viewmodel/compare/v1.5.14...v1.5.15)
+- Support mongo connection string
+
 ## [v1.5.14](https://github.com/adrai/node-viewmodel/compare/v1.5.13...v1.5.14)
@@ -2,0 +5,0 @@ - inmemory: now correctly instantiates with collectionName [#46](https://github.com/adrai/node-viewmodel/pull/46) thanks to [hilkeheremans](https://github.com/hilkeheremans)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

106545

increased by0.07%

Number of lines in readme file

272

increased by0.37%

Worsened metrics

Lines of code

2860

decreased by-0.1%

No dependency changes