virtual-element - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

build/virtual-element.js

@@ -53,3 +53,3 @@ (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.virtualElement = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof _require=="function"&&_require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof _require=="function"&&_require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(_require,module,exports){
   // This is essentially just the ES6 rest param
-  if (arguments.length > 2 && Array.isArray(arguments[2]) === false) {
+  if (arguments.length > 2 && children && Array.isArray(arguments[2]) === false) {
     children = slice(arguments, 2)
@@ -56,0 +56,0 @@ }

index.js

@@ -52,3 +52,3 @@ /**
   // This is essentially just the ES6 rest param
-  if (arguments.length > 2 && Array.isArray(arguments[2]) === false) {
+  if (arguments.length > 2 && children && Array.isArray(arguments[2]) === false) {
     children = slice(arguments, 2)
@@ -55,0 +55,0 @@ }

package.json

 {
   "name": "virtual-element",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "repository": "dekujs/virtual-element",
@@ -5,0 +5,0 @@ "description": "Build virtual tree elements",

test/index.js

@@ -77,2 +77,18 @@ /**
 
+it('should not treat undefined as a child', function () {
+  var node
+
+  node = element('div')
+  assert.strictEqual(node.children.length, 0)
+
+  node = element('div', undefined)
+  assert.strictEqual(node.children.length, 0)
+
+  node = element('div', {})
+  assert.strictEqual(node.children.length, 0)
+
+  node = element('div', {}, undefined)
+  assert.strictEqual(node.children.length, 0)
+})
+
 it('render nodes that work with JSX', function(){
@@ -83,2 +99,2 @@ assert.deepEqual(
   )
-})
+})

No alert changes

Improved metrics

Total package byte prevSize

10148

increased by4.23%

Lines of code

299

increased by4.18%

No dependency changes