vue-js-popover - npm Package Compare versions

Comparing version 1.1.3 to 1.1.4

dist/index.js

@@ -279,2 +279,6 @@ (function webpackUniversalModuleDefinition(root, factory) {
   },
+  beforeDestroy: function beforeDestroy() {
+    _bus.events.$off(this.showEventName, this.showEventListener);
+    _bus.events.$off(this.hideEventName, this.hideEventListener);
+  },
 
@@ -439,3 +443,3 @@ computed: {
 
-var addClickEventListener = function addClickEventListener(target, params, vnode) {
+var addClickEventListener = function addClickEventListener(target, params) {
   var click = function click(srcEvent) {
@@ -455,3 +459,3 @@ _bus.events.$emit('show:click', _extends({}, params, { target: target, srcEvent: srcEvent }));
 
-  vnode.__popoverRemoveClickHandlers = function () {
+  target.$popoverRemoveClickHandlers = function () {
     target.removeEventListener('click', click);
@@ -461,3 +465,3 @@ };
 
-var addHoverEventListener = function addHoverEventListener(target, params, vnode) {
+var addHoverEventListener = function addHoverEventListener(target, params) {
   var mouseover = function mouseover(srcEvent) {
@@ -474,3 +478,3 @@ _bus.events.$emit('show:hover', _extends({}, params, { target: target, srcEvent: srcEvent }));
 
-  vnode.__popoverRemoveHoverHandlers = function () {
+  target.$popoverRemoveHoverHandlers = function () {
     target.removeEventListener('mouseover', mouseover);
@@ -492,20 +496,14 @@ target.removeEventListener('mouseleave', mouseleave);
     Vue.directive('popover', {
-      bind: function bind(target, binding, vnode) {
+      bind: function bind(target, binding) {
         var params = prepareBinding(binding);
 
-        addClickEventListener(target, params, vnode);
-        addHoverEventListener(target, params, vnode);
+        addClickEventListener(target, params);
+        addHoverEventListener(target, params);
       },
-      unbind: function unbind(target, binding, vnode) {
-        if (vnode) {
-          vnode.__popoverRemoveHoverHandlers();
-          vnode.__popoverRemoveClickHandlers();
-        }
+      unbind: function unbind(target, binding) {
+        target.$popoverRemoveHoverHandlers();
+        target.$popoverRemoveClickHandlers();
       }
     });
 
-    if (params.debug) {
-      console.log('vue-js-popover | params:', params);
-    }
-
     if (params.tooltip) {
@@ -512,0 +510,0 @@ if (params.debug) {

package.json

 {
   "name": "vue-js-popover",
   "description": "Vue.js 2+ popover component",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "author": "euvl <[e-mail]>",
@@ -6,0 +6,0 @@ "private": false,

src/index.js

@@ -18,3 +18,3 @@ import Popover    from './Popover.vue'
 
-const addClickEventListener = (target, params, vnode) => {
+const addClickEventListener = (target, params) => {
   const click = (srcEvent) => {
@@ -34,3 +34,3 @@ events.$emit('show:click', { ...params, target, srcEvent })
 
-  vnode.__popoverRemoveClickHandlers = () => {
+  target.$popoverRemoveClickHandlers = () => {
     target.removeEventListener('click', click)
@@ -40,3 +40,3 @@ }
 
-const addHoverEventListener = (target, params, vnode) => {
+const addHoverEventListener = (target, params) => {
   const mouseover = (srcEvent) => {
@@ -53,3 +53,3 @@ events.$emit('show:hover', { ...params, target, srcEvent })
 
-  vnode.__popoverRemoveHoverHandlers = () => {
+  target.$popoverRemoveHoverHandlers = () => {
     target.removeEventListener('mouseover', mouseover)
@@ -69,20 +69,14 @@ target.removeEventListener('mouseleave', mouseleave)
     Vue.directive('popover', {
-      bind: function (target, binding, vnode) {
+      bind: function (target, binding) {
         let params = prepareBinding(binding)
 
-        addClickEventListener(target, params, vnode)
-        addHoverEventListener(target, params, vnode)
+        addClickEventListener(target, params)
+        addHoverEventListener(target, params)
       },
-      unbind: function (target, binding, vnode) {
-        if (vnode) {
-          vnode.__popoverRemoveHoverHandlers()
-          vnode.__popoverRemoveClickHandlers()
-        }
+      unbind: function (target, binding) {
+        target.$popoverRemoveHoverHandlers()
+        target.$popoverRemoveClickHandlers()
       }
     })
 
-    if (params.debug) {
-      console.log('vue-js-popover | params:', params)
-    }
-
     if (params.tooltip) {
@@ -89,0 +83,0 @@ if (params.debug) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

71014

decreased by-0.26%

Lines of code

871

decreased by-0.68%

No dependency changes