webpack-build-notifier - npm Package Compare versions

Comparing version 2.0.0 to 2.0.1

CHANGELOG.md

 # Changelog
 
+#### 2.0.1
+###### _May 23, 2020_
+
+- Fixed bug where setting *sound* to *false* had no effect ([#51](/../../issues/51)).
+
 #### 2.0.0
@@ -4,0 +9,0 @@ ###### _October 15, 2019_

dist/index.js

@@ -22,2 +22,3 @@ "use strict";
         var _this = this;
+        var _a, _b, _c, _d;
         this.appName = undefined;
@@ -29,6 +30,2 @@ this.buildSuccessful = false;
         this.sound = 'Submarine';
-        this.successSound = this.sound;
-        this.warningSound = this.sound;
-        this.failureSound = this.sound;
-        this.compilationSound = this.sound;
         this.suppressSuccess = false;
@@ -189,2 +186,8 @@ this.suppressWarning = false;
         Object.assign(this, cfg);
+        if (this.sound) {
+            this.successSound = (_a = this.successSound) !== null && _a !== void 0 ? _a : this.sound;
+            this.warningSound = (_b = this.warningSound) !== null && _b !== void 0 ? _b : this.sound;
+            this.failureSound = (_c = this.failureSound) !== null && _c !== void 0 ? _c : this.sound;
+            this.compilationSound = (_d = this.compilationSound) !== null && _d !== void 0 ? _d : this.sound;
+        }
         this.registerSnoreToast();
@@ -191,0 +194,0 @@ node_notifier_1.default.on('click', this.onClick);

dist/types.d.ts

@@ -59,3 +59,3 @@ import NotificationCenter from 'node-notifier/notifiers/notificationcenter';
      */
-    onCompileStart?: (compiler: webpack.compiler.Compiler) => void;
+    onCompileStart?: (compilation: webpack.compiler.Compiler) => void;
     /**
@@ -62,0 +62,0 @@ * A function which is invoked when compilation completes. Optional. The function is passed two parameters:

dist/types.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.CompilationStatus = void 0;
 /**
@@ -4,0 +5,0 @@ * Enum representing valid compilation result statuses.

package.json

 {
   "name": "webpack-build-notifier",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "A Webpack plugin that generates OS notifications for build steps using node-notifier.",
@@ -53,5 +53,5 @@ "main": "dist/index.js",
     "tslint-config-airbnb": "^5.11.2",
-    "typescript": "^3.6.4",
+    "typescript": "^3.9.3",
     "webpack": "^4.41.2"
   }
-}
+}

README.md

@@ -60,3 +60,3 @@ # webpack-build-notifier
 A function which is invoked when compilation starts. Optional. The function is passed one parameter:
-* {webpack.compiler.Compiler} compiler - The webpack Compiler instance.
+* {webpack.compilation.Compilation} compilation - The webpack Compilation instance.
 Note that `suppressCompileStart` must be `false`.
@@ -63,0 +63,0 @@

No alert changes

Improved metrics

Total package byte prevSize

112308

increased by0.45%

Lines of code

418

increased by0.97%

No dependency changes