webrtc-adapter - npm Package Compare versions

Comparing version 6.1.0 to 6.1.1

package.json

 {
   "name": "webrtc-adapter",
-  "version": "6.1.0",
+  "version": "6.1.1",
   "description": "A shim to insulate apps from WebRTC spec changes and browser prefix differences",
@@ -5,0 +5,0 @@ "license": "BSD-3-Clause",

src/js/chrome/chrome_shim.js

@@ -557,3 +557,3 @@
     // The RTCPeerConnection object.
-    if (!window.RTCPeerConnection) {
+    if (!window.RTCPeerConnection && window.webkitRTCPeerConnection) {
       window.RTCPeerConnection = function(pcConfig, pcConstraints) {
@@ -560,0 +560,0 @@ // Translate iceTransportPolicy to iceTransports,

src/js/common_shim.js

@@ -117,3 +117,3 @@ /*
   shimMaxMessageSize: function(window) {
-    if (window.RTCSctpTransport) {
+    if (window.RTCSctpTransport || !window.RTCPeerConnection) {
       return;
@@ -120,0 +120,0 @@ }

src/js/utils.js

@@ -147,4 +147,3 @@ /*
 
-    // Firefox.
-    if (navigator.mozGetUserMedia) {
+    if (navigator.mozGetUserMedia) { // Firefox.
       result.browser = 'firefox';
@@ -154,18 +153,7 @@ result.version = extractVersion(navigator.userAgent,
     } else if (navigator.webkitGetUserMedia) {
-      // Chrome, Chromium, Webview, Opera, all use the chrome shim for now
-      if (window.webkitRTCPeerConnection) {
-        result.browser = 'chrome';
-        result.version = extractVersion(navigator.userAgent,
+      // Chrome, Chromium, Webview, Opera.
+      // Version matches Chrome/WebRTC version.
+      result.browser = 'chrome';
+      result.version = extractVersion(navigator.userAgent,
           /Chrom(e|ium)\/(\d+)\./, 2);
-      } else { // Safari (in an unpublished version) or unknown webkit-based.
-        if (navigator.userAgent.match(/Version\/(\d+).(\d+)/)) {
-          result.browser = 'safari';
-          result.version = extractVersion(navigator.userAgent,
-            /AppleWebKit\/(\d+)\./, 1);
-        } else { // unknown webkit-based browser.
-          result.browser = 'Unsupported webkit-based browser ' +
-              'with GUM support but no WebRTC support.';
-          return result;
-        }
-      }
     } else if (navigator.mediaDevices &&
@@ -177,4 +165,3 @@ navigator.userAgent.match(/Edge\/(\d+).(\d+)$/)) { // Edge.
     } else if (navigator.mediaDevices &&
-        navigator.userAgent.match(/AppleWebKit\/(\d+)\./)) {
-        // Safari, with webkitGetUserMedia removed.
+        navigator.userAgent.match(/AppleWebKit\/(\d+)\./)) { // Safari.
       result.browser = 'safari';
@@ -181,0 +168,0 @@ result.version = extractVersion(navigator.userAgent,

test/unit/detectBrowser.js

@@ -55,12 +55,2 @@ /*
 
-  it('detects Safari if navigator.webkitGetUserMedia exists', () => {
-    navigator.userAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) ' +
-          'AppleWebKit/604.1.6 (KHTML, like Gecko) Version/10.2 Safari/604.1.6';
-    navigator.webkitGetUserMedia = function() {};
-
-    const browserDetails = detectBrowser(window);
-    expect(browserDetails.browser).to.equal('safari');
-    expect(browserDetails.version).to.equal(604);
-  });
-
   it('detects Safari if navigator.mediaDevices exists', () => {
@@ -67,0 +57,0 @@ navigator.userAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) ' +

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

815964

decreased by-0.37%

Lines of code

19194

decreased by-0.38%

No dependency changes