websocket-stream - npm Package Compare versions

Comparing version 3.3.0 to 3.3.1

package.json

 {
   "name": "websocket-stream",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "license": "BSD-2-Clause",
@@ -5,0 +5,0 @@ "description": "Use websockets with the node streams API. Works in browser and node",

stream.js

@@ -64,3 +64,3 @@ var through = require('through2')
   function socketWriteNode(chunk, enc, next) {
-    if (coerceToBuffer && !(chunk instanceof Buffer)) {
+    if (coerceToBuffer && typeof chunk === 'string') {
       chunk = new Buffer(chunk, 'utf8')
@@ -77,2 +77,6 @@ }
 
+    if (coerceToBuffer && typeof chunk === 'string') {
+      chunk = new Buffer(chunk, 'utf8')
+    }
+
     try {
@@ -79,0 +83,0 @@ socket.send(chunk)

test-client.js

@@ -50,1 +50,12 @@ var ws = require('./')
 })
+
+test('coerce client data as binary', function(t) {
+  var stream = ws('ws://localhost:8346', { binary: true })
+  stream.on('data', function(o) {
+    t.ok(Buffer.isBuffer(o), 'is buffer')
+    t.equal(o.toString(), 'success', 'success!')
+    stream.destroy()
+    t.end()
+  })
+  stream.write('hello')
+})

test-server.js

 var http = require('http')
 var websocket = require('./')
 var echo = require('./echo-server.js')
+var WebSocketServer = require('ws').Server
 
@@ -32,1 +33,24 @@ echo.start(function(){
 })
+
+function checkIfDataIsBinary () {
+  var server = http.createServer()
+  var wss = new WebSocketServer({
+    server: server
+  })
+
+  server.listen(8346)
+
+  wss.on('connection', waitFor)
+
+  function waitFor (ws) {
+    ws.on('message', function (data) {
+      if (!Buffer.isBuffer(data)) {
+        ws.send(new Buffer('fail'))
+      } else {
+        ws.send(new Buffer('success'))
+      }
+    })
+  }
+}
+
+checkIfDataIsBinary()

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

17798

increased by5.11%

Lines of code

444

increased by7.77%

No dependency changes