websocket-stream - npm Package Compare versions

Comparing version 5.5.0 to 5.5.1

package.json

 {
   "name": "websocket-stream",
-  "version": "5.5.0",
+  "version": "5.5.1",
   "license": "BSD-2-Clause",
@@ -5,0 +5,0 @@ "description": "Use websockets with the node streams API. Works in browser and node",

stream.js

@@ -71,2 +71,8 @@ 'use strict'
   }
+  
+  // according to https://github.com/baygeldin/ws-streamify/issues/1
+  // Nodejs WebSocketServer cause memory leak
+  // Handlers like onerror, onclose, onmessage and onopen are accessible via setter/getter
+  // And setter first of all fires removeAllListeners, that doesnt make inner array of clients on WebSocketServer cleared ever
+  var eventListenerSupport = ('undefined' === typeof socket.addEventListener)
 
@@ -81,3 +87,8 @@ // was already open when passed in
     }
-    socket.onopen = onopen
+    
+    if (eventListenerSupport) {
+       socket.addEventListener('open', onopen)
+    } else {
+       socket.onopen = onopen
+    }
   }
@@ -87,5 +98,11 @@
 
-  socket.onclose = onclose
-  socket.onerror = onerror
-  socket.onmessage = onmessage
+  if (eventListenerSupport) {
+     socket.addEventListener('close', onopen)
+     socket.addEventListener('error', onerror)
+     socket.addEventListener('message', onmessage)
+  } else {
+     socket.onclose = onclose
+     socket.onerror = onerror
+     socket.onmessage = onmessage
+  }
 
@@ -92,0 +109,0 @@ proxy.on('close', destroy)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

27899

increased by2.64%

Lines of code

686

increased by2.24%

No dependency changes