wolfy87-eventemitter - npm Package Compare versions

Comparing version 5.0.0 to 5.1.0

bower.json

 {
     "name": "eventEmitter",
     "description": "Event based JavaScript for the browser",
-    "version": "5.0.0",
+    "version": "5.1.0",
     "main": [
@@ -6,0 +6,0 @@ "./EventEmitter.js"

component.json

@@ -5,3 +5,3 @@ {
     "description": "Event based JavaScript for the browser.",
-    "version": "5.0.0",
+    "version": "5.1.0",
     "scripts": ["EventEmitter.js"],
@@ -8,0 +8,0 @@ "main": "EventEmitter.js",

docs/guide.md

@@ -36,3 +36,3 @@ # Guide
 ```html
-<script type='text/javascript' src='/assets/js/EventEmitter/EventEmitter.js'></script>
+<script src='/assets/js/EventEmitter/EventEmitter.js'></script>
 ```
@@ -43,3 +43,3 @@
 ```html
-<script type='text/javascript' src='/assets/js/EventEmitter-VERSION.min.js'></script>
+<script src='/assets/js/EventEmitter-VERSION.min.js'></script>
 ```
@@ -46,0 +46,0 @@

EventEmitter.js

 /*!
- * EventEmitter v5.0.0 - git.io/ee
+ * EventEmitter v5.1.0 - git.io/ee
  * Unlicense - http://unlicense.org/
@@ -8,3 +8,3 @@ * Oliver Caldwell - http://oli.me.uk/
 
-;(function () {
+;(function (exports) {
     'use strict';
@@ -22,3 +22,2 @@
     var proto = EventEmitter.prototype;
-    var exports = this;
     var originalGlobalValue = exports.EventEmitter;
@@ -124,2 +123,12 @@
 
+    function isValidListener (listener) {
+        if (typeof listener === 'function' || listener instanceof RegExp) {
+            return true
+        } else if (listener && typeof listener === 'object') {
+            return isValidListener(listener.listener)
+        } else {
+            return false
+        }
+    }
+
     /**
@@ -136,2 +145,6 @@ * Adds a listener function to the specified event.
     proto.addListener = function addListener(evt, listener) {
+        if (!isValidListener(listener)) {
+            throw new TypeError('listener must be a function');
+        }
+
         var listeners = this.getListenersAsObject(evt);
@@ -477,2 +490,2 @@ var listenerIsWrapped = typeof listener === 'object';
     }
-}.call(this));
+}(this || {}));

EventEmitter.min.js

 /*!
- * EventEmitter v5.0.0 - git.io/ee
+ * EventEmitter v5.1.0 - git.io/ee
  * Unlicense - http://unlicense.org/
@@ -4,0 +4,0 @@ * Oliver Caldwell - http://oli.me.uk/

package.json

 {
-    "name": "wolfy87-eventemitter",
-    "version": "5.0.0",
-    "description": "Event based JavaScript for the browser",
-    "main": "EventEmitter.js",
-    "directories": {
-        "doc": "docs",
-        "test": "tests"
-    },
-    "repository": {
-        "type": "git",
-        "url": "git://github.com/Olical/EventEmitter.git"
-    },
-    "keywords": [
-        "eventemitter",
-        "events",
-        "browser",
-        "amd"
-    ],
-    "author": {
-        "name": "Oliver Caldwell",
-        "email": "[e-mail]",
-        "url": "http://oli.me.uk/"
-    },
-    "license": "Unlicense",
-    "readmeFilename": "README.md",
-    "bugs": {
-        "url": "https://github.com/Olical/EventEmitter/issues"
-    },
-    "devDependencies": {
-        "uglify-js": "*",
-        "mocha": "*",
-        "chai": "*",
-        "dox": "*",
-        "dustjs-linkedin": "*",
-        "dustjs-helpers": "*"
-    }
+  "name": "wolfy87-eventemitter",
+  "version": "5.1.0",
+  "description": "Event based JavaScript for the browser",
+  "main": "EventEmitter.js",
+  "directories": {
+    "doc": "docs",
+    "test": "tests"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/Olical/EventEmitter.git"
+  },
+  "keywords": [
+    "eventemitter",
+    "events",
+    "browser",
+    "amd"
+  ],
+  "author": {
+    "name": "Oliver Caldwell",
+    "email": "[e-mail]",
+    "url": "http://oli.me.uk/"
+  },
+  "license": "Unlicense",
+  "readmeFilename": "README.md",
+  "bugs": {
+    "url": "https://github.com/Olical/EventEmitter/issues"
+  },
+  "devDependencies": {
+    "uglify-js": "*",
+    "mocha": "*",
+    "chai": "*",
+    "dox": "*",
+    "dustjs-linkedin": "*",
+    "dustjs-helpers": "*"
+  }
 }

tests/tests.js

@@ -149,2 +149,8 @@ (function () {
         });
+
+        test('it throws if you try to add a non-function/regex listener', function () {
+            assert.throws(ee.addListener.bind(ee, 'foo', null), /listener must be a function/)
+            assert.throws(ee.addListener.bind(ee, 'foo'), /listener must be a function/)
+            assert.throws(ee.addListener.bind(ee, 'foo', 'lol'), /listener must be a function/)
+        })
     });
@@ -151,0 +157,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

79861

increased by0.81%

Lines of code

1169

increased by1.39%

No dependency changes