x-default-browser - npm Package Compare versions

Comparing version 0.5.0 to 0.5.1

lib/detect-mac.js

@@ -1,17 +0,12 @@
-var defaultBrowserMac = require('default-browser-id');
+var defaultBrowserMac = require("default-browser-id");
 
-var exec = require('child_process').exec;
+var exec = require("child_process").exec;
 
 module.exports = function (callback) {
+  defaultBrowserMac()
+    .then(function (browserId) {
+      var value = browserId;
+      var valueLC = value.toLowerCase();
 
-    defaultBrowserMac(function (err, browserId) {
-        if(err) {
-            callback('Unable to retrieve default browser: ' + err);
-            return;
-        }
-
-        var value = browserId;
-        var valueLC = value.toLowerCase();
-
-        /*
+      /*
             Safari         com.apple.Safari
@@ -22,17 +17,22 @@ Google Chrome  com.google.chrome
          */
-        var out = {
-            isIE:       false,
-            isSafari:   valueLC.indexOf('safari') > -1,
-            isFirefox:  valueLC.indexOf('firefox') > -1,
-            isChrome:   valueLC.indexOf('google') > -1,
-            isChromium: valueLC.indexOf('chromium') > -1, // untested
-            isOpera:    valueLC.indexOf('opera') > -1,
-            identity:   value
-        };
-        out.isBlink = (out.isChrome || out.isChromium || out.isOpera);
-        out.isWebkit = (out.isSafari || out.isBlink);
-        out.commonName = require('./common-name')(out);
+      var out = {
+        isIE: false,
+        isSafari: valueLC.indexOf("safari") > -1,
+        isFirefox: valueLC.indexOf("firefox") > -1,
+        isChrome: valueLC.indexOf("google") > -1,
+        isChromium: valueLC.indexOf("chromium") > -1, // untested
+        isOpera: valueLC.indexOf("opera") > -1,
+        identity: value,
+      };
+      out.isBlink = out.isChrome || out.isChromium || out.isOpera;
+      out.isWebkit = out.isSafari || out.isBlink;
+      out.commonName = require("./common-name")(out);
 
-        callback(null, out);
+      callback(null, out);
+    })
+    .catch(function (err) {
+      if (err) {
+        callback("Unable to retrieve default browser: " + err);
+      }
     });
 };

package.json

 {
   "name": "x-default-browser",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Detect default web browser of the current user, cross-platform (Win/Lin/Mac)",
@@ -5,0 +5,0 @@ "author": "Jakub Gieryluk <[e-mail]>",

test/macos.js

@@ -1,3 +0,3 @@
-var assert = require('assert');
-var detect = require('rewire')('../lib/detect-mac');
+var assert = require("assert");
+var detect = require("rewire")("../lib/detect-mac");
 
@@ -9,9 +9,13 @@ var defaultBrowserIdResponse = {
 
-var defaultBrowserIdStub = function (cb) {
-  cb(defaultBrowserIdResponse.err, defaultBrowserIdResponse.browserId);
+var defaultBrowserIdStub = function () {
+  if (defaultBrowserIdResponse.err) {
+    return Promise.reject(defaultBrowserIdResponse.err);
+  } else {
+    return Promise.resolve(defaultBrowserIdResponse.browserId);
+  }
 };
 
-detect.__set__('defaultBrowserMac', defaultBrowserIdStub);
+detect.__set__("defaultBrowserMac", defaultBrowserIdStub);
 
-describe('macOS tests', function () {
+describe("macOS tests", function () {
   beforeEach(function () {
@@ -22,4 +26,4 @@ defaultBrowserIdResponse.err = undefined;
 
-  it('detects chrome', function (done) {
-    defaultBrowserIdResponse.browserId = 'com.google.chrome';
+  it("detects chrome", function (done) {
+    defaultBrowserIdResponse.browserId = "com.google.chrome";
 
@@ -30,3 +34,3 @@ detect(function (err, res) {
       assert.equal(res.isWebkit, true);
-      assert.equal(res.commonName, 'chrome');
+      assert.equal(res.commonName, "chrome");
       assert.equal(res.identity, defaultBrowserIdResponse.browserId);
@@ -37,4 +41,4 @@ done(err);
 
-  it('detects opera', function (done) {
-    defaultBrowserIdResponse.browserId = 'com.operasoftware.Opera';
+  it("detects opera", function (done) {
+    defaultBrowserIdResponse.browserId = "com.operasoftware.Opera";
 
@@ -46,3 +50,3 @@ detect(function (err, res) {
       assert.equal(res.isWebkit, true);
-      assert.equal(res.commonName, 'opera');
+      assert.equal(res.commonName, "opera");
       assert.equal(res.identity, defaultBrowserIdResponse.browserId);
@@ -53,4 +57,4 @@ done(err);
 
-  it('detects firefox', function (done) {
-    defaultBrowserIdResponse.browserId = 'org.mozilla.firefox';
+  it("detects firefox", function (done) {
+    defaultBrowserIdResponse.browserId = "org.mozilla.firefox";
 
@@ -60,3 +64,3 @@ detect(function (err, res) {
       assert.equal(res.isWebkit, false);
-      assert.equal(res.commonName, 'firefox');
+      assert.equal(res.commonName, "firefox");
       assert.equal(res.identity, defaultBrowserIdResponse.browserId);
@@ -67,4 +71,4 @@ done(err);
 
-  it('detects safari', function (done) {
-    defaultBrowserIdResponse.browserId = 'com.apple.Safari';
+  it("detects safari", function (done) {
+    defaultBrowserIdResponse.browserId = "com.apple.Safari";
 
@@ -78,3 +82,3 @@ detect(function (err, res) {
       assert.equal(res.isWebkit, true);
-      assert.equal(res.commonName, 'safari');
+      assert.equal(res.commonName, "safari");
       assert.equal(res.identity, defaultBrowserIdResponse.browserId);
@@ -81,0 +85,0 @@ done(err);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Shell access

Supply chain risk

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

27034

increased by2.19%

Number of package files

19

increased by5.56%

Lines of code

550

increased by1.1%

No dependency changes