zip-dir - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

index.js

@@ -28,3 +28,5 @@ var Zip = require('jszip');
   dive(rootDir, function (err) {
-    callback(err, zip.generate({
+    if (err) return callback(err);
+
+    callback(null, zip.generate({
       compression: 'DEFLATE',
@@ -37,2 +39,3 @@ type: 'nodebuffer'
     fs.readdir(dir, function (err, files) {
+      if (err) return callback(err);
       var count = files.length;
@@ -39,0 +42,0 @@ files.forEach(function (file) {

package.json

 {
   "name": "zip-dir",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Zips up directories into buffers or saves zipped files to disk",
@@ -5,0 +5,0 @@ "main": "index.js",

test/zip-dir.test.js

@@ -24,2 +24,18 @@ var Zip = require('jszip');
     });
+
+    it('returns an error when dirPath doesn\'t exist', function (done) {
+      zipDir(xpiPath, function (err, buffer) {
+        expect(err).to.be.ok;
+        expect(buffer).to.not.be.ok;
+        done();
+      });
+    });
+
+    it('returns an error when dirPath is a file', function (done) {
+      zipDir(path.join(sampleZipPath, 'file1.json'), function (err, buffer) {
+        expect(err).to.be.ok;
+        expect(buffer).to.not.be.ok;
+        done();
+      });
+    });
   });
@@ -26,0 +42,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6682

increased by8.86%

Lines of code

144

increased by12.5%

No dependency changes