zipkin-javascript-opentracing - npm Package Compare versions

Comparing version 0.1.3 to 0.2.0

__tests__/index.js

@@ -574,13 +574,6 @@ const opentracing = require('opentracing');
 
-            it('should return a valid without http headers', () => {
+            it('should return null without http headers', () => {
                 expect(() => {
                     const span = tracer.extract(Tracer.FORMAT_HTTP_HEADERS, {});
-                    expect(zipkinTracer.scoped).toHaveBeenCalled();
-                    zipkinTracer.scoped.mock.calls[0][0]();
-
-                    expect(span.id.traceId).toBeDefined();
-                    expect(span.id.spanId).toBeDefined();
-                    expect(span.id.sampled).toBeDefined();
-                    expect(span.log).toBeInstanceOf(Function);
-                    expect(span.finish).toBeInstanceOf(Function);
+                    expect(span).toBe(null);
                 }).not.toThrowError();
@@ -587,0 +580,0 @@ });

index.js

@@ -247,2 +247,6 @@ const {
 
+        if (!carrier[HttpHeaders.TraceId]) {
+            return null;
+        }
+
         // XXX: no empty string here v
@@ -249,0 +253,0 @@ // We should send the span name too

package.json

 {
   "name": "zipkin-javascript-opentracing",
-  "version": "0.1.3",
+  "version": "0.2.0",
   "description": "An opentracing implementation for zipkin",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

158024

decreased by-0.2%

Lines of code

1465

decreased by-0.2%

No dependency changes