zipkin-javascript-opentracing - npm Package Compare versions

Comparing version 1.5.1 to 1.6.0

lib/index.js

@@ -170,6 +170,2 @@ "use strict";
 
-        if (!Object.values(availableTags).includes(key)) {
-          throw new Error("OpenTracing does not support tag \"" + key + "\"");
-        }
-
         tracer.scoped(function () {
@@ -179,2 +175,3 @@ // make sure correct id is set
 
+          // some tags are treated specially by Zipkin
           switch (key) {
@@ -198,4 +195,5 @@ case availableTags.PEER_ADDRESS:
 
+            // Otherwise, set arbitrary key/value tags using Zipkin binary annotations
             default:
-              throw new Error("Unsupported tag \"" + key + "\" could not be set");
+              tracer.recordAnnotation(new Annotation.BinaryAnnotation(key, value));
           }
@@ -238,3 +236,3 @@ });
       if (options.endpoint.indexOf("http") === -1) {
-        throw new Error("recorder value needs to start with http:// or https://");
+        throw new Error("endpoint value needs to start with http:// or https://");
       }
@@ -241,0 +239,0 @@

package.json

 {
   "name": "zipkin-javascript-opentracing",
-  "version": "1.5.1",
+  "version": "1.6.0",
   "description": "An opentracing implementation for zipkin",
@@ -30,4 +30,3 @@ "main": "lib/index.js",
     "type": "git",
-    "url":
-      "git+ssh://[e-mail]/DanielMSchmidt/zipkin-javascript-opentracing.git"
+    "url": "git+ssh://[e-mail]/DanielMSchmidt/zipkin-javascript-opentracing.git"
   },
@@ -45,6 +44,7 @@ "keywords": [
   "bugs": {
-    "url":
-      "https://github.com/DanielMSchmidt/zipkin-javascript-opentracing/issues"
+    "url": "https://github.com/DanielMSchmidt/zipkin-javascript-opentracing/issues"
   },
-  "files": ["lib/index.js"],
+  "files": [
+    "lib/index.js"
+  ],
   "peerDependencies": {
@@ -55,21 +55,23 @@ "opentracing": "*",
   },
-  "homepage":
-    "https://github.com/DanielMSchmidt/zipkin-javascript-opentracing#readme",
+  "homepage": "https://github.com/DanielMSchmidt/zipkin-javascript-opentracing#readme",
   "devDependencies": {
-    "babel-cli": "^6.26.0",
-    "babel-preset-env": "^1.6.1",
-    "coveralls": "^3.0.0",
-    "express": "^4.16.2",
-    "husky": "^0.14.3",
-    "jest": "^21.2.1",
-    "lint-staged": "^4.3.0",
-    "nodemon": "^1.12.1",
-    "opentracing": "*",
-    "prettier": "^1.8.1",
-    "zipkin": ">=0.9.0",
-    "zipkin-transport-http": ">=0.9.0"
+    "babel-cli": "6.26.0",
+    "babel-preset-env": "1.6.1",
+    "coveralls": "3.0.0",
+    "express": "4.16.3",
+    "husky": "0.14.3",
+    "jest": "22.4.3",
+    "lint-staged": "7.0.4",
+    "nodemon": "1.17.3",
+    "opentracing": "0.14.3",
+    "prettier": "1.12.0",
+    "zipkin": "0.10.1",
+    "zipkin-transport-http": "0.10.1"
   },
   "lint-staged": {
-    "*.{js,json,css,md}": ["prettier --write", "git add"]
+    "*.{js,css,md}": [
+      "prettier --write",
+      "git add"
+    ]
   }
 }

README.md

@@ -35,6 +35,2 @@ # Zipkin-Javascript-Opentracing [![Build Status](https://travis-ci.org/DanielMSchmidt/zipkin-javascript-opentracing.svg?branch=master)](https://travis-ci.org/DanielMSchmidt/zipkin-javascript-opentracing) [![Coverage Status](https://coveralls.io/repos/github/DanielMSchmidt/zipkin-javascript-opentracing/badge.svg?branch=master)](https://coveralls.io/github/DanielMSchmidt/zipkin-javascript-opentracing?branch=master)
 
-### Tags
-
-Zipkin doesn't distinguish between logs and tags.
-
 ### Additional options for starting a span
@@ -57,4 +53,3 @@
 To see how to use this library with only one service see
-`examples/vanillajs/basic`. You can run the example with `npm run
-example:basic`.
+`examples/vanillajs/basic`. You can run the example with `npm run example:basic`.
 
@@ -61,0 +56,0 @@ ### Advanced

No alert changes

Worsened metrics

Total package byte prevSize

16695

decreased by-0.4%

Lines of code

277

decreased by-0.36%

Number of lines in readme file

59

decreased by-7.81%

No dependency changes