zol - npm Package Compare versions

Comparing version 0.2.0 to 0.2.1

package.json

 {
   "name": "zol",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Type safe composable SQL abstraction layer",
@@ -5,0 +5,0 @@ "keywords": [

src/Column.ts

@@ -34,2 +34,6 @@ import { Exp } from "./Exp";
 
+function nullParser(val: string): never {
+    throw new Error(`Tried to parse a nullCol. This is likely a bug in zol, please report. Column value: "${val}"`);
+}
+
 export function nullCol<s>(): Col<s, null> {
@@ -41,3 +45,3 @@ return colWrap({
         },
-        parser: val => val
+        parser: nullParser
     });
@@ -85,2 +89,14 @@ }
 export function ifThenElse<s, a>(if_: Col<s, boolean>, then: Col<s, a>, else_: Col<s, a>): Col<s, a> {
+    // the "then" and "else_" columns are of the same type, so they
+    // (supposedly) have the same parser, so we can arbitrarily pick
+    // either one.
+    //
+    // However: we must watch out if "then" or "else_" was set to "nullCol()",
+    // and in that case choose the other one's parser.
+    //
+    // (If both "then" and "else_" were set to "nullCol()" then the
+    // the column will always have a NULL value and the parser we set
+    // here wlil never be called)
+    const parser = (<any>then).parser !== nullParser ? (<any>then).parser : (<any>else_).parser;
+
     return colWrap({
@@ -91,7 +107,3 @@ type: "EIfThenElse",
         expElse: colUnwrap(else_),
-
-        // the "then" and "else_" columns are of the same type, so they
-        // (supposedly) have the same parser, so we can arbitrarily pick
-        // either one:
-        parser: (<any>colUnwrap(then)).parser
+        parser: parser
     });
@@ -98,0 +110,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6516769

increased by0.04%

Lines of code

11729

increased by0.28%

No dependency changes