@adobe/helix-rum-enhancer - npm Package Compare versions

Comparing version 2.14.2 to 2.15.0

CHANGELOG.md

@@ -0,1 +1,16 @@
+# [2.15.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.14.2...v2.15.0) (2024-07-01)
+
+
+### Bug Fixes
+
+* use correct token for release ([094f37e](https://github.com/adobe/helix-rum-enhancer/commit/094f37ef2de8ddf5d64ea38c9071c9b1bec6119a))
+
+
+### Features
+
+* add more logic to button selector ([#205](https://github.com/adobe/helix-rum-enhancer/issues/205)) ([c9a5629](https://github.com/adobe/helix-rum-enhancer/commit/c9a5629e7e690397a5f46cbf8db08570f0c4d250))
+* clean up and trigger release ([bfc8d24](https://github.com/adobe/helix-rum-enhancer/commit/bfc8d241cd19b33975ac37be5167783b99fbe54c))
+* switch release token ([0e5b3b0](https://github.com/adobe/helix-rum-enhancer/commit/0e5b3b03d0b96a32118340e7b6f004da8660f0aa))
+* trigger release ([bf26949](https://github.com/adobe/helix-rum-enhancer/commit/bf269492cb330c55d22fd0eeed4aad4cfdac57a3))
+
 ## [2.14.2](https://github.com/adobe/helix-rum-enhancer/compare/v2.14.1...v2.14.2) (2024-06-12)
@@ -2,0 +17,0 @@

modules/dom.js

@@ -57,7 +57,21 @@ /*
 
-    if (Array.from(element.classList).some((className) => className.match(/button|cta/))) {
-      return blockName ? `.${blockName} .button` : '.button';
+    const classes = Array.from(element.classList);
+    const label = element.tagName.toLowerCase();
+    const firstClass = classes.length > 0 ? `.${classes[0]}` : '';
+    const labelWithClass = `${element.tagName.toLowerCase()}${firstClass}`;
+    if (element.tagName.toLowerCase() === 'button'
+      || element.type === 'button'
+      || classes.some((className) => className.match(/button|cta/))) {
+      let parent = element.parentElement;
+      if (!parent) return labelWithClass;
+      if (parent.id) return `#${parent.id} ${label}`;
+      while (parent.tagName !== 'BODY' && !parent.id) parent = parent.parentElement;
+      if (parent.id) return `#${parent.id} ${labelWithClass}`;
+      return blockName ? `.${blockName} ${labelWithClass}` : labelWithClass;
     }
 
-    return sourceSelector(element.parentElement);
+    const parent = sourceSelector(element.parentElement);
+    if (parent) return parent;
+
+    return labelWithClass;
     /* c8 ignore next 3 */
@@ -64,0 +78,0 @@ } catch (error) {

package.json

 {
   "name": "@adobe/helix-rum-enhancer",
-  "version": "2.14.2",
+  "version": "2.15.0",
   "description": "Helix RUM Enhancer",
@@ -45,3 +45,3 @@ "main": "src/index.js",
     "@web/test-runner-playwright": "0.11.0",
-    "c8": "10.0.0",
+    "c8": "10.1.2",
     "codecov": "3.8.3",
@@ -54,4 +54,4 @@ "eslint": "8.57.0",
     "junit-report-builder": "3.2.1",
-    "lint-staged": "15.2.5",
-    "mocha": "10.4.0",
+    "lint-staged": "15.2.7",
+    "mocha": "10.5.2",
     "mocha-multi-reporters": "1.5.1",
@@ -58,0 +58,0 @@ "rollup": "4.18.0",

src/index.js

@@ -103,7 +103,21 @@ /*
 
-      if (Array.from(element.classList).some((className) => className.match(/button|cta/))) {
-        return blockName ? `.${blockName} .button` : '.button';
+      const classes = Array.from(element.classList);
+      const label = element.tagName.toLowerCase();
+      const firstClass = classes.length > 0 ? `.${classes[0]}` : '';
+      const labelWithClass = `${element.tagName.toLowerCase()}${firstClass}`;
+      if (element.tagName.toLowerCase() === 'button'
+        || element.type === 'button'
+        || classes.some((className) => className.match(/button|cta/))) {
+        let parent = element.parentElement;
+        if (!parent) return labelWithClass;
+        if (parent.id) return `#${parent.id} ${label}`;
+        while (parent.tagName !== 'BODY' && !parent.id) parent = parent.parentElement;
+        if (parent.id) return `#${parent.id} ${labelWithClass}`;
+        return blockName ? `.${blockName} ${labelWithClass}` : labelWithClass;
       }
 
-      return sourceSelector(element.parentElement);
+      const parent = sourceSelector(element.parentElement);
+      if (parent) return parent;
+
+      return labelWithClass;
     } catch (error) {
@@ -110,0 +124,0 @@ return null;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

82429

increased by2.78%

Lines of code

1010

increased by2.64%

No dependency changes