@adv-ui/ma-segment-wrapper - npm Package Compare versions

Comparing version 1.25.0 to 1.26.0

CHANGELOG.md

 # CHANGELOG
 
-# 1.25.0 (2022-02-07)
+# 1.26.0 (2022-03-01)
 
 
+### Features
+
+* **middlewares:** add event mapper for Optimizely ([c8c66ef](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/c8c66ef83e68f004d01490cf26a4c523b516d8d9))
+* **middlewares:** remove unnecessary Optimizely account event mappers ([95ad35e](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/95ad35ebe4a82c5a86b2c094c8101324d0c12d77))
+* **middlewares:** remove unnecessary Optimizely shipping event mappers ([410bf6d](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/410bf6dee4254b4a1c5ebc396273ca54f97b3996))
+* **Root:** bump version ([e042f23](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/e042f238a0678ded4538a375783fd479b9214cf6))
+
+
+
+# [1.25.0](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/compare/1.24.0...1.25.0) (2022-02-07)
+
+
 ### Bug Fixes
@@ -183,3 +195,2 @@
 
-* **middlewares:** add googleAdsTracking destination middleware ([2edd03b](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/2edd03bdbc0ec5ec9f4730de690874ef78546562))
 * **middlewares:** create googleAdsTrackings middleware and it's utils ([6cab6c7](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/6cab6c71f43579ab1dcfe22ac7d0da66f05e0500))
@@ -208,3 +219,2 @@ * **middlewares:** mutate event from obj instead of event_name_adobe ([75edf19](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/75edf191b840cd74cd4b69d74fe72736c0a2bb18))
 * **middlewares:** use properly name for get leads events fn ([e3ad487](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/e3ad487d56d66d342df65e0fd2c8fd0f54965b4e))
-* **Root:** rollback precommit ([7b0436b](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/7b0436b9ae00ee6f872c3a0eb79e640f3021c534))
 
@@ -214,36 +224,9 @@
 
-* **middlewares:** add phone, favorite and chat leads ([4b23f3a](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/4b23f3a61155799524f732a1b783e7032645a30d))
 * **middlewares:** adds a test to each event ([5374084](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/5374084ec725829c71ea49794f38aed4af1d4e3d))
-* **middlewares:** adds new events to send to optimizely ([ff4afdd](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/ff4afddb0e595feda609d7bbd1bbbaee4d548bbd))
 
 
 
-# [1.6.0](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/compare/1.5.0...1.6.0) (2021-05-20)
+# 1.6.0 (2021-05-20)
 
 
-### Bug Fixes
 
-* **middlewares:** fix middleware import ([5c2109c](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/5c2109c750f4f1df002ac218ab93757fe0e7763d))
-* **middlewares:** move optimizelyUserIdMiddleware to destination middleware ([a75a8c8](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/a75a8c8937f681f0015248983c87a5384de40704))
-
-
-### Features
-
-* **middlewares:** optimizely detail view tracks in destination middleware ([27f9b67](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/27f9b671c519b697640a57473e7d8c937623c0e8))
-
-
-
-# [1.5.0](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/compare/1.4.0...1.5.0) (2021-05-17)
-
-
-### Features
-
-* **middlewares:** add destination middleware to optimizely ([5f534fe](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/5f534fe22eefe751373e2b41f8368c9a77b94d9c))
-* **Root:** use default dist in travis ([52746e4](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/52746e4379756196a4d3043d4ee468789b06a883))
-
-
-
-# 1.4.0 (2021-05-04)
-
-
-

lib/middlewares/destination/optimizely/events/getAccountEvents.js

@@ -11,11 +11,3 @@ export function getAccountEvents(_ref) {
 
-  if (event === 'User Validation Button Clicked') {
-    optimizelyLeadEvents.push('User Validation Button Clicked');
-  }
-
-  if (event === 'Profile Picture Changed') {
-    optimizelyLeadEvents.push('Profile Picture Changed');
-  }
-
   return optimizelyLeadEvents;
 }

lib/middlewares/destination/optimizely/events/getPostingEvents.js

@@ -0,1 +1,2 @@
+import { isMiscVertical } from '../utils.js';
 export function getPostingEvents(_ref) {
@@ -11,3 +12,9 @@ var event = _ref.event,
 
+  if (event === 'Ad Inserted' && isMiscVertical({
+    properties: properties
+  })) {
+    optimizelyLeadEvents.push('Ad Inserted Misc');
+  }
+
   return optimizelyLeadEvents;
 }

lib/middlewares/destination/optimizely/events/getShippingEvents.js

@@ -11,10 +11,2 @@ export function getShippingEvents(_ref) {
 
-  if (event === 'Offer Make Button Clicked') {
-    optimizelyLeadEvents.push('Offer Make Button Clicked');
-  }
-
-  if (event === 'Offer Reject Button Clicked') {
-    optimizelyLeadEvents.push('Offer Reject Button Clicked');
-  }
-
   if (event === 'Offer Accept Button Clicked' && properties.carrier_id === 'CORREOS') {
@@ -21,0 +13,0 @@ optimizelyLeadEvents.push('Correos Offer Accepted');

package.json

 {
   "name": "@adv-ui/ma-segment-wrapper",
-  "version": "1.25.0",
+  "version": "1.26.0",
   "description": "Milanuncios Segment Wrapper",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

test/optimizelyAccountTrackingMiddlewareSpec.js

@@ -17,20 +17,2 @@ import sinon from 'sinon'
     optimizelyEvents: ['Page Viewed cuenta verificada']
-  },
-  {
-    scope: 'User Validation Button Clicked',
-    payload: {
-      obj: {
-        event: 'User Validation Button Clicked'
-      }
-    },
-    optimizelyEvents: ['User Validation Button Clicked']
-  },
-  {
-    scope: 'Profile Picture Changed',
-    payload: {
-      obj: {
-        event: 'Profile Picture Changed'
-      }
-    },
-    optimizelyEvents: ['Profile Picture Changed']
   }
@@ -37,0 +19,0 @@ ]

test/optimizelyPostingTrackingMiddlewareSpec.js

@@ -19,2 +19,14 @@ import sinon from 'sinon'
   {
+    scope: 'Ad Inserted Misc',
+    payload: {
+      obj: {
+        event: 'Ad Inserted',
+        properties: {
+          vertical: 'miscellaneous'
+        }
+      }
+    },
+    optimizelyEvents: ['Ad Inserted Misc']
+  },
+  {
     scope: 'Nothing',
@@ -25,3 +37,4 @@ payload: {
         properties: {
-          is_package_weight_set: false
+          is_package_weight_set: false,
+          vertical: 'motor'
         }
@@ -28,0 +41,0 @@ }

test/optimizelyShippingTrackingMiddlewareSpec.js

@@ -19,20 +19,2 @@ import sinon from 'sinon'
   {
-    scope: 'Offer Make Button Clicked',
-    payload: {
-      obj: {
-        event: 'Offer Make Button Clicked'
-      }
-    },
-    optimizelyEvents: ['Offer Make Button Clicked']
-  },
-  {
-    scope: 'Offer Reject Button Clicked',
-    payload: {
-      obj: {
-        event: 'Offer Reject Button Clicked'
-      }
-    },
-    optimizelyEvents: ['Offer Reject Button Clicked']
-  },
-  {
     scope: 'Offer Accept Button Clicked CORREOS',
@@ -39,0 +21,0 @@ payload: {

No alert changes

Worsened metrics

Total package byte prevSize

171641

decreased by-1.2%

Lines of code

2013

decreased by-1.42%

No dependency changes