@adv-ui/ma-segment-wrapper - npm Package Compare versions

Comparing version 1.34.0 to 1.35.0

CHANGELOG.md

 # CHANGELOG
 
-# 1.34.0 (2022-07-18)
+# 1.35.0 (2022-08-22)
 
@@ -8,2 +8,11 @@
 
+* **Root:** add Ad Inserted Cars and Phone Visiblity variants ([c825d91](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/c825d91d9fe94cbd39d3cd7ebd158b8c94e02994))
+
+
+
+# [1.34.0](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/compare/1.33.0...1.34.0) (2022-07-18)
+
+
+### Features
+
 * **middlewares:** add file format ([94f78e9](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/94f78e994247669c3fe5b8c0fadd9914dca9e82c))
@@ -10,0 +19,0 @@ * **middlewares:** map pta view ([18c718f](https://github.mpi-internal.com/scmspain/frontend-ma--segment-wrapper/commit/18c718feba8b19126647c9d3423c67c107fb3e3e))

lib/middlewares/destination/optimizely/events/getPostingEvents.js

@@ -12,2 +12,12 @@ import { isMiscVertical } from '../utils.js';
 
+  if (event === 'Ad Inserted' && properties.category_level1 === 'Motor' && (properties.category_level2 === 'Coches' || properties.category_level2 === 'Todoterreno')) {
+    optimizelyLeadEvents.push('Ad Inserted Cars');
+
+    if (properties.is_phone_visibility_checked === 'true') {
+      optimizelyLeadEvents.push('Ad Inserted Cars Phone Visibility Checked');
+    } else if (properties.is_phone_visibility_checked === 'false') {
+      optimizelyLeadEvents.push('Ad Inserted Cars Phone Visibility Not Checked');
+    }
+  }
+
   if (event === 'Ad Inserted' && isMiscVertical({
@@ -14,0 +24,0 @@ properties: properties

package.json

 {
   "name": "@adv-ui/ma-segment-wrapper",
-  "version": "1.34.0",
+  "version": "1.35.0",
   "description": "Milanuncios Segment Wrapper",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

test/optimizelyPostingTrackingMiddlewareSpec.js

@@ -0,3 +1,4 @@
+import {expect} from 'chai'
 import sinon from 'sinon'
-import {expect} from 'chai'
+
 import {optimizelyTrackingMiddleware} from '../src/middlewares/destination/optimizely/index.js'
@@ -42,2 +43,49 @@
     optimizelyEvents: []
+  },
+  {
+    scope: 'Ad Inserted Cars',
+    payload: {
+      obj: {
+        event: 'Ad Inserted',
+        properties: {
+          category_level1: 'Motor',
+          category_level2: 'Coches'
+        }
+      }
+    },
+    optimizelyEvents: ['Ad Inserted Cars']
+  },
+  {
+    scope: 'Ad Inserted Cars Phone Visibility Checked',
+    payload: {
+      obj: {
+        event: 'Ad Inserted',
+        properties: {
+          category_level1: 'Motor',
+          category_level2: 'Coches',
+          is_phone_visibility_checked: 'true'
+        }
+      }
+    },
+    optimizelyEvents: [
+      'Ad Inserted Cars',
+      'Ad Inserted Cars Phone Visibility Checked'
+    ]
+  },
+  {
+    scope: 'Ad Inserted Cars Phone Visibility Not Checked',
+    payload: {
+      obj: {
+        event: 'Ad Inserted',
+        properties: {
+          category_level1: 'Motor',
+          category_level2: 'Coches',
+          is_phone_visibility_checked: 'false'
+        }
+      }
+    },
+    optimizelyEvents: [
+      'Ad Inserted Cars',
+      'Ad Inserted Cars Phone Visibility Not Checked'
+    ]
   }
@@ -44,0 +92,0 @@ ]

No alert changes

Improved metrics

Total package byte prevSize

196731

increased by1.15%

Lines of code

2436

increased by2.31%

No dependency changes