@ag-grid-enterprise/menu - npm Package Compare versions

Comparing version 24.0.0 to 24.1.0

dist/cjs/menu/contextMenu.d.ts

@@ -1,2 +0,2 @@
-import { BeanStub, Column, IContextMenuFactory, RowNode } from "@ag-grid-community/core";
+import { BeanStub, Column, IContextMenuFactory, RowNode, GridPanel } from "@ag-grid-community/core";
 export declare class ContextMenuFactory extends BeanStub implements IContextMenuFactory {
@@ -8,2 +8,4 @@ private popupService;
     private activeMenu;
+    private gridPanel;
+    registerGridComp(gridPanel: GridPanel): void;
     hideActiveMenu(): void;
@@ -10,0 +12,0 @@ private getMenuItems;

dist/cjs/menu/contextMenu.js

@@ -30,2 +30,5 @@ "use strict";
     }
+    ContextMenuFactory.prototype.registerGridComp = function (gridPanel) {
+        this.gridPanel = gridPanel;
+    };
     ContextMenuFactory.prototype.hideActiveMenu = function () {
@@ -109,3 +112,4 @@ this.destroyBean(this.activeMenu);
             positionCallback: positionCallback,
-            anchorToElement: mouseEvent.target
+            // so when browser is scrolled down, the context menu stays on the grid
+            anchorToElement: this.gridPanel.getGui()
         });
@@ -112,0 +116,0 @@ menu.afterGuiAttached({ container: 'contextMenu', hidePopup: hidePopup });

dist/cjs/menu/enterpriseMenu.d.ts

@@ -1,2 +0,2 @@
-import { AgEvent, BeanStub, Column, IMenuFactory } from "@ag-grid-community/core";
+import { AgEvent, BeanStub, Column, IMenuFactory, GridPanel } from "@ag-grid-community/core";
 export interface TabSelectedEvent extends AgEvent {
@@ -11,2 +11,4 @@ key: string;
     private activeMenu;
+    private gridPanel;
+    registerGridComp(gridPanel: GridPanel): void;
     hideActiveMenu(): void;
@@ -13,0 +15,0 @@ showMenuAfterMouseEvent(column: Column, mouseEvent: MouseEvent, defaultTab?: string): void;

dist/cjs/menu/enterpriseMenu.js

@@ -31,2 +31,5 @@ "use strict";
     }
+    EnterpriseMenuFactory.prototype.registerGridComp = function (gridPanel) {
+        this.gridPanel = gridPanel;
+    };
     EnterpriseMenuFactory.prototype.hideActiveMenu = function () {
@@ -99,6 +102,7 @@ this.destroyBean(this.activeMenu);
                 }
-            }
+            },
+            positionCallback: function () { positionCallback(menu); },
+            anchorToElement: this.gridPanel.getGui()
         });
         menu.afterGuiAttached({ hidePopup: hidePopup });
-        positionCallback(menu);
         if (!defaultTab) {
@@ -346,14 +350,16 @@ menu.showTabBasedOnPreviousSelection();
         var filterWrapper = this.filterManager.getOrCreateFilterWrapper(this.column, 'COLUMN_MENU');
-        var afterFilterAttachedCallback = null;
-        // slightly odd block this - this promise will always have been resolved by the time it gets here, so won't be
-        // async (_unless_ in react or similar, but if so why not encountered before now?).
-        // I'd suggest a future improvement would be to remove/replace this promise as this block just wont work if it is
-        // async and is confusing if you don't have this context
-        if (filterWrapper.filterPromise) {
+        var afterFilterAttachedCallback = function (params) {
+            if (!filterWrapper.filterPromise) {
+                return;
+            }
+            // slightly odd block this - this promise will always have been resolved by the time it gets here, so won't be
+            // async (_unless_ in react or similar, but if so why not encountered before now?).
+            // I'd suggest a future improvement would be to remove/replace this promise as this block just wont work if it is
+            // async and is confusing if you don't have this context
             filterWrapper.filterPromise.then(function (filter) {
                 if (filter.afterGuiAttached) {
-                    afterFilterAttachedCallback = filter.afterGuiAttached.bind(filter);
+                    filter.afterGuiAttached(params);
                 }
             });
-        }
+        };
         this.tabItemFilter = {
@@ -360,0 +366,0 @@ title: core_1._.createIconNoSpan('filter', this.gridOptionsWrapper, this.column),

dist/cjs/menu/menuItemComponent.d.ts

@@ -1,2 +0,2 @@
-import { AgEvent, Component, MenuItemDef, IComponent } from "@ag-grid-community/core";
+import { AgEvent, Component, MenuItemDef, IComponent, ITooltipParams } from "@ag-grid-community/core";
 export interface MenuItemSelectedEvent extends AgEvent {
@@ -36,4 +36,2 @@ name: string;
     private init;
-    getTooltipText(): string;
-    getComponentHolder(): undefined;
     isDisabled(): boolean;
@@ -48,2 +46,3 @@ openSubMenu(activateFirstItem?: boolean): void;
     private addTooltip;
+    getTooltipParams(): ITooltipParams;
     private addShortcut;
@@ -50,0 +49,0 @@ private addSubMenu;

dist/cjs/menu/menuItemComponent.js

@@ -61,8 +61,2 @@ "use strict";
     };
-    MenuItemComponent.prototype.getTooltipText = function () {
-        return this.tooltip;
-    };
-    MenuItemComponent.prototype.getComponentHolder = function () {
-        return undefined;
-    };
     MenuItemComponent.prototype.isDisabled = function () {
@@ -200,5 +194,11 @@ return !!this.params.disabled;
         else {
-            this.createManagedBean(new core_1.TooltipFeature(this, 'menu'));
+            this.createManagedBean(new core_1.TooltipFeature(this));
         }
     };
+    MenuItemComponent.prototype.getTooltipParams = function () {
+        return {
+            location: 'menu',
+            value: this.tooltip
+        };
+    };
     MenuItemComponent.prototype.addShortcut = function () {
@@ -205,0 +205,0 @@ if (!this.params.shortcut && this.params.isCompact) {

dist/es6/menu/contextMenu.d.ts

@@ -1,2 +0,2 @@
-import { BeanStub, Column, IContextMenuFactory, RowNode } from "@ag-grid-community/core";
+import { BeanStub, Column, IContextMenuFactory, RowNode, GridPanel } from "@ag-grid-community/core";
 export declare class ContextMenuFactory extends BeanStub implements IContextMenuFactory {
@@ -8,2 +8,4 @@ private popupService;
     private activeMenu;
+    private gridPanel;
+    registerGridComp(gridPanel: GridPanel): void;
     hideActiveMenu(): void;
@@ -10,0 +12,0 @@ private getMenuItems;

dist/es6/menu/contextMenu.js

@@ -28,2 +28,5 @@ var __extends = (this && this.__extends) || (function () {
     }
+    ContextMenuFactory.prototype.registerGridComp = function (gridPanel) {
+        this.gridPanel = gridPanel;
+    };
     ContextMenuFactory.prototype.hideActiveMenu = function () {
@@ -107,3 +110,4 @@ this.destroyBean(this.activeMenu);
             positionCallback: positionCallback,
-            anchorToElement: mouseEvent.target
+            // so when browser is scrolled down, the context menu stays on the grid
+            anchorToElement: this.gridPanel.getGui()
         });
@@ -110,0 +114,0 @@ menu.afterGuiAttached({ container: 'contextMenu', hidePopup: hidePopup });

dist/es6/menu/enterpriseMenu.d.ts

@@ -1,2 +0,2 @@
-import { AgEvent, BeanStub, Column, IMenuFactory } from "@ag-grid-community/core";
+import { AgEvent, BeanStub, Column, IMenuFactory, GridPanel } from "@ag-grid-community/core";
 export interface TabSelectedEvent extends AgEvent {
@@ -11,2 +11,4 @@ key: string;
     private activeMenu;
+    private gridPanel;
+    registerGridComp(gridPanel: GridPanel): void;
     hideActiveMenu(): void;
@@ -13,0 +15,0 @@ showMenuAfterMouseEvent(column: Column, mouseEvent: MouseEvent, defaultTab?: string): void;

dist/es6/menu/enterpriseMenu.js

@@ -29,2 +29,5 @@ var __extends = (this && this.__extends) || (function () {
     }
+    EnterpriseMenuFactory.prototype.registerGridComp = function (gridPanel) {
+        this.gridPanel = gridPanel;
+    };
     EnterpriseMenuFactory.prototype.hideActiveMenu = function () {
@@ -97,6 +100,7 @@ this.destroyBean(this.activeMenu);
                 }
-            }
+            },
+            positionCallback: function () { positionCallback(menu); },
+            anchorToElement: this.gridPanel.getGui()
         });
         menu.afterGuiAttached({ hidePopup: hidePopup });
-        positionCallback(menu);
         if (!defaultTab) {
@@ -344,14 +348,16 @@ menu.showTabBasedOnPreviousSelection();
         var filterWrapper = this.filterManager.getOrCreateFilterWrapper(this.column, 'COLUMN_MENU');
-        var afterFilterAttachedCallback = null;
-        // slightly odd block this - this promise will always have been resolved by the time it gets here, so won't be
-        // async (_unless_ in react or similar, but if so why not encountered before now?).
-        // I'd suggest a future improvement would be to remove/replace this promise as this block just wont work if it is
-        // async and is confusing if you don't have this context
-        if (filterWrapper.filterPromise) {
+        var afterFilterAttachedCallback = function (params) {
+            if (!filterWrapper.filterPromise) {
+                return;
+            }
+            // slightly odd block this - this promise will always have been resolved by the time it gets here, so won't be
+            // async (_unless_ in react or similar, but if so why not encountered before now?).
+            // I'd suggest a future improvement would be to remove/replace this promise as this block just wont work if it is
+            // async and is confusing if you don't have this context
             filterWrapper.filterPromise.then(function (filter) {
                 if (filter.afterGuiAttached) {
-                    afterFilterAttachedCallback = filter.afterGuiAttached.bind(filter);
+                    filter.afterGuiAttached(params);
                 }
             });
-        }
+        };
         this.tabItemFilter = {
@@ -358,0 +364,0 @@ title: _.createIconNoSpan('filter', this.gridOptionsWrapper, this.column),

dist/es6/menu/menuItemComponent.d.ts

@@ -1,2 +0,2 @@
-import { AgEvent, Component, MenuItemDef, IComponent } from "@ag-grid-community/core";
+import { AgEvent, Component, MenuItemDef, IComponent, ITooltipParams } from "@ag-grid-community/core";
 export interface MenuItemSelectedEvent extends AgEvent {
@@ -36,4 +36,2 @@ name: string;
     private init;
-    getTooltipText(): string;
-    getComponentHolder(): undefined;
     isDisabled(): boolean;
@@ -48,2 +46,3 @@ openSubMenu(activateFirstItem?: boolean): void;
     private addTooltip;
+    getTooltipParams(): ITooltipParams;
     private addShortcut;
@@ -50,0 +49,0 @@ private addSubMenu;

dist/es6/menu/menuItemComponent.js

@@ -59,8 +59,2 @@ var __extends = (this && this.__extends) || (function () {
     };
-    MenuItemComponent.prototype.getTooltipText = function () {
-        return this.tooltip;
-    };
-    MenuItemComponent.prototype.getComponentHolder = function () {
-        return undefined;
-    };
     MenuItemComponent.prototype.isDisabled = function () {
@@ -198,5 +192,11 @@ return !!this.params.disabled;
         else {
-            this.createManagedBean(new TooltipFeature(this, 'menu'));
+            this.createManagedBean(new TooltipFeature(this));
         }
     };
+    MenuItemComponent.prototype.getTooltipParams = function () {
+        return {
+            location: 'menu',
+            value: this.tooltip
+        };
+    };
     MenuItemComponent.prototype.addShortcut = function () {
@@ -203,0 +203,0 @@ if (!this.params.shortcut && this.params.isCompact) {

package.json

 {
   "name": "@ag-grid-enterprise/menu",
-  "version": "24.0.0",
+  "version": "24.1.0",
   "description": "Advanced Data Grid / Data Table supporting Javascript / React / AngularJS / Web Components",
@@ -45,5 +45,5 @@ "main": "./dist/cjs/main.js",
   "dependencies": {
-    "@ag-grid-community/core": "~24.0.0",
-    "@ag-grid-enterprise/core": "~24.0.0",
-    "@ag-grid-enterprise/column-tool-panel": "~24.0.0"
+    "@ag-grid-community/core": "~24.1.0",
+    "@ag-grid-enterprise/core": "~24.1.0",
+    "@ag-grid-enterprise/column-tool-panel": "~24.1.0"
   },
@@ -50,0 +50,0 @@ "devDependencies": {

No alert changes

Improved metrics

Total package byte prevSize

6693045

increased by0.78%

Lines of code

105948

increased by0.82%

Dependency changes

• + Added@ag-grid-community/core@24.1.0(transitive)

• + Added@ag-grid-enterprise/column-tool-panel@24.1.0(transitive)

• + Added@ag-grid-enterprise/core@24.1.0(transitive)

• + Added@ag-grid-enterprise/row-grouping@24.1.0(transitive)

• + Added@ag-grid-enterprise/side-bar@24.1.0(transitive)

• - Removed@ag-grid-community/core@24.0.0(transitive)

• - Removed@ag-grid-enterprise/column-tool-panel@24.0.0(transitive)

• - Removed@ag-grid-enterprise/core@24.0.0(transitive)

• - Removed@ag-grid-enterprise/row-grouping@24.0.0(transitive)

• - Removed@ag-grid-enterprise/side-bar@24.0.0(transitive)

• Updated@ag-grid-community/core@~24.1.0

• Updated@ag-grid-enterprise/column-tool-panel@~24.1.0

• Updated@ag-grid-enterprise/core@~24.1.0