@akryum/hotel - npm Package Compare versions

Comparing version 0.8.10 to 0.8.11

lib/cli/run.js

@@ -9,3 +9,9 @@ 'use strict';
 const getCmd = require('../get-cmd');
+const nodeCleanup = require('node-cleanup');
 
+var _require = require('../util/terminate');
+
+const terminate = _require.terminate;
+
+
 const signals = ['SIGINT', 'SIGTERM', 'SIGHUP'];
@@ -15,4 +21,4 @@
   // For testing purpose, allows stubbing cp.spawnSync
-  _spawnSync(...args) {
-    return cp.spawnSync(...args);
+  _spawn(...args) {
+    return cp.spawn(...args);
   },
@@ -45,3 +51,3 @@
 
-      var _spawnSync = this._spawnSync(command, args, {
+      const child = this._spawn(command, args, {
         stdio: 'inherit',
@@ -51,8 +57,19 @@ cwd: process.cwd()
 
-      const status = _spawnSync.status,
-            error = _spawnSync.error;
+      nodeCleanup(() => {
+        terminate(child, process.cwd());
+      });
 
+      // For tests
+      if (child.error) throw child.error;
+      if (child.status) {
+        cleanAndExit(child.status);
+        return;
+      }
 
-      if (error) throw error;
-      cleanAndExit(status);
+      child.on('exit', code => {
+        cleanAndExit(code);
+      });
+      child.on('error', error => {
+        throw error;
+      });
     };
@@ -59,0 +76,0 @@

package.json

 {
   "name": "@akryum/hotel",
-  "version": "0.8.10",
+  "version": "0.8.11",
   "description": "Local domains for everyone and more! ",
@@ -53,23 +53,24 @@ "main": "lib",
     "ansi2html": "0.0.1",
-    "chalk": "^2.3.1",
-    "chokidar": "^2.0.2",
+    "chalk": "^2.4.2",
+    "chokidar": "^2.1.8",
     "connect-sse": "^1.2.0",
     "exit-hook": "^1.1.1",
-    "express": "^4.16.2",
+    "express": "^4.17.1",
     "get-port": "^3.2.0",
-    "http-proxy": "^1.17.0",
-    "matcher": "^1.1.0",
+    "http-proxy": "^1.18.0",
+    "matcher": "^1.1.1",
     "mkdirp": "^0.5.1",
+    "node-cleanup": "^2.1.2",
     "once": "^1.3.2",
-    "please-upgrade-node": "^3.0.2",
-    "pug": "^2.0.0-rc.4",
-    "respawn": "^2.4.1",
-    "selfsigned": "^1.10.2",
+    "please-upgrade-node": "^3.2.0",
+    "pug": "^2.0.4",
+    "respawn": "^2.6.0",
+    "selfsigned": "^1.10.7",
     "server-ready": "^0.3.1",
     "sudo-block": "^2.0.0",
     "tildify": "^1.1.2",
-    "tinydate": "^1.0.0",
+    "tinydate": "^1.2.0",
     "unquote": "^1.1.1",
-    "untildify": "^3.0.2",
-    "update-notifier": "^2.3.0",
+    "untildify": "^3.0.3",
+    "update-notifier": "^2.5.0",
     "user-startup": "^0.2.1",
@@ -80,51 +81,51 @@ "vhost": "^3.0.2",
   "devDependencies": {
-    "@types/classnames": "^2.2.3",
+    "@types/classnames": "^2.2.9",
     "@types/escape-html": "0.0.20",
-    "@types/react": "^16.0.38",
-    "@types/react-dom": "^16.0.4",
-    "@types/react-icons": "^2.2.5",
+    "@types/react": "^16.9.9",
+    "@types/react-dom": "^16.9.2",
+    "@types/react-icons": "^2.2.7",
     "ava": "^0.25.0",
     "babel-cli": "^6.26.0",
     "babel-plugin-transform-object-rest-spread": "^6.26.0",
-    "babel-preset-env": "^1.6.1",
-    "classnames": "^2.2.5",
-    "css-loader": "^0.28.10",
+    "babel-preset-env": "^1.7.0",
+    "classnames": "^2.2.6",
+    "css-loader": "^0.28.11",
     "escape-html": "^1.0.3",
-    "eslint": "^4.18.1",
-    "eslint-config-prettier": "^2.9.0",
+    "eslint": "^4.19.1",
+    "eslint-config-prettier": "^2.10.0",
     "eslint-config-standard": "^11.0.0",
-    "eslint-plugin-import": "^2.9.0",
+    "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-node": "^5.2.1",
-    "eslint-plugin-prettier": "^2.6.0",
-    "eslint-plugin-promise": "^3.6.0",
-    "eslint-plugin-standard": "^3.0.1",
+    "eslint-plugin-prettier": "^2.7.0",
+    "eslint-plugin-promise": "^3.8.0",
+    "eslint-plugin-standard": "^3.1.0",
     "html-webpack-plugin": "^2.30.1",
-    "husky": "^0.15.0-rc.8",
+    "husky": "^0.15.0-rc.13",
     "lodash.uniqueid": "^4.0.1",
-    "mobx": "^3.5.1",
-    "mobx-react": "^4.4.2",
-    "nodemon": "^1.15.1",
-    "npm-run-all": "^4.1.2",
-    "pkg-ok": "^2.1.0",
-    "prettier": "^1.10.2",
-    "react": "^16.2.0",
-    "react-dom": "^16.2.0",
+    "mobx": "^3.6.2",
+    "mobx-react": "^4.4.3",
+    "nodemon": "^1.19.4",
+    "npm-run-all": "^4.1.5",
+    "pkg-ok": "^2.3.1",
+    "prettier": "^1.18.2",
+    "react": "^16.10.2",
+    "react-dom": "^16.10.2",
     "react-icons": "^2.2.7",
-    "rimraf": "^2.6.2",
-    "sinon": "^4.4.2",
+    "rimraf": "^2.7.1",
+    "sinon": "^4.5.0",
     "style-loader": "^0.19.1",
     "stylelint": "^8.4.0",
-    "stylelint-config-recess-order": "^1.2.3",
-    "stylelint-config-standard": "^18.1.0",
-    "supertest": "^3.0.0",
+    "stylelint-config-recess-order": "^1.2.4",
+    "stylelint-config-standard": "^18.3.0",
+    "supertest": "^3.4.2",
     "tempy": "^0.2.0",
     "ts-loader": "^3.5.0",
-    "tslint": "^5.9.1",
-    "tslint-config-prettier": "^1.9.0",
+    "tslint": "^5.20.0",
+    "tslint-config-prettier": "^1.18.0",
     "tslint-plugin-prettier": "^1.3.0",
-    "typescript": "^2.7.2",
-    "uglifyjs-webpack-plugin": "^1.2.2",
-    "webpack": "^3.11.0",
-    "webpack-dev-server": "^2.11.1",
-    "webpack-merge": "^4.1.2"
+    "typescript": "^2.9.2",
+    "uglifyjs-webpack-plugin": "^1.3.0",
+    "webpack": "^3.12.0",
+    "webpack-dev-server": "^2.11.5",
+    "webpack-merge": "^4.2.2"
   },
@@ -131,0 +132,0 @@ "ava": {

test/cli/run.js

@@ -18,4 +18,4 @@ const path = require('path')
   sinon.stub(run, '_exit')
-  // Stub _spawnSync to immediately return avoid messing with child_process
-  sinon.stub(run, '_spawnSync').callsFake(() => ({ status }))
+  // Stub _spawn to immediately return avoid messing with child_process
+  sinon.stub(run, '_spawn').callsFake(() => ({ status }))
 
@@ -22,0 +22,0 @@ process.chdir(appDir)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

307646

increased by13.31%

Number of package files

62

increased by5.08%

Lines of code

2769

increased by52.56%

Worsened metrics

Dependency count

27

increased by3.85%

Number of medium supply chain risk alerts

8

increased by14.29%

Dependency changes

• + Addednode-cleanup@^2.1.2

• + Addednode-cleanup@2.1.2(transitive)

• Updatedchalk@^2.4.2

• Updatedchokidar@^2.1.8

• Updatedexpress@^4.17.1

• Updatedhttp-proxy@^1.18.0

• Updatedmatcher@^1.1.1

• Updatedplease-upgrade-node@^3.2.0

• Updatedpug@^2.0.4

• Updatedrespawn@^2.6.0

• Updatedselfsigned@^1.10.7

• Updatedtinydate@^1.2.0

• Updateduntildify@^3.0.3

• Updatedupdate-notifier@^2.5.0