@applitools/visual-grid-client - npm Package Compare versions

Comparing version 15.13.4 to 15.13.5

package.json

 {
   "name": "@applitools/visual-grid-client",
-  "version": "15.13.4",
+  "version": "15.13.5",
   "description": "",
@@ -62,3 +62,3 @@ "keywords": [
   "dependencies": {
-    "@applitools/eyes-sdk-core": "13.8.10",
+    "@applitools/eyes-sdk-core": "13.8.11",
     "@applitools/functional-commons": "1.6.0",
@@ -65,0 +65,0 @@ "@applitools/http-commons": "2.4.7",

src/sdk/checkWindow.js

@@ -110,3 +110,3 @@ 'use strict'
 
-      let error, didError
+      let didError
       const settleError = (throwEx ? Promise.reject : Promise.resolve).bind(Promise)
@@ -119,3 +119,3 @@
         resolveTests[testIndex]()
-
+        let error
         if ((error = testController.getFatalError())) {
@@ -126,2 +126,3 @@ await wrappers[testIndex].ensureAborted()
         if ((error = testController.getError(testIndex))) {
+          await wrappers[testIndex].ensureAborted()
           return (didError = true), error
@@ -179,2 +180,8 @@ }
         const info = await getRenderJobInfo(renderRequest)
+        if (info.error) {
+          testController.setError(index, info.error)
+          testController.setShouldSkipAbort(index, true)
+          if (renderJobs.has(renderRequest)) renderJobs.get(renderRequest)()
+          return
+        }
         wrapper.setRenderJobInfo(info)
@@ -231,3 +238,3 @@ }
         logger.log('got render status error aborting tests')
-        testController.setFatalError(renderStatusErr)
+        testController.setError(index, renderStatusErr)
         if (renderJobs.has(renderRequest)) renderJobs.get(renderRequest)()
@@ -234,0 +241,0 @@ return

src/sdk/makeClose.js

@@ -21,3 +21,3 @@ 'use strict'
   return async (throwEx = true) => {
-    let error, didError
+    let didError
     const settleError = (throwEx ? Promise.reject : Promise.resolve).bind(Promise)
@@ -36,3 +36,3 @@ logger.log('closeEyes() called')
       resolveTests[testIndex]()
-
+      let error
       if ((error = testController.getFatalError())) {
@@ -45,2 +45,5 @@ logger.log('closeEyes() fatal error found')
         logger.log('closeEyes() found test error')
+        if (!testController.getShouldSkipAbort(testIndex)) {
+          await wrappers[testIndex].ensureAborted()
+        }
         return (didError = true), error
@@ -47,0 +50,0 @@ }

src/sdk/makeTestController.js

@@ -5,2 +5,3 @@ 'use strict'
   const errors = [...new Array(numOfTests)]
+  const shouldSkipAbort = [...new Array(numOfTests)]
   const renderIds = [...new Array(numOfTests)].map(() => [])
@@ -20,2 +21,10 @@ let abortedByUser = false
 
+    setShouldSkipAbort: (index, value) => {
+      shouldSkipAbort[index] = value
+    },
+
+    getShouldSkipAbort: index => {
+      return shouldSkipAbort[index]
+    },
+
     setIsAbortedByUser: () => {
@@ -22,0 +31,0 @@ logger.log('user aborted test', testName)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

134357

increased by0.49%

Lines of code

3287

increased by0.58%

Dependency changes

• + Added@applitools/eyes-sdk-core@13.8.11(transitive)

• - Removed@applitools/eyes-sdk-core@13.8.10(transitive)

• Updated@applitools/eyes-sdk-core@13.8.11