@appsignal/preact - npm Package Compare versions

Comparing version 1.0.17 to 1.0.18

CHANGELOG.md

 # AppSignal for preact changelog
 
+## 1.0.18
+
+### Removed
+
+- [a33e5fd](https://github.com/appsignal/appsignal-javascript/commit/a33e5fdbadb3a56f6cece03e2906a900bb2763a3) patch - Remove error type check on ErrorBoundary. This is now done in the `setError` helper instead for all function calls.
+
 ## 1.0.17
@@ -4,0 +10,0 @@

dist/cjs/__tests__/ErrorBoundary.test.js

@@ -42,12 +42,2 @@ "use strict";
     });
-    it("ignores non-Error objects being thrown", function () {
-        expect(function () {
-            preact_2.render(preact_1.h(ErrorBoundary_1.ErrorBoundary, { instance: instance },
-                preact_1.h(BrokenEvent, null)));
-        }).toThrow();
-        expect(mock.setAction).not.toBeCalled();
-        expect(mock.setTags).not.toBeCalled();
-        expect(mock.setError).not.toBeCalled();
-        expect(instance.send).not.toBeCalled();
-    });
     it("modifies the action if provided as a prop", function () {
@@ -54,0 +44,0 @@ preact_2.render(preact_1.h(ErrorBoundary_1.ErrorBoundary, { instance: instance, action: "testaction" },

dist/cjs/ErrorBoundary.js

@@ -29,3 +29,2 @@ "use strict";
 var preact_1 = require("preact");
-var core_1 = require("@appsignal/core");
 var ErrorBoundary = (function (_super) {
@@ -39,4 +38,2 @@ __extends(ErrorBoundary, _super);
     ErrorBoundary.prototype.componentDidCatch = function (error, info) {
-        if (!core_1.isError(error))
-            return;
         var _a = this.props, appsignal = _a.instance, action = _a.action, tags = _a.tags;
@@ -43,0 +40,0 @@ var name = error.name, message = error.message, stack = error.stack;

dist/esm/__tests__/ErrorBoundary.test.js

@@ -40,12 +40,2 @@ import { h } from "preact";
     });
-    it("ignores non-Error objects being thrown", function () {
-        expect(function () {
-            render(h(ErrorBoundary, { instance: instance },
-                h(BrokenEvent, null)));
-        }).toThrow();
-        expect(mock.setAction).not.toBeCalled();
-        expect(mock.setTags).not.toBeCalled();
-        expect(mock.setError).not.toBeCalled();
-        expect(instance.send).not.toBeCalled();
-    });
     it("modifies the action if provided as a prop", function () {
@@ -52,0 +42,0 @@ render(h(ErrorBoundary, { instance: instance, action: "testaction" },

dist/esm/ErrorBoundary.js

@@ -26,3 +26,2 @@ var __extends = (this && this.__extends) || (function () {
 import { Component } from "preact";
-import { isError } from "@appsignal/core";
 var ErrorBoundary = (function (_super) {
@@ -36,4 +35,2 @@ __extends(ErrorBoundary, _super);
     ErrorBoundary.prototype.componentDidCatch = function (error, info) {
-        if (!isError(error))
-            return;
         var _a = this.props, appsignal = _a.instance, action = _a.action, tags = _a.tags;
@@ -40,0 +37,0 @@ var name = error.name, message = error.message, stack = error.stack;

package.json

 {
   "name": "@appsignal/preact",
-  "version": "1.0.17",
+  "version": "1.0.18",
   "main": "dist/cjs/index.js",
@@ -5,0 +5,0 @@ "module": "dist/esm/index.js",

No alert changes

Worsened metrics

Total package byte prevSize

34898

decreased by-7.45%

Lines of code

296

decreased by-8.07%

No dependency changes