@arcteryx/js-cms - npm Package Compare versions

Comparing version 1.27.20 to 2.0.0

CHANGELOG.md

@@ -6,2 +6,18 @@ # Change Log
 
+# [2.0.0](https://bitbucket.org/arcteryx/arcteryx-js-helpers/compare/@arcteryx/js-cms@1.27.20...@arcteryx/js-cms@2.0.0) (2021-04-28)
+
+
+### Features
+
+* HERO-1336 remove unused noCountryFilter param from getCatIntro call ([310e6fd](https://bitbucket.org/arcteryx/arcteryx-js-helpers/commits/310e6fda0e9822bf837992c8b78c71111970ea8d))
+
+
+### BREAKING CHANGES
+
+* noCountryFilter param will not be available
+
+
+
+
+
 ## 1.27.20 (2020-11-13)
@@ -8,0 +24,0 @@

dist/cjs/index.js

@@ -339,6 +339,5 @@ 'use strict';
   @param previewDraft - (Boolean) If set to true will retrieve the draft version from Drupal
-  @param noCountryFilter - (Boolean) If set to true will fetch Category Intro with no country filter from Drupal
 */
 
-const getCategoryIntro = async (cmsUrl, basicAuthToken, market, country, language, path, previewDraft, noCountryFilter) => {
+const getCategoryIntro = async (cmsUrl, basicAuthToken, market, country, language, path, previewDraft) => {
   const fetchOptions = previewDraft ? {
@@ -349,7 +348,5 @@ headers: {
     }
-  } : {}; // Fallback url to get cat intro without country set
+  } : {};
+  const requestUrls = await generateRequestUrls(cmsUrl, market, country, language, path, previewDraft);
 
-  const countryParam = noCountryFilter ? null : country;
-  const requestUrls = await generateRequestUrls(cmsUrl, market, countryParam, language, path, previewDraft);
-
   try {
@@ -356,0 +353,0 @@ const catIntros = await Promise.all(requestUrls.map(url => getDrupalData(url, fetchOptions))).then(json => json);

dist/es/index.js

@@ -335,6 +335,5 @@ /**
   @param previewDraft - (Boolean) If set to true will retrieve the draft version from Drupal
-  @param noCountryFilter - (Boolean) If set to true will fetch Category Intro with no country filter from Drupal
 */
 
-const getCategoryIntro = async (cmsUrl, basicAuthToken, market, country, language, path, previewDraft, noCountryFilter) => {
+const getCategoryIntro = async (cmsUrl, basicAuthToken, market, country, language, path, previewDraft) => {
   const fetchOptions = previewDraft ? {
@@ -345,7 +344,5 @@ headers: {
     }
-  } : {}; // Fallback url to get cat intro without country set
+  } : {};
+  const requestUrls = await generateRequestUrls(cmsUrl, market, country, language, path, previewDraft);
 
-  const countryParam = noCountryFilter ? null : country;
-  const requestUrls = await generateRequestUrls(cmsUrl, market, countryParam, language, path, previewDraft);
-
   try {
@@ -352,0 +349,0 @@ const catIntros = await Promise.all(requestUrls.map(url => getDrupalData(url, fetchOptions))).then(json => json);

dist/umd/index.js

@@ -346,6 +346,5 @@ (function (global, factory) {
     @param previewDraft - (Boolean) If set to true will retrieve the draft version from Drupal
-    @param noCountryFilter - (Boolean) If set to true will fetch Category Intro with no country filter from Drupal
   */
 
-  const getCategoryIntro = async (cmsUrl, basicAuthToken, market, country, language, path, previewDraft, noCountryFilter) => {
+  const getCategoryIntro = async (cmsUrl, basicAuthToken, market, country, language, path, previewDraft) => {
     const fetchOptions = previewDraft ? {
@@ -356,7 +355,5 @@ headers: {
       }
-    } : {}; // Fallback url to get cat intro without country set
+    } : {};
+    const requestUrls = await generateRequestUrls(cmsUrl, market, country, language, path, previewDraft);
 
-    const countryParam = noCountryFilter ? null : country;
-    const requestUrls = await generateRequestUrls(cmsUrl, market, countryParam, language, path, previewDraft);
-
     try {
@@ -363,0 +360,0 @@ const catIntros = await Promise.all(requestUrls.map(url => getDrupalData(url, fetchOptions))).then(json => json);

package.json

 {
   "name": "@arcteryx/js-cms",
-  "version": "1.27.20",
+  "version": "2.0.0",
   "source": "src/index.js",
@@ -32,3 +32,3 @@ "main": "dist/cjs/index.js",
   "license": "ISC",
-  "gitHead": "b4bb7f6ed5c8e0644b26e75c8bc28f241e315746",
+  "gitHead": "fa786f3a7393d5e4814cf840f2da037d85b7c4a0",
   "files": [
@@ -35,0 +35,0 @@ "dist",

src/index.js

@@ -322,3 +322,2 @@ import { toQueryParams } from "@arcteryx/js-url";
   @param previewDraft - (Boolean) If set to true will retrieve the draft version from Drupal
-  @param noCountryFilter - (Boolean) If set to true will fetch Category Intro with no country filter from Drupal
 */
@@ -332,4 +331,3 @@ export const getCategoryIntro = async (
   path,
-  previewDraft,
-  noCountryFilter
+  previewDraft
 ) => {
@@ -345,5 +343,3 @@ const fetchOptions = previewDraft
 
-  // Fallback url to get cat intro without country set
-  const countryParam = noCountryFilter ? null : country;
-  const requestUrls = await generateRequestUrls(cmsUrl, market, countryParam, language, path, previewDraft);
+  const requestUrls = await generateRequestUrls(cmsUrl, market, country, language, path, previewDraft);
 
@@ -350,0 +346,0 @@ try {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

159569

decreased by-1.04%

Lines of code

1311

decreased by-0.76%

No dependency changes