@astrojs/solid-js - npm Package Compare versions

Comparing version 1.2.2 to 1.2.3

CHANGELOG.md

 # @astrojs/solid-js
 
+## 1.2.3
+
+### Patch Changes
+
+- [#5345](https://github.com/withastro/astro/pull/5345) [`3ae2a961b`](https://github.com/withastro/astro/commit/3ae2a961b77da179d24c44734af54424e76a5049) Thanks [@bluwy](https://github.com/bluwy)! - Respect Vite user config for third-party packages config handling
+
 ## 1.2.2
@@ -4,0 +10,0 @@

dist/dependencies.d.ts

@@ -1,1 +0,2 @@
-export declare function getSolidPkgsConfig(root: URL, isBuild: boolean): Promise<import("vitefu").CrawlFrameworkPkgsResult>;
+import type { AstroConfig } from 'astro';
+export declare function getSolidPkgsConfig(isBuild: boolean, astroConfig: AstroConfig): Promise<import("vitefu").CrawlFrameworkPkgsResult>;

dist/dependencies.js

 import { fileURLToPath } from "url";
 import { crawlFrameworkPkgs } from "vitefu";
-async function getSolidPkgsConfig(root, isBuild) {
+async function getSolidPkgsConfig(isBuild, astroConfig) {
   return await crawlFrameworkPkgs({
-    root: fileURLToPath(root),
+    root: fileURLToPath(astroConfig.root),
     isBuild,
+    viteUserConfig: astroConfig.vite,
     isFrameworkPkgByJson(pkgJson) {
@@ -8,0 +9,0 @@ return containsSolidField(pkgJson.exports || {});

dist/index.js

@@ -19,5 +19,5 @@ import { getSolidPkgsConfig } from "./dependencies.js";
 }
-async function getViteConfiguration(isDev, root) {
+async function getViteConfiguration(isDev, astroConfig) {
   const nestedDeps = ["solid-js", "solid-js/web", "solid-js/store", "solid-js/html", "solid-js/h"];
-  const solidPkgsConfig = await getSolidPkgsConfig(root, !isDev);
+  const solidPkgsConfig = await getSolidPkgsConfig(!isDev, astroConfig);
   return {
@@ -47,3 +47,3 @@ esbuild: { include: /\.ts$/ },
         addRenderer(getRenderer());
-        updateConfig({ vite: await getViteConfiguration(command === "dev", config.root) });
+        updateConfig({ vite: await getViteConfiguration(command === "dev", config) });
       }
@@ -50,0 +50,0 @@ }

package.json

 {
   "name": "@astrojs/solid-js",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Use Solid components within Astro",
@@ -31,7 +31,7 @@ "type": "module",
     "babel-preset-solid": "^1.4.2",
-    "vitefu": "^0.1.0"
+    "vitefu": "^0.2.0"
   },
   "devDependencies": {
-    "astro": "1.6.1",
-    "astro-scripts": "0.0.8",
+    "astro": "1.6.8",
+    "astro-scripts": "0.0.9",
     "solid-js": "^1.5.1"
@@ -38,0 +38,0 @@ },

src/dependencies.ts

@@ -0,8 +1,10 @@
+import type { AstroConfig } from 'astro';
 import { fileURLToPath } from 'url';
 import { crawlFrameworkPkgs } from 'vitefu';
 
-export async function getSolidPkgsConfig(root: URL, isBuild: boolean) {
+export async function getSolidPkgsConfig(isBuild: boolean, astroConfig: AstroConfig) {
 	return await crawlFrameworkPkgs({
-		root: fileURLToPath(root),
+		root: fileURLToPath(astroConfig.root),
 		isBuild,
+		viteUserConfig: astroConfig.vite,
 		isFrameworkPkgByJson(pkgJson) {
@@ -9,0 +11,0 @@ return containsSolidField(pkgJson.exports || {});

src/index.ts

@@ -1,2 +0,2 @@
-import type { AstroIntegration, AstroRenderer } from 'astro';
+import type { AstroConfig, AstroIntegration, AstroRenderer } from 'astro';
 import { getSolidPkgsConfig } from './dependencies.js';
@@ -27,7 +27,7 @@
 
-async function getViteConfiguration(isDev: boolean, root: URL) {
+async function getViteConfiguration(isDev: boolean, astroConfig: AstroConfig) {
 	// https://github.com/solidjs/vite-plugin-solid
 	// We inject the dev mode only if the user explicitely wants it or if we are in dev (serve) mode
 	const nestedDeps = ['solid-js', 'solid-js/web', 'solid-js/store', 'solid-js/html', 'solid-js/h'];
-	const solidPkgsConfig = await getSolidPkgsConfig(root, !isDev);
+	const solidPkgsConfig = await getSolidPkgsConfig(!isDev, astroConfig);
 	return {
@@ -62,3 +62,3 @@ /**
 				addRenderer(getRenderer());
-				updateConfig({ vite: await getViteConfiguration(command === 'dev', config.root) });
+				updateConfig({ vite: await getViteConfiguration(command === 'dev', config) });
 			},
@@ -65,0 +65,0 @@ },

No alert changes

Improved metrics

Total package byte prevSize

29039

increased by1.94%

Lines of code

432

increased by0.93%

Dependency changes

• + Addedvitefu@0.2.5(transitive)

• - Removedvitefu@0.1.1(transitive)

• Updatedvitefu@^0.2.0