@atlaskit/layer-manager - npm Package Compare versions

Comparing version 2.5.4 to 2.5.5

CHANGELOG.md

 # @atlaskit/layer-manager
 
+## 2.5.5
+- [patch] AK-4064 ensure unmountComponentAtNode is called for components rendered via ReactDOM.render [e3153c3](https://bitbucket.org/atlassian/atlaskit-mk-2/commits/e3153c3)
+
 ## 2.5.4
@@ -4,0 +7,0 @@

dist/cjs/components/LayerManager.js

@@ -99,3 +99,3 @@ 'use strict';
         _react2.default.createElement(_gateway.GatewayDest, { name: 'modal', component: _reactTransitionGroup.TransitionGroup }),
-        _react2.default.createElement(_gateway.GatewayDest, { name: 'spotlight' }),
+        _react2.default.createElement(_gateway.GatewayDest, { name: 'spotlight', component: _reactTransitionGroup.TransitionGroup }),
         _react2.default.createElement(_gateway.GatewayDest, { name: 'flag' }),
@@ -102,0 +102,0 @@ _react2.default.createElement(_gateway.GatewayDest, { name: 'tooltip', component: _reactTransitionGroup.TransitionGroup })

dist/cjs/components/Portal.js

@@ -117,4 +117,8 @@ 'use strict';
         setTimeout(function () {
-          if (!document.body || !_this3.portalElement) return;
-          document.body.removeChild(_this3.portalElement);
+          var target = document.body;
+          var portal = _this3.portalElement;
+          if (target && portal) {
+            (0, _reactDom.unmountComponentAtNode)(portal);
+            target.removeChild(portal);
+          }
         }, 5000);
@@ -121,0 +125,0 @@ });

dist/esm/components/LayerManager.js

@@ -64,3 +64,3 @@ import _Object$getPrototypeOf from 'babel-runtime/core-js/object/get-prototype-of';
         React.createElement(GatewayDest, { name: 'modal', component: TransitionGroup }),
-        React.createElement(GatewayDest, { name: 'spotlight' }),
+        React.createElement(GatewayDest, { name: 'spotlight', component: TransitionGroup }),
         React.createElement(GatewayDest, { name: 'flag' }),
@@ -67,0 +67,0 @@ React.createElement(GatewayDest, { name: 'tooltip', component: TransitionGroup })

dist/esm/components/Portal.js

@@ -7,3 +7,3 @@ import _Object$getPrototypeOf from 'babel-runtime/core-js/object/get-prototype-of';
 import React, { Children, Component } from 'react';
-import { render } from 'react-dom';
+import { render, unmountComponentAtNode } from 'react-dom';
 import { withTheme, ThemeProvider } from 'styled-components';
@@ -88,4 +88,8 @@ import { TransitionGroup } from 'react-transition-group';
         setTimeout(function () {
-          if (!document.body || !_this3.portalElement) return;
-          document.body.removeChild(_this3.portalElement);
+          var target = document.body;
+          var portal = _this3.portalElement;
+          if (target && portal) {
+            unmountComponentAtNode(portal);
+            target.removeChild(portal);
+          }
         }, 5000);
@@ -92,0 +96,0 @@ });

dist/package.json

 {
 	"name": "@atlaskit/layer-manager",
-	"version": "2.5.3"
+	"version": "2.5.4"
 }

package.json

 {
   "name": "@atlaskit/layer-manager",
-  "version": "2.5.4",
+  "version": "2.5.5",
   "description": "A React Component for managing layers",
@@ -37,2 +37,2 @@ "license": "Apache-2.0",
   ]
-}
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

70389

increased by0.69%

Lines of code

1699

increased by0.47%

No dependency changes