@atlaskit/page - npm Package Compare versions

Comparing version 8.0.2 to 8.0.3

CHANGELOG.md

 # @atlaskit/page
 
+## 8.0.3
+- [patch] update the dependency of react-dom to 16.4.2 due to vulnerability in previous versions read https://reactjs.org/blog/2018/08/01/react-v-16-4-2.html for details [a4bd557](https://bitbucket.org/atlassian/atlaskit-mk-2/commits/a4bd557)
+- [none] Updated dependencies [a4bd557](https://bitbucket.org/atlassian/atlaskit-mk-2/commits/a4bd557)
+  - @atlaskit/navigation@33.1.3
+  - @atlaskit/toggle@5.0.5
+  - @atlaskit/button@9.0.5
+  - @atlaskit/banner@7.0.3
+  - @atlaskit/icon@13.2.4
+
 ## 8.0.2
@@ -4,0 +13,0 @@ - [patch] Updated dependencies [acd86a1](https://bitbucket.org/atlassian/atlaskit-mk-2/commits/acd86a1)

dist/cjs/Page.js

@@ -33,3 +33,3 @@ 'use strict';
     _templateObject2 = (0, _taggedTemplateLiteral3.default)(['\n  display: flex;\n  flex: 1 1 auto;\n'], ['\n  display: flex;\n  flex: 1 1 auto;\n']),
-    _templateObject3 = (0, _taggedTemplateLiteral3.default)(['\n  flex: 1 0 auto;\n  transition: max-height 0.25s ease-in-out;\n  max-height: ', 'px; /* 52 is line height (20) + 4*grid */\n  position: relative;\n  width: 100%;\n  z-index: 3;\n'], ['\n  flex: 1 0 auto;\n  transition: max-height 0.25s ease-in-out;\n  max-height: ', 'px; /* 52 is line height (20) + 4*grid */\n  position: relative;\n  width: 100%;\n  z-index: 3;\n']),
+    _templateObject3 = (0, _taggedTemplateLiteral3.default)(['\n  flex: 1 0 auto;\n  transition: height 0.25s ease-in-out;\n  height: ', 'px;\n  position: relative;\n  width: 100%;\n  z-index: 3;\n'], ['\n  flex: 1 0 auto;\n  transition: height 0.25s ease-in-out;\n  height: ', 'px;\n  position: relative;\n  width: 100%;\n  z-index: 3;\n']),
     _templateObject4 = (0, _taggedTemplateLiteral3.default)(['\n  position: fixed;\n  width: 100%;\n'], ['\n  position: fixed;\n  width: 100%;\n']),
@@ -54,3 +54,3 @@ _templateObject5 = (0, _taggedTemplateLiteral3.default)(['\n  position: relative;\n  z-index: 2;\n'], ['\n  position: relative;\n  z-index: 2;\n']),
 var BannerContainer = _styledComponents2.default.div(_templateObject3, function (props) {
-  return props.isBannerOpen ? 52 : 0;
+  return props.isBannerOpen ? props.bannerHeight : 0;
 });
@@ -77,2 +77,10 @@
     value: function render() {
+      var _props = this.props,
+          isBannerOpen = _props.isBannerOpen,
+          banner = _props.banner,
+          navigation = _props.navigation,
+          children = _props.children,
+          bannerHeight = _props.bannerHeight;
+
+
       return _react2.default.createElement(
@@ -87,4 +95,5 @@ _styledComponents.ThemeProvider,
             {
-              'aria-hidden': this.props.isBannerOpen,
-              isBannerOpen: this.props.isBannerOpen
+              'aria-hidden': isBannerOpen,
+              isBannerOpen: isBannerOpen,
+              bannerHeight: bannerHeight
             },
@@ -94,3 +103,3 @@ _react2.default.createElement(
               null,
-              this.props.banner
+              banner
             )
@@ -104,3 +113,3 @@ ) : null,
               null,
-              this.props.navigation
+              navigation
             ),
@@ -110,3 +119,3 @@ _react2.default.createElement(
               null,
-              this.props.children
+              children
             )
@@ -123,4 +132,5 @@ )
 Page.defaultProps = {
-  isBannerOpen: false
+  isBannerOpen: false,
+  bannerHeight: 52
 };
 exports.default = Page;

dist/esm/Page.js

@@ -10,3 +10,3 @@ import _Object$getPrototypeOf from 'babel-runtime/core-js/object/get-prototype-of';
     _templateObject2 = _taggedTemplateLiteral(['\n  display: flex;\n  flex: 1 1 auto;\n'], ['\n  display: flex;\n  flex: 1 1 auto;\n']),
-    _templateObject3 = _taggedTemplateLiteral(['\n  flex: 1 0 auto;\n  transition: max-height 0.25s ease-in-out;\n  max-height: ', 'px; /* 52 is line height (20) + 4*grid */\n  position: relative;\n  width: 100%;\n  z-index: 3;\n'], ['\n  flex: 1 0 auto;\n  transition: max-height 0.25s ease-in-out;\n  max-height: ', 'px; /* 52 is line height (20) + 4*grid */\n  position: relative;\n  width: 100%;\n  z-index: 3;\n']),
+    _templateObject3 = _taggedTemplateLiteral(['\n  flex: 1 0 auto;\n  transition: height 0.25s ease-in-out;\n  height: ', 'px;\n  position: relative;\n  width: 100%;\n  z-index: 3;\n'], ['\n  flex: 1 0 auto;\n  transition: height 0.25s ease-in-out;\n  height: ', 'px;\n  position: relative;\n  width: 100%;\n  z-index: 3;\n']),
     _templateObject4 = _taggedTemplateLiteral(['\n  position: fixed;\n  width: 100%;\n'], ['\n  position: fixed;\n  width: 100%;\n']),
@@ -24,3 +24,3 @@ _templateObject5 = _taggedTemplateLiteral(['\n  position: relative;\n  z-index: 2;\n'], ['\n  position: relative;\n  z-index: 2;\n']),
 var BannerContainer = styled.div(_templateObject3, function (props) {
-  return props.isBannerOpen ? 52 : 0;
+  return props.isBannerOpen ? props.bannerHeight : 0;
 });
@@ -48,2 +48,10 @@
     value: function render() {
+      var _props = this.props,
+          isBannerOpen = _props.isBannerOpen,
+          banner = _props.banner,
+          navigation = _props.navigation,
+          children = _props.children,
+          bannerHeight = _props.bannerHeight;
+
+
       return React.createElement(
@@ -58,4 +66,5 @@ ThemeProvider,
             {
-              'aria-hidden': this.props.isBannerOpen,
-              isBannerOpen: this.props.isBannerOpen
+              'aria-hidden': isBannerOpen,
+              isBannerOpen: isBannerOpen,
+              bannerHeight: bannerHeight
             },
@@ -65,3 +74,3 @@ React.createElement(
               null,
-              this.props.banner
+              banner
             )
@@ -75,3 +84,3 @@ ) : null,
               null,
-              this.props.navigation
+              navigation
             ),
@@ -81,3 +90,3 @@ React.createElement(
               null,
-              this.props.children
+              children
             )
@@ -95,4 +104,5 @@ )
 Page.defaultProps = {
-  isBannerOpen: false
+  isBannerOpen: false,
+  bannerHeight: 52
 };
 export default Page;

dist/package.json

 {
 	"name": "@atlaskit/page",
-	"version": "8.0.1"
+	"version": "8.0.2"
 }

package.json

 {
   "name": "@atlaskit/page",
-  "version": "8.0.2",
+  "version": "8.0.3",
   "description": "A component for building page layouts. Also includes the Grid and GridColumn components.",
@@ -26,9 +26,11 @@ "license": "Apache-2.0",
   "devDependencies": {
-    "@atlaskit/banner": "^7.0.2",
+    "@atlaskit/banner": "^7.0.3",
     "@atlaskit/build-utils": "^1.11.0",
+    "@atlaskit/button": "^9.0.5",
     "@atlaskit/docs": "^5.0.2",
-    "@atlaskit/navigation": "^33.1.2",
-    "@atlaskit/toggle": "^5.0.4",
+    "@atlaskit/icon": "^13.2.4",
+    "@atlaskit/navigation": "^33.1.3",
+    "@atlaskit/toggle": "^5.0.5",
     "enzyme": "https://registry.npmjs.org/@pgleeson/enzyme/-/enzyme-3.3.7.tgz",
-    "react-dom": "^16.4.0",
+    "react-dom": "^16.4.2",
     "react-lorem-component": "^0.12.2",
@@ -35,0 +37,0 @@ "react-syntax-highlighter": "^6.0.2"

No alert changes

Improved metrics

Total package byte prevSize

57075

increased by8.14%

Lines of code

586

increased by2.81%

Worsened metrics

Dev dependency count

11

increased by22.22%

No dependency changes