@atlaskit/popup
Advanced tools
Comparing version 1.23.2 to 1.24.0
# @atlaskit/popup | ||
## 1.24.0 | ||
### Minor Changes | ||
- [#124840](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/124840) | ||
[`2e4f70b9a71fa`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/2e4f70b9a71fa) - | ||
Fix to set ref for trigger in React 18 Strict mode behind feature flag | ||
## 1.23.2 | ||
@@ -4,0 +12,0 @@ |
@@ -20,2 +20,3 @@ "use strict"; | ||
var _useGetMemoizedMergedTriggerRef = require("./use-get-memoized-merged-trigger-ref"); | ||
var _useGetMemoizedMergedTriggerRefNew = require("./use-get-memoized-merged-trigger-ref-new"); | ||
/* eslint-disable @repo/internal/react/require-jsdoc */ | ||
@@ -74,2 +75,3 @@ /** | ||
var getMergedTriggerRef = (0, _useGetMemoizedMergedTriggerRef.useGetMemoizedMergedTriggerRef)(); | ||
var getMergedTriggerRefNew = (0, _useGetMemoizedMergedTriggerRefNew.useGetMemoizedMergedTriggerRefNew)(); | ||
var generatedId = (0, _reactUid.useUID)(); | ||
@@ -108,3 +110,3 @@ var id = providedId || generatedId; | ||
return trigger({ | ||
ref: getMergedTriggerRef(ref, setTriggerRef, isOpen), | ||
ref: !(0, _platformFeatureFlags.fg)('platform-design-system-dsp-20476-dropdown-menu') ? getMergedTriggerRef(ref, setTriggerRef, isOpen) : getMergedTriggerRefNew(ref, setTriggerRef), | ||
'aria-controls': isOpen ? id : undefined, | ||
@@ -111,0 +113,0 @@ 'aria-expanded': isOpen, |
@@ -19,2 +19,3 @@ /* eslint-disable @repo/internal/react/require-jsdoc */ | ||
import { useGetMemoizedMergedTriggerRef } from './use-get-memoized-merged-trigger-ref'; | ||
import { useGetMemoizedMergedTriggerRefNew } from './use-get-memoized-merged-trigger-ref-new'; | ||
const defaultLayer = layers.layer(); | ||
@@ -53,2 +54,3 @@ const wrapperStyles = xcss({ | ||
const getMergedTriggerRef = useGetMemoizedMergedTriggerRef(); | ||
const getMergedTriggerRefNew = useGetMemoizedMergedTriggerRefNew(); | ||
const generatedId = useUID(); | ||
@@ -88,3 +90,3 @@ const id = providedId || generatedId; | ||
return trigger({ | ||
ref: getMergedTriggerRef(ref, setTriggerRef, isOpen), | ||
ref: !fg('platform-design-system-dsp-20476-dropdown-menu') ? getMergedTriggerRef(ref, setTriggerRef, isOpen) : getMergedTriggerRefNew(ref, setTriggerRef), | ||
'aria-controls': isOpen ? id : undefined, | ||
@@ -91,0 +93,0 @@ 'aria-expanded': isOpen, |
@@ -20,2 +20,3 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray"; | ||
import { useGetMemoizedMergedTriggerRef } from './use-get-memoized-merged-trigger-ref'; | ||
import { useGetMemoizedMergedTriggerRefNew } from './use-get-memoized-merged-trigger-ref-new'; | ||
var defaultLayer = layers.layer(); | ||
@@ -66,2 +67,3 @@ var wrapperStyles = xcss({ | ||
var getMergedTriggerRef = useGetMemoizedMergedTriggerRef(); | ||
var getMergedTriggerRefNew = useGetMemoizedMergedTriggerRefNew(); | ||
var generatedId = useUID(); | ||
@@ -100,3 +102,3 @@ var id = providedId || generatedId; | ||
return trigger({ | ||
ref: getMergedTriggerRef(ref, setTriggerRef, isOpen), | ||
ref: !fg('platform-design-system-dsp-20476-dropdown-menu') ? getMergedTriggerRef(ref, setTriggerRef, isOpen) : getMergedTriggerRefNew(ref, setTriggerRef), | ||
'aria-controls': isOpen ? id : undefined, | ||
@@ -103,0 +105,0 @@ 'aria-expanded': isOpen, |
{ | ||
"name": "@atlaskit/popup", | ||
"version": "1.23.2", | ||
"version": "1.24.0", | ||
"description": "A popup displays brief content in an overlay.", | ||
@@ -32,6 +32,2 @@ "publishConfig": { | ||
"team": "Design System Team", | ||
"productPushConsumption": [ | ||
"jira" | ||
], | ||
"releaseModel": "continuous", | ||
"runReact18": true, | ||
@@ -49,3 +45,3 @@ "website": { | ||
"@atlaskit/portal": "^4.9.0", | ||
"@atlaskit/primitives": "^12.0.0", | ||
"@atlaskit/primitives": "^12.1.0", | ||
"@atlaskit/theme": "^13.0.0", | ||
@@ -118,2 +114,5 @@ "@atlaskit/tokens": "^1.59.0", | ||
"type": "boolean" | ||
}, | ||
"platform-design-system-dsp-20476-dropdown-menu": { | ||
"type": "boolean" | ||
} | ||
@@ -120,0 +119,0 @@ }, |
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
196446
27038
80
4259
138
12
1
51
+ Added@atlaskit/app-provider@1.4.3(transitive)
+ Added@atlaskit/ds-lib@3.3.0(transitive)
+ Added@atlaskit/tokens@2.4.0(transitive)
- Removed@atlaskit/app-provider@1.4.2(transitive)
- Removed@atlaskit/ds-lib@3.2.2(transitive)
- Removed@atlaskit/tokens@2.3.0(transitive)
Updated@atlaskit/primitives@^12.1.0