@aurelia/runtime-html - npm Package Compare versions

Comparing version 2.0.1-dev.202404281254 to 2.0.1-dev.202405010737

package.json

 {
   "name": "@aurelia/runtime-html",
-  "version": "2.0.1-dev.202404281254",
+  "version": "2.0.1-dev.202405010737",
   "main": "dist/cjs/index.cjs",
@@ -57,9 +57,9 @@ "module": "dist/esm/index.mjs",
   "dependencies": {
-    "@aurelia/kernel": "2.0.1-dev.202404281254",
-    "@aurelia/metadata": "2.0.1-dev.202404281254",
-    "@aurelia/platform": "2.0.1-dev.202404281254",
-    "@aurelia/platform-browser": "2.0.1-dev.202404281254",
-    "@aurelia/runtime": "2.0.1-dev.202404281254",
-    "@aurelia/expression-parser": "2.0.1-dev.202404281254",
-    "@aurelia/template-compiler": "2.0.1-dev.202404281254"
+    "@aurelia/kernel": "2.0.1-dev.202405010737",
+    "@aurelia/metadata": "2.0.1-dev.202405010737",
+    "@aurelia/platform": "2.0.1-dev.202405010737",
+    "@aurelia/platform-browser": "2.0.1-dev.202405010737",
+    "@aurelia/runtime": "2.0.1-dev.202405010737",
+    "@aurelia/expression-parser": "2.0.1-dev.202405010737",
+    "@aurelia/template-compiler": "2.0.1-dev.202405010737"
   },
@@ -66,0 +66,0 @@ "devDependencies": {

src/resources/custom-element.ts

@@ -373,13 +373,13 @@ import {
 
-    // todo: warn if alreay has key
-    if (!container.has(key, false)) {
-      container.register(
-        container.has($Type, false) ? null : singletonRegistration($Type, $Type),
-        aliasRegistration($Type, key),
-        ...aliases.map(alias => aliasRegistration($Type, getElementKeyFrom(alias)))
-      );
-    } /* istanbul ignore next */ else if (__DEV__) {
+    /* istanbul ignore next */
+    if (container.has(key, false)) {
       // eslint-disable-next-line no-console
-      console.warn(`[DEV:aurelia] ${createMappedError(ErrorNames.element_existed, this.name)}`);
+      console.warn(createMappedError(ErrorNames.element_existed, this.name));
+      return;
     }
+    container.register(
+      container.has($Type, false) ? null : singletonRegistration($Type, $Type),
+      aliasRegistration($Type, key),
+      ...aliases.map(alias => aliasRegistration($Type, getElementKeyFrom(alias)))
+    );
   }
@@ -386,0 +386,0 @@

src/templating/rendering.ts

@@ -83,18 +83,13 @@ import { IContainer, resolve } from '@aurelia/kernel';
     let compiled = compiledMap.get(definition);
-    if (definition.needsCompile !== false) {
-      if (compiled == null) {
-        compiledMap.set(definition, compiled = CustomElementDefinition.create(compiler.compile(
-          definition,
-          container,
-        )));
-      } else {
-        // todo:
-        // should only register if the compiled def resolution is string
-        // instead of direct resources
-        container.register(...compiled.dependencies);
-      }
-      return compiled;
+    if (compiled == null) {
+      compiledMap.set(definition, compiled = CustomElementDefinition.create(
+        definition.needsCompile
+          ? compiler.compile(
+            definition,
+            container,
+          )
+          : definition
+      ));
     }
-
-    return definition;
+    return compiled;
   }
@@ -101,0 +96,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

4226097

decreased by-0.04%

Lines of code

76497

decreased by-0.05%

Dependency changes

• + Added@aurelia/expression-parser@2.0.1-dev.202405010737(transitive)

• + Added@aurelia/kernel@2.0.1-dev.202405010737(transitive)

• + Added@aurelia/metadata@2.0.1-dev.202405010737(transitive)

• + Added@aurelia/platform@2.0.1-dev.202405010737(transitive)

• + Added@aurelia/platform-browser@2.0.1-dev.202405010737(transitive)

• + Added@aurelia/runtime@2.0.1-dev.202405010737(transitive)

• + Added@aurelia/template-compiler@2.0.1-dev.202405010737(transitive)

• - Removed@aurelia/expression-parser@2.0.1-dev.202404281254(transitive)

• - Removed@aurelia/kernel@2.0.1-dev.202404281254(transitive)

• - Removed@aurelia/metadata@2.0.1-dev.202404281254(transitive)

• - Removed@aurelia/platform@2.0.1-dev.202404281254(transitive)

• - Removed@aurelia/platform-browser@2.0.1-dev.202404281254(transitive)

• - Removed@aurelia/runtime@2.0.1-dev.202404281254(transitive)

• - Removed@aurelia/template-compiler@2.0.1-dev.202404281254(transitive)

• Updated@aurelia/expression-parser@2.0.1-dev.202405010737

• Updated@aurelia/kernel@2.0.1-dev.202405010737

• Updated@aurelia/metadata@2.0.1-dev.202405010737

• Updated@aurelia/platform@2.0.1-dev.202405010737

• Updated@aurelia/platform-browser@2.0.1-dev.202405010737

• Updated@aurelia/runtime@2.0.1-dev.202405010737

• Updated@aurelia/template-compiler@2.0.1-dev.202405010737