@auth0/cordova - npm Package Compare versions

Comparing version 0.1.0 to 0.2.0

CHANGELOG.md

@@ -0,1 +1,9 @@
+# Change Log
+
+## [v0.2.0](https://github.com/auth0/auth0-cordova/tree/v0.2.0) (2017-07-07)
+[Full Changelog](https://github.com/auth0/auth0-cordova/compare/v0.1.0...v0.2.0)
+
+**Changed**
+- Handle InAppBrowser exit event correctly [\#34](https://github.com/auth0/auth0-cordova/pull/34) ([decates](https://github.com/decates))
+
 ## [v0.1.0](https://github.com/auth0/auth0-cordova/tree/v0.1.0) (2017-05-07)
@@ -2,0 +10,0 @@ [Full Changelog](https://github.com/auth0/auth0-cordova/tree/v0.1.0)

package.json

 {
   "name": "@auth0/cordova",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "Auth0 integration for Cordova applications",
@@ -9,8 +9,11 @@ "main": "src/index.js",
     "lint": "eslint ./src",
-    "jsdocs": "LIB_VERSION=$(node -pe \"require('./package.json').version\");jsdoc --configure .jsdoc.json --verbose;rm -Rf docs/;mv out/@auth0/cordova/$LIB_VERSION/ docs"
+    "jsdocs": "LIB_VERSION=$(node -pe \"require('./package.json').version\");jsdoc --configure .jsdoc.json --verbose;rm -Rf docs/;mv out/@auth0/cordova/$LIB_VERSION/ docs",
+    "ci:test": "istanbul cover _mocha --report lcovonly -R test/**/* -- -R mocha-multi --reporter-options spec=-,mocha-junit-reporter=-",
+    "test": "mocha test/**/*.tests.js",
+    "ci:coverage": "codecov"
   },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/auth0/auth0-cordova.git"
+  "engine": {
+    "node": ">=6.9.0"
   },
+  "repository": "git+https://github.com/auth0/auth0-cordova.git",
   "keywords": [
@@ -38,3 +41,4 @@ "auth0",
   "devDependencies": {
-    "webpack": "^2.4.1",
+    "chai": "^3.5.0",
+    "codecov": "^2.1.0",
     "eslint": "3.12.2",
@@ -44,10 +48,11 @@ "eslint-config-auth0-base": "6.0.0",
     "eslint-plugin-import": "1.16.0",
+    "istanbul": "^0.4.5",
     "jsdoc": "^3.4.3",
     "jsdoc-to-markdown": "^2.0.1",
-    "minami": "^1.2.3"
-  },
-  "directories": {
-    "doc": "docs",
-    "example": "example"
+    "minami": "^1.2.3",
+    "mocha": "^3.3.0",
+    "mocha-junit-reporter": "^1.13.0",
+    "mocha-multi": "^0.11.0",
+    "webpack": "^2.4.1"
   }
 }

README.md

@@ -15,3 +15,3 @@ # Auth0 Cordova
 ```bash
-cordova plugin add cordova-plugin-inappbrowser
+cordova plugin add cordova-plugin-safariviewcontroller
 cordova plugin add cordova-plugin-customurlscheme --variable URL_SCHEME={application package name} --variable ANDROID_SCHEME={application package name} --variable ANDROID_HOST={auth0 domain} --variable ANDROID_PATHPREFIX=/cordova/{application package name}/callback
@@ -30,2 +30,3 @@ ```
 ```xml
+<preference name="AndroidLaunchMode" value="singleTask" />
 <plugin name="cordova-plugin-customurlscheme" spec="~4.2.0">
@@ -103,2 +104,2 @@ <variable name="URL_SCHEME" value="com.auth0.cordova.example" />
 
-This project is licensed under the MIT license. See the [LICENSE](LICENSE.txt) file for more info.
+This project is licensed under the MIT license. See the [LICENSE](LICENSE.txt) file for more info.

src/index.js

@@ -11,2 +11,3 @@ var parse = require('url-parse');
 var generateState = crypto.generateState;
+var closingDelayMs = 1000;
 
@@ -97,5 +98,17 @@ session.clean();
 
-      if (result.event === 'closed' && getOS() === 'ios') {
-        session.clean();
-        return callback(new Error('user canceled'));
+      if (result.event === 'closed') {
+        var handleClose = function () {
+          if (session.isClosing) {
+            session.clean();
+            return callback(new Error('user canceled'));
+          }
+        };
+
+        session.closing();
+        if (getOS() === 'ios') {
+          handleClose();
+        } else {
+          setTimeout(handleClose, closingDelayMs);
+          return;
+        }
       }
@@ -102,0 +115,0 @@

src/session.js

@@ -5,4 +5,9 @@ function Session() {}
   Session.current = function () { return false; };
+  Session.isClosing = false;
 };
 
+Session.closing = function () {
+  Session.isClosing = true;
+};
+
 Session.start = function (handler) {
@@ -9,0 +14,0 @@ Session.current(new Error('Only one instance of auth can happen at a time'));

New alerts

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1597540

increased by7.95%

Number of package files

59

increased by11.32%

Lines of code

1228

increased by3.54%

Number of lines in readme file

103

increased by1.98%

Worsened metrics

Dev dependency count

14

increased by75%

Number of low supply chain risk alerts

1

increased byInfinity%

No dependency changes