@azure-tools/rlc-common - npm Package Compare versions

Comparing version 0.13.2 to 0.13.3

.rush/temp/operation/build/state.json

 {
-  "nonCachedDurationMs": 6434.369672000059
+  "nonCachedDurationMs": 6613.154929000011
 }

.rush/temp/package-deps_build.json

@@ -6,6 +6,6 @@ {
     "packages/rlc-common/.prettierrc": "83e03202b2f3ad5b8df166a965fea698eccb0f90",
-    "packages/rlc-common/CHANGELOG.md": "821a55116320a9be240229d749939f4a18da8d08",
+    "packages/rlc-common/CHANGELOG.md": "b5d06202d3818273d8cb145047cd82354daa67dd",
     "packages/rlc-common/CONTRIBUTING.md": "1e6cd52a747c7461956721c6d6b64466608a33ab",
     "packages/rlc-common/README.md": "4089f33033d3351a176a9d9c6dcaff93cbe9514d",
-    "packages/rlc-common/package.json": "3caf48720e04e6038c844ff1ae751810c84e763a",
+    "packages/rlc-common/package.json": "1e416a9e98ea89df01b3367267a4c980fdea699a",
     "packages/rlc-common/publishPackage.js": "3512e26d1199937b1962f3b4189aa9c506d9da1a",
@@ -15,3 +15,3 @@ "packages/rlc-common/src/buildClient.ts": "576075adc1df556d2e9cebbf383c0948a288c0d9",
     "packages/rlc-common/src/buildIndexFile.ts": "8aca048bd46b2376b71f6544b5220be59a28b537",
-    "packages/rlc-common/src/buildIsUnexpectedHelper.ts": "4f5ad8bfb674242067c40f1d1924d111b359b015",
+    "packages/rlc-common/src/buildIsUnexpectedHelper.ts": "e2b617ad98544a7646157e5027e761e07b63d048",
     "packages/rlc-common/src/buildLogger.ts": "ee2ceec802a6cf786ea9167b9a789d20657de800",
@@ -18,0 +18,0 @@ "packages/rlc-common/src/buildMethodShortcuts.ts": "833a2b2965d7b71d5a696b358498a9f9e68d83d1",

CHANGELOG.md

@@ -0,1 +1,5 @@
+## 0.13.3 (2023-06-14)
+
+- [Bugfix] Fix isUnexpected helper function in health insights case. Please refer to pr [#1889](https://github.com/Azure/autorest.typescript/pull/1889).
+
 ## 0.13.2 (2023-06-13)
@@ -2,0 +6,0 @@

dist-esm/buildIsUnexpectedHelper.js

@@ -89,3 +89,2 @@ // Copyright (c) Microsoft Corporation.
     if (allErrorTypes.size) {
-        const hasTemplate = hasParametrizedPath(pathDictionary);
         isErrorHelper.addFunction({
@@ -107,8 +106,6 @@ overloads,
           const method = response.request.method;
-          ${hasTemplate ? "let" : "const"} pathDetails = responseMap[\`\${method} \${url.pathname}\`];
-          if (!pathDetails) {`,
-                hasTemplate
-                    ? "pathDetails = getParametrizedPathSuccess(method, url.pathname);"
-                    : `return true;`,
-                `  }
+          let pathDetails = responseMap[\`\${method} \${url.pathname}\`];
+          if (!pathDetails) {
+            pathDetails = getParametrizedPathSuccess(method, url.pathname);
+          }
           return !pathDetails.includes(response.status);
@@ -118,19 +115,18 @@ `
         });
-        if (hasTemplate) {
-            isErrorHelper.addFunction({
-                isExported: false,
-                name: "getParametrizedPathSuccess",
-                parameters: [
-                    {
-                        name: "method",
-                        type: "string"
-                    },
-                    {
-                        name: "path",
-                        type: "string"
-                    }
-                ],
-                returnType: `string[]`,
-                statements: [
-                    `
+        isErrorHelper.addFunction({
+            isExported: false,
+            name: "getParametrizedPathSuccess",
+            parameters: [
+                {
+                    name: "method",
+                    type: "string"
+                },
+                {
+                    name: "path",
+                    type: "string"
+                }
+            ],
+            returnType: `string[]`,
+            statements: [
+                `
           const pathParts = path.split("/");
@@ -202,20 +198,19 @@
         `
-                ]
-            });
-            isErrorHelper.addFunction({
-                isExported: false,
-                name: "getPathFromMapKey",
-                parameters: [
-                    {
-                        name: "mapKey",
-                        type: "string"
-                    }
-                ],
-                returnType: `string`,
-                statements: [
-                    `const pathStart = mapKey.indexOf("/");
+            ]
+        });
+        isErrorHelper.addFunction({
+            isExported: false,
+            name: "getPathFromMapKey",
+            parameters: [
+                {
+                    name: "mapKey",
+                    type: "string"
+                }
+            ],
+            returnType: `string`,
+            statements: [
+                `const pathStart = mapKey.indexOf("/");
          return mapKey.slice(pathStart);`
-                ]
-            });
-        }
+            ]
+        });
     }
@@ -227,10 +222,2 @@ return {
 }
-function hasParametrizedPath(pathDictionary) {
-    for (const [path] of Object.entries(pathDictionary)) {
-        if (path.includes("/{") && path.includes("}")) {
-            return true;
-        }
-    }
-    return false;
-}
 //# sourceMappingURL=buildIsUnexpectedHelper.js.map

dist-esm/package.json

@@ -1,1 +0,1 @@
-{"name":"@azure-tools/rlc-common","version":"0.13.2","description":"","type":"module","main":"dist/index.js","module":"dist-esm/index.js","exports":{".":{"types":"./types/index.d.ts","require":"./dist/index.js","import":"./dist-esm/index.js"}},"types":"./types/index.d.ts","scripts":{"lint":"eslint src --ext .ts --max-warnings=0","lint:fix":"eslint src --fix --ext .ts","format":"npm run -s prettier -- --write","check-format":"npm run prettier -- --check","prettier":"prettier --config ./.prettierrc src/**/*.ts","build":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json && node publishPackage.js","build:cjs":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig-cjs.json && node publishPackage.js","build:esm":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && node publishPackage.js","test":"echo \"Error: no test specified\" && exit 1"},"keywords":[],"author":"","license":"ISC","dependencies":{"ts-morph":"^15.1.0","lodash":"^4.17.21","handlebars":"^4.7.7"},"devDependencies":{"@types/node":"^18.0.0","eslint":"^8.9.0","prettier":"~2.7.1","typescript":"~5.0.0","rimraf":"^3.0.2","@types/lodash":"^4.14.182","fs-extra":"^10.0.0","@types/fs-extra":"^8.1.0","ts-node":"^10.7.0"},"bugs":{"url":"https://github.com/Azure/autorest.typescript/issues"},"homepage":"https://github.com/Azure/autorest.typescript/tree/main/packages/rlc-common/"}
+{"name":"@azure-tools/rlc-common","version":"0.13.3","description":"","type":"module","main":"dist/index.js","module":"dist-esm/index.js","exports":{".":{"types":"./types/index.d.ts","require":"./dist/index.js","import":"./dist-esm/index.js"}},"types":"./types/index.d.ts","scripts":{"lint":"eslint src --ext .ts --max-warnings=0","lint:fix":"eslint src --fix --ext .ts","format":"npm run -s prettier -- --write","check-format":"npm run prettier -- --check","prettier":"prettier --config ./.prettierrc src/**/*.ts","build":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json && node publishPackage.js","build:cjs":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig-cjs.json && node publishPackage.js","build:esm":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && node publishPackage.js","test":"echo \"Error: no test specified\" && exit 1"},"keywords":[],"author":"","license":"ISC","dependencies":{"ts-morph":"^15.1.0","lodash":"^4.17.21","handlebars":"^4.7.7"},"devDependencies":{"@types/node":"^18.0.0","eslint":"^8.9.0","prettier":"~2.7.1","typescript":"~5.0.0","rimraf":"^3.0.2","@types/lodash":"^4.14.182","fs-extra":"^10.0.0","@types/fs-extra":"^8.1.0","ts-node":"^10.7.0"},"bugs":{"url":"https://github.com/Azure/autorest.typescript/issues"},"homepage":"https://github.com/Azure/autorest.typescript/tree/main/packages/rlc-common/"}

dist/buildIsUnexpectedHelper.js

@@ -89,3 +89,2 @@ "use strict";
     if (allErrorTypes.size) {
-        const hasTemplate = hasParametrizedPath(pathDictionary);
         isErrorHelper.addFunction({
@@ -107,8 +106,6 @@ overloads,
           const method = response.request.method;
-          ${hasTemplate ? "let" : "const"} pathDetails = responseMap[\`\${method} \${url.pathname}\`];
-          if (!pathDetails) {`,
-                hasTemplate
-                    ? "pathDetails = getParametrizedPathSuccess(method, url.pathname);"
-                    : `return true;`,
-                `  }
+          let pathDetails = responseMap[\`\${method} \${url.pathname}\`];
+          if (!pathDetails) {
+            pathDetails = getParametrizedPathSuccess(method, url.pathname);
+          }
           return !pathDetails.includes(response.status);
@@ -118,19 +115,18 @@ `
         });
-        if (hasTemplate) {
-            isErrorHelper.addFunction({
-                isExported: false,
-                name: "getParametrizedPathSuccess",
-                parameters: [
-                    {
-                        name: "method",
-                        type: "string"
-                    },
-                    {
-                        name: "path",
-                        type: "string"
-                    }
-                ],
-                returnType: `string[]`,
-                statements: [
-                    `
+        isErrorHelper.addFunction({
+            isExported: false,
+            name: "getParametrizedPathSuccess",
+            parameters: [
+                {
+                    name: "method",
+                    type: "string"
+                },
+                {
+                    name: "path",
+                    type: "string"
+                }
+            ],
+            returnType: `string[]`,
+            statements: [
+                `
           const pathParts = path.split("/");
@@ -202,20 +198,19 @@
         `
-                ]
-            });
-            isErrorHelper.addFunction({
-                isExported: false,
-                name: "getPathFromMapKey",
-                parameters: [
-                    {
-                        name: "mapKey",
-                        type: "string"
-                    }
-                ],
-                returnType: `string`,
-                statements: [
-                    `const pathStart = mapKey.indexOf("/");
+            ]
+        });
+        isErrorHelper.addFunction({
+            isExported: false,
+            name: "getPathFromMapKey",
+            parameters: [
+                {
+                    name: "mapKey",
+                    type: "string"
+                }
+            ],
+            returnType: `string`,
+            statements: [
+                `const pathStart = mapKey.indexOf("/");
          return mapKey.slice(pathStart);`
-                ]
-            });
-        }
+            ]
+        });
     }
@@ -228,10 +223,2 @@ return {
 exports.buildIsUnexpectedHelper = buildIsUnexpectedHelper;
-function hasParametrizedPath(pathDictionary) {
-    for (const [path] of Object.entries(pathDictionary)) {
-        if (path.includes("/{") && path.includes("}")) {
-            return true;
-        }
-    }
-    return false;
-}
 //# sourceMappingURL=buildIsUnexpectedHelper.js.map

dist/package.json

@@ -1,1 +0,1 @@
-{"name":"@azure-tools/rlc-common","version":"0.13.2","description":"","type":"commonjs","main":"dist/index.js","module":"dist-esm/index.js","exports":{".":{"types":"./types/index.d.ts","require":"./dist/index.js","import":"./dist-esm/index.js"}},"types":"./types/index.d.ts","scripts":{"lint":"eslint src --ext .ts --max-warnings=0","lint:fix":"eslint src --fix --ext .ts","format":"npm run -s prettier -- --write","check-format":"npm run prettier -- --check","prettier":"prettier --config ./.prettierrc src/**/*.ts","build":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json && node publishPackage.js","build:cjs":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig-cjs.json && node publishPackage.js","build:esm":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && node publishPackage.js","test":"echo \"Error: no test specified\" && exit 1"},"keywords":[],"author":"","license":"ISC","dependencies":{"ts-morph":"^15.1.0","lodash":"^4.17.21","handlebars":"^4.7.7"},"devDependencies":{"@types/node":"^18.0.0","eslint":"^8.9.0","prettier":"~2.7.1","typescript":"~5.0.0","rimraf":"^3.0.2","@types/lodash":"^4.14.182","fs-extra":"^10.0.0","@types/fs-extra":"^8.1.0","ts-node":"^10.7.0"},"bugs":{"url":"https://github.com/Azure/autorest.typescript/issues"},"homepage":"https://github.com/Azure/autorest.typescript/tree/main/packages/rlc-common/"}
+{"name":"@azure-tools/rlc-common","version":"0.13.3","description":"","type":"commonjs","main":"dist/index.js","module":"dist-esm/index.js","exports":{".":{"types":"./types/index.d.ts","require":"./dist/index.js","import":"./dist-esm/index.js"}},"types":"./types/index.d.ts","scripts":{"lint":"eslint src --ext .ts --max-warnings=0","lint:fix":"eslint src --fix --ext .ts","format":"npm run -s prettier -- --write","check-format":"npm run prettier -- --check","prettier":"prettier --config ./.prettierrc src/**/*.ts","build":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json && node publishPackage.js","build:cjs":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig-cjs.json && node publishPackage.js","build:esm":"rimraf dist/* dist-esm/* types/* && tsc -p tsconfig.json && node publishPackage.js","test":"echo \"Error: no test specified\" && exit 1"},"keywords":[],"author":"","license":"ISC","dependencies":{"ts-morph":"^15.1.0","lodash":"^4.17.21","handlebars":"^4.7.7"},"devDependencies":{"@types/node":"^18.0.0","eslint":"^8.9.0","prettier":"~2.7.1","typescript":"~5.0.0","rimraf":"^3.0.2","@types/lodash":"^4.14.182","fs-extra":"^10.0.0","@types/fs-extra":"^8.1.0","ts-node":"^10.7.0"},"bugs":{"url":"https://github.com/Azure/autorest.typescript/issues"},"homepage":"https://github.com/Azure/autorest.typescript/tree/main/packages/rlc-common/"}

package.json

 {
   "name": "@azure-tools/rlc-common",
-  "version": "0.13.2",
+  "version": "0.13.3",
   "description": "",
@@ -5,0 +5,0 @@ "type": "module",

src/buildIsUnexpectedHelper.ts

@@ -119,3 +119,2 @@ // Copyright (c) Microsoft Corporation.
   if (allErrorTypes.size) {
-    const hasTemplate = hasParametrizedPath(pathDictionary);
     isErrorHelper.addFunction({
@@ -137,10 +136,6 @@ overloads,
           const method = response.request.method;
-          ${
-            hasTemplate ? "let" : "const"
-          } pathDetails = responseMap[\`\${method} \${url.pathname}\`];
-          if (!pathDetails) {`,
-        hasTemplate
-          ? "pathDetails = getParametrizedPathSuccess(method, url.pathname);"
-          : `return true;`,
-        `  }
+          let pathDetails = responseMap[\`\${method} \${url.pathname}\`];
+          if (!pathDetails) {
+            pathDetails = getParametrizedPathSuccess(method, url.pathname);
+          }
           return !pathDetails.includes(response.status);
@@ -150,19 +145,18 @@ `
     });
-    if (hasTemplate) {
-      isErrorHelper.addFunction({
-        isExported: false,
-        name: "getParametrizedPathSuccess",
-        parameters: [
-          {
-            name: "method",
-            type: "string"
-          },
-          {
-            name: "path",
-            type: "string"
-          }
-        ],
-        returnType: `string[]`,
-        statements: [
-          `
+    isErrorHelper.addFunction({
+      isExported: false,
+      name: "getParametrizedPathSuccess",
+      parameters: [
+        {
+          name: "method",
+          type: "string"
+        },
+        {
+          name: "path",
+          type: "string"
+        }
+      ],
+      returnType: `string[]`,
+      statements: [
+        `
           const pathParts = path.split("/");
@@ -234,21 +228,20 @@
         `
-        ]
-      });
+      ]
+    });
 
-      isErrorHelper.addFunction({
-        isExported: false,
-        name: "getPathFromMapKey",
-        parameters: [
-          {
-            name: "mapKey",
-            type: "string"
-          }
-        ],
-        returnType: `string`,
-        statements: [
-          `const pathStart = mapKey.indexOf("/");
+    isErrorHelper.addFunction({
+      isExported: false,
+      name: "getPathFromMapKey",
+      parameters: [
+        {
+          name: "mapKey",
+          type: "string"
+        }
+      ],
+      returnType: `string`,
+      statements: [
+        `const pathStart = mapKey.indexOf("/");
          return mapKey.slice(pathStart);`
-        ]
-      });
-    }
+      ]
+    });
   }
@@ -261,11 +254,1 @@
 }
-
-function hasParametrizedPath(pathDictionary: Paths): boolean {
-  for (const [path] of Object.entries(pathDictionary)) {
-    if (path.includes("/{") && path.includes("}")) {
-      return true;
-    }
-  }
-
-  return false;
-}

No alert changes

Worsened metrics

Total package byte prevSize

743227

decreased by-0.31%

Lines of code

13021

decreased by-0.31%

No dependency changes