@azure/event-hubs - npm Package Compare versions

Comparing version 1.0.6 to 1.0.7

changelog.md

@@ -0,1 +1,4 @@
+### 2018-10-25 1.0.7
+- Only set `message_id` while sending the message, when provided by caller [PR](https://github.com/Azure/azure-event-hubs-node/pull/169).
+
 ### 2018-10-01 1.0.6
@@ -2,0 +5,0 @@ - export `EventHubConnectionConfig` from the library.

dist/lib/eventData.js

@@ -5,3 +5,2 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const uuid = require("uuid/v4");
 const rhea_promise_1 = require("rhea-promise");
@@ -86,5 +85,2 @@ const amqp_common_1 = require("@azure/amqp-common");
         }
-        if (!msg.message_id) {
-            msg.message_id = uuid();
-        }
         if (data.applicationProperties) {
@@ -91,0 +87,0 @@ msg.application_properties = data.applicationProperties;

dist/lib/eventHubSender.js

@@ -267,5 +267,2 @@ "use strict";
                 }
-                if (!batchMessage.message_id) {
-                    batchMessage.message_id = uuid();
-                }
                 // Finally encode the envelope (batch message).
@@ -318,3 +315,3 @@ const encodedBatchMessage = rhea_promise_1.message.encode(batchMessage);
             if (this._sender.sendable()) {
-                log.sender("[%s] Sender '%s', sending message with id '%s'.", this._context.connectionId, this.name, message.message_id || tag);
+                log.sender("[%s] Sender '%s', sending message with id '%s'.", this._context.connectionId, this.name, message.message_id || tag || '<not specified>');
                 let onRejected;
@@ -321,0 +318,0 @@ let onReleased;

dist/lib/managementClient.js

@@ -140,3 +140,4 @@ "use strict";
                     const sropt = { target: { address: this.address } };
-                    log.mgmt("[%s] Creating sender/receiver links on a session for $management endpoint.", this._context.connectionId);
+                    log.mgmt("[%s] Creating sender/receiver links on a session for $management endpoint with " +
+                        "srOpts: %o, receiverOpts: %O.", this._context.connectionId, sropt, rxopt);
                     this._mgmtReqResLink =
@@ -143,0 +144,0 @@ yield amqp_common_1.RequestResponseLink.create(this._context.connection, sropt, rxopt);

lib/eventData.ts

 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-import * as uuid from "uuid/v4";
 import {
@@ -202,5 +201,2 @@ Message, MessageProperties, MessageHeader, Dictionary, messageHeader, messageProperties,
     }
-    if (!msg.message_id) {
-      msg.message_id = uuid();
-    }
     if (data.applicationProperties) {
@@ -207,0 +203,0 @@ msg.application_properties = data.applicationProperties;

lib/eventHubSender.ts

@@ -313,6 +313,2 @@ // Copyright (c) Microsoft Corporation. All rights reserved.
 
-      if (!batchMessage.message_id) {
-        batchMessage.message_id = uuid();
-      }
-
       // Finally encode the envelope (batch message).
@@ -369,3 +365,3 @@ const encodedBatchMessage = message.encode(batchMessage);
         log.sender("[%s] Sender '%s', sending message with id '%s'.", this._context.connectionId,
-          this.name, message.message_id || tag);
+          this.name, message.message_id || tag || '<not specified>');
         let onRejected: Func<EventContext, void>;
@@ -372,0 +368,0 @@ let onReleased: Func<EventContext, void>;

lib/managementClient.ts

@@ -217,4 +217,4 @@ // Copyright (c) Microsoft Corporation. All rights reserved.
         const sropt: SenderOptions = { target: { address: this.address } };
-        log.mgmt("[%s] Creating sender/receiver links on a session for $management endpoint.",
-          this._context.connectionId);
+        log.mgmt("[%s] Creating sender/receiver links on a session for $management endpoint with " +
+          "srOpts: %o, receiverOpts: %O.", this._context.connectionId, sropt, rxopt);
         this._mgmtReqResLink =
@@ -221,0 +221,0 @@ await RequestResponseLink.create(this._context.connection, sropt, rxopt);

package.json

 {
   "name": "@azure/event-hubs",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Azure Event Hubs SDK for JS.",
@@ -46,3 +46,3 @@ "author": "Microsoft Corporation",
     "unit": "nyc --reporter=lcov --reporter=text-lcov mocha -r ts-node/register -t 50000 ./tests/**/*.spec.ts --exit",
-    "prepare": "npm run build"
+    "prepack": "npm i && npm run build"
   },
@@ -49,0 +49,0 @@ "homepage": "https://github.com/Azure/azure-event-hubs-node/tree/master/client",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

397108

decreased by-0.05%

Lines of code

6824

decreased by-0.19%

No dependency changes