@azure/storage-file-datalake - npm Package Compare versions

Comparing version 12.1.1-alpha.20200911.1 to 12.1.1-alpha.20200917.1

CHANGELOG.md

 # Release History
 
-## 12.1.1 (Unreleased)
+## 12.1.1 (2020-09-17)
 
+- Bug fix - Fixes an issue where`DataLakeFileClient.uploadStream()` will give an "Invalid Verb" error when keep-alive is enabled. Fixed bug [11187](https://github.com/Azure/azure-sdk-for-js/issues/11187).
 
@@ -6,0 +7,0 @@ ## 12.1.0 (2020-09-08)

dist-esm/storage-common/src/BuffersStream.js

@@ -25,5 +25,14 @@ // Copyright (c) Microsoft Corporation. All rights reserved.
         _this.byteLength = byteLength;
-        _this.byteOffset = 0;
+        _this.byteOffsetInCurrentBuffer = 0;
         _this.bufferIndex = 0;
         _this.pushedBytesLength = 0;
+        // check byteLength is no larger than buffers[] total length
+        var buffersLength = 0;
+        for (var _i = 0, _a = _this.buffers; _i < _a.length; _i++) {
+            var buf = _a[_i];
+            buffersLength += buf.byteLength;
+        }
+        if (buffersLength < _this.byteLength) {
+            throw new Error("Data size shouldn't be larger than the total length of buffers.");
+        }
         return _this;
@@ -47,8 +56,12 @@ }
         while (i < size && this.pushedBytesLength < this.byteLength) {
-            var remaining = this.buffers[this.bufferIndex].byteLength - this.byteOffset;
+            // The last buffer may be longer than the data it contains.
+            var remainingDataInAllBuffers = this.byteLength - this.pushedBytesLength;
+            var remainingCapacityInThisBuffer = this.buffers[this.bufferIndex].byteLength - this.byteOffsetInCurrentBuffer;
+            var remaining = Math.min(remainingCapacityInThisBuffer, remainingDataInAllBuffers);
             if (remaining > size - i) {
-                var end = this.byteOffset + size - i;
-                outBuffers.push(this.buffers[this.bufferIndex].slice(this.byteOffset, end));
+                // chunkSize = size - i
+                var end = this.byteOffsetInCurrentBuffer + size - i;
+                outBuffers.push(this.buffers[this.bufferIndex].slice(this.byteOffsetInCurrentBuffer, end));
                 this.pushedBytesLength += size - i;
-                this.byteOffset = end;
+                this.byteOffsetInCurrentBuffer = end;
                 i = size;
@@ -58,5 +71,13 @@ break;
             else {
-                outBuffers.push(this.buffers[this.bufferIndex].slice(this.byteOffset));
-                this.byteOffset = 0;
-                this.bufferIndex++;
+                // chunkSize = remaining
+                var end = this.byteOffsetInCurrentBuffer + remaining;
+                outBuffers.push(this.buffers[this.bufferIndex].slice(this.byteOffsetInCurrentBuffer, end));
+                if (remaining === remainingCapacityInThisBuffer) {
+                    // this.buffers[this.bufferIndex] used up, shift to next one
+                    this.byteOffsetInCurrentBuffer = 0;
+                    this.bufferIndex++;
+                }
+                else {
+                    this.byteOffsetInCurrentBuffer = end;
+                }
                 this.pushedBytesLength += remaining;
@@ -63,0 +84,0 @@ i += remaining;

dist-esm/storage-common/src/PooledBuffer.js

@@ -32,3 +32,3 @@ // Copyright (c) Microsoft Corporation. All rights reserved.
         this.capacity = capacity;
-        this._size = capacity;
+        this._size = 0;
         // allocate
@@ -35,0 +35,0 @@ var bufferNum = Math.ceil(capacity / maxBufferLength);

package.json

 {
   "name": "@azure/storage-file-datalake",
-  "version": "12.1.1-alpha.20200911.1",
+  "version": "12.1.1-alpha.20200917.1",
   "description": "Microsoft Azure Storage SDK for JavaScript - DataLake",
@@ -5,0 +5,0 @@ "sdk-type": "client",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2475708

increased by0.24%

Lines of code

29389

increased by0.14%

No dependency changes