@bbc/http-transport - npm Package Compare versions

Comparing version 3.0.0 to 3.1.0

lib/builder.js

@@ -5,2 +5,3 @@ 'use strict';
 
+const CallbackDecorator = require('./callbacks/decorator');
 const HttpTransportClient = require('./client');
@@ -15,6 +16,7 @@
   /**
-    * Configures HttpTransport client
-    * @param {Transport} transport - Transport instance.
-    */
+   * Configures HttpTransport client
+   * @param {Transport} transport - Transport instance.
+   */
   constructor(transport) {
+    this._callback = false;
     this._transport = transport;
@@ -93,2 +95,15 @@ this._defaults = {
   /**
+   * Callbackify the client
+   *
+   * @return a HttpTransport instance supporting callbacks
+   * @example
+   *
+   * const client = httpTransport.asCallback().createClient();
+   */
+  asCallback() {
+    this._callback = true;
+    return this;
+  }
+
+  /**
    * Instantiates a HttpTransport
@@ -103,3 +118,7 @@ *
   createClient() {
-    return new HttpTransportClient(this._transport, this._defaults);
+    const transportClient = new HttpTransportClient(this._transport, this._defaults);
+    if (this._callback) {
+      return new CallbackDecorator(transportClient);
+    }
+    return transportClient;
   }
@@ -106,0 +125,0 @@ }

lib/client.js

@@ -12,6 +12,6 @@ 'use strict';
   /**
-     * Create a HttpTransport.
-     * @param {Transport} transport - Transport instance.
-     * @param {object} defaults - default configutation
-     */
+   * Create a HttpTransport.
+   * @param {Transport} transport - Transport instance.
+   * @param {object} defaults - default configutation
+   */
   constructor(transport, defaults) {
@@ -18,0 +18,0 @@ this._transport = transport;

package.json

 {
   "name": "@bbc/http-transport",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "description": "A flexible, modular REST client built for ease-of-use and resilience.",
@@ -5,0 +5,0 @@ "main": "index.js",

test/client.js

@@ -14,3 +14,3 @@ 'use strict';
 const packageInfo = require('../package');
-
+const toError = require('./toError');
 const sandbox = sinon.sandbox.create();
@@ -59,15 +59,2 @@
 
-function toError() {
-  return async (ctx, next) => {
-    await next();
-
-    if (ctx.res.statusCode >= 400) {
-      const err = new Error('something bad happend.');
-      err.statusCode = ctx.res.statusCode;
-      err.headers = ctx.res.headers;
-      throw err;
-    }
-  };
-}
-
 describe('HttpTransportClient', () => {
@@ -74,0 +61,0 @@ beforeEach(() => {

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

374970

increased by3.02%

Number of package files

88

increased by3.53%

Lines of code

6769

increased by6.25%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes