@bem-react/di - npm Package Compare versions

Comparing version 2.2.2 to 2.2.3

build/di.development.js

@@ -24,6 +24,4 @@ 'use strict';
 function withRegistry() {
-    var registries = [];
-    for (var _i = 0; _i < arguments.length; _i++) {
-        registries[_i] = arguments[_i];
-    }
+    // Use arguments instead of rest-arguments to get faster and more compact code.
+    var registries = [].slice.call(arguments);
     return function WithRegistry(Component) {
@@ -33,4 +31,6 @@ var RegistryResolver = function (props) {
                 var providedRegistries = __assign({}, contextRegistries);
-                registries.forEach(function (registry) {
+                for (var i = 0; i < registries.length; i++) {
+                    var registry = registries[i];
                     var overrides = contextRegistries[registry.id];
+                    // eslint-disable-next-line no-nested-ternary
                     providedRegistries[registry.id] = registry.overridable
@@ -43,8 +43,11 @@ ? overrides
                             : registry;
-                });
-                return (React.createElement(RegistryProvider, { value: providedRegistries },
-                    React.createElement(Component, __assign({}, props))));
+                }
+                return (React.createElement(RegistryProvider, { value: providedRegistries }, React.createElement(Component, props)));
             }));
         };
-        RegistryResolver.displayName = "RegistryResolver(" + registries.map(function (r) { return r.id; }).join(', ') + ")";
+        {
+            var resolverValue = registries.map(function (registry) { return registry.id; }).join(', ');
+            // TODO: Use setDisplayName util.
+            RegistryResolver.displayName = "RegistryResolver(" + resolverValue + ")";
+        }
         return RegistryResolver;
@@ -113,3 +116,2 @@ };
     Registry.prototype.fill = function (componentsSet) {
-        // tslint:disable-next-line:forin
         for (var key in componentsSet) {
@@ -116,0 +118,0 @@ this.components[key] = componentsSet[key];

build/di.production.min.js

@@ -1,1 +0,1 @@
-"use strict";Object.defineProperty(exports,"__esModule",{value:!0});var React=require("react"),__assign=function(){return(__assign=Object.assign||function(e){for(var t,r=1,n=arguments.length;r<n;r++)for(var o in t=arguments[r])Object.prototype.hasOwnProperty.call(t,o)&&(e[o]=t[o]);return e}).apply(this,arguments)},registryContext=React.createContext({}),RegistryProvider=registryContext.Provider,RegistryConsumer=registryContext.Consumer;function withRegistry(){for(var e=[],t=0;t<arguments.length;t++)e[t]=arguments[t];return function(t){var r=function(r){return React.createElement(RegistryConsumer,null,function(n){var o=__assign({},n);return e.forEach(function(e){var t=n[e.id];o[e.id]=e.overridable?t?e.merge(t):e:e&&t?t.merge(e):e}),React.createElement(RegistryProvider,{value:o},React.createElement(t,__assign({},r)))})};return r.displayName="RegistryResolver("+e.map(function(e){return e.id}).join(", ")+")",r}}var ComponentRegistryConsumer=function(e){return React.createElement(RegistryConsumer,null,function(t){return e.children(t[e.id].snapshot())})},useRegistries=function(){return React.useContext(registryContext)},useComponentRegistry=function(e){return useRegistries()[e].snapshot()},registryHocMark="RegistryHoc";function withBase(e){var t=function(){throw new Error("Not found base component for enhance HOC: "+e.toString())};return t.$symbol=registryHocMark,t.hoc=e,t}function isHoc(e){return e.$symbol===registryHocMark}var Registry=function(){function e(e){var t=e.id,r=e.overridable,n=void 0===r||r;this.components={},this.id=t,this.overridable=n}return e.prototype.set=function(e,t){return this.components[e]=t,this},e.prototype.extends=function(e,t){return this.components[e]=withBase(t),this},e.prototype.fill=function(e){for(var t in e)this.components[t]=e[t];return this},e.prototype.get=function(e){return this.components[e]},e.prototype.snapshot=function(){return this.components},e.prototype.merge=function(t){var r=new e({id:this.id,overridable:this.overridable});if(r.fill(this.components),!t)return r;var n=t.snapshot();for(var o in n)n.hasOwnProperty(o)&&(r.components[o]=this.mergeComponents(r.components[o],n[o]));return r},e.prototype.mergeComponents=function(e,t){return isHoc(t)&&e?isHoc(e)?withBase(function(r){return t.hoc(e.hoc(r))}):t.hoc(e):t},e}();exports.ComponentRegistryConsumer=ComponentRegistryConsumer,exports.Registry=Registry,exports.RegistryConsumer=RegistryConsumer,exports.registryContext=registryContext,exports.useComponentRegistry=useComponentRegistry,exports.useRegistries=useRegistries,exports.withRegistry=withRegistry;
+"use strict";Object.defineProperty(exports,"__esModule",{value:!0});var React=require("react"),__assign=function(){return(__assign=Object.assign||function(e){for(var t,r=1,n=arguments.length;r<n;r++)for(var o in t=arguments[r])Object.prototype.hasOwnProperty.call(t,o)&&(e[o]=t[o]);return e}).apply(this,arguments)},registryContext=React.createContext({}),RegistryProvider=registryContext.Provider,RegistryConsumer=registryContext.Consumer;function withRegistry(){var e=[].slice.call(arguments);return function(t){return function(r){return React.createElement(RegistryConsumer,null,function(n){for(var o=__assign({},n),s=0;s<e.length;s++){var i=e[s],u=n[i.id];o[i.id]=i.overridable?u?i.merge(u):i:i&&u?u.merge(i):i}return React.createElement(RegistryProvider,{value:o},React.createElement(t,r))})}}}var ComponentRegistryConsumer=function(e){return React.createElement(RegistryConsumer,null,function(t){return e.children(t[e.id].snapshot())})},useRegistries=function(){return React.useContext(registryContext)},useComponentRegistry=function(e){return useRegistries()[e].snapshot()},registryHocMark="RegistryHoc";function withBase(e){var t=function(){throw new Error("Not found base component for enhance HOC: "+e.toString())};return t.$symbol=registryHocMark,t.hoc=e,t}function isHoc(e){return e.$symbol===registryHocMark}var Registry=function(){function e(e){var t=e.id,r=e.overridable,n=void 0===r||r;this.components={},this.id=t,this.overridable=n}return e.prototype.set=function(e,t){return this.components[e]=t,this},e.prototype.extends=function(e,t){return this.components[e]=withBase(t),this},e.prototype.fill=function(e){for(var t in e)this.components[t]=e[t];return this},e.prototype.get=function(e){return this.components[e]},e.prototype.snapshot=function(){return this.components},e.prototype.merge=function(t){var r=new e({id:this.id,overridable:this.overridable});if(r.fill(this.components),!t)return r;var n=t.snapshot();for(var o in n)n.hasOwnProperty(o)&&(r.components[o]=this.mergeComponents(r.components[o],n[o]));return r},e.prototype.mergeComponents=function(e,t){return isHoc(t)&&e?isHoc(e)?withBase(function(r){return t.hoc(e.hoc(r))}):t.hoc(e):t},e}();exports.ComponentRegistryConsumer=ComponentRegistryConsumer,exports.Registry=Registry,exports.RegistryConsumer=RegistryConsumer,exports.registryContext=registryContext,exports.useComponentRegistry=useComponentRegistry,exports.useRegistries=useRegistries,exports.withRegistry=withRegistry;

CHANGELOG.md

@@ -6,2 +6,9 @@ # Change Log
 
+## [2.2.3](https://github.com/bem/bem-react/compare/@bem-react/di@2.2.2...@bem-react/di@2.2.3) (2020-03-12)
+
+### Performance Improvements
+
+- **di:** use for of loop instead forEach ([68d239c](https://github.com/bem/bem-react/commit/68d239c3f537a7203a9d8644a81ab4623fedb2eb))
+- **di:** use native createElement instead jsx ([eb3ff64](https://github.com/bem/bem-react/commit/eb3ff6461a1eaa0558df0ab3aebf32a302a35a77))
+
 ## [2.2.2](https://github.com/bem/bem-react/compare/@bem-react/di@2.2.1...@bem-react/di@2.2.2) (2020-03-02)
@@ -8,0 +15,0 @@

di.d.ts

@@ -5,3 +5,3 @@ import React, { ReactNode, FC, ComponentType } from 'react';
 export declare const RegistryConsumer: React.ExoticComponent<React.ConsumerProps<Record<string, Registry>>>;
-export declare function withRegistry(...registries: Registry[]): <P>(Component: React.ComponentType<P>) => React.FunctionComponent<P>;
+export declare function withRegistry(...registries: Registry[]): <P>(Component: ComponentType<P>) => FC<P>;
 export interface IComponentRegistryConsumerProps {
@@ -8,0 +8,0 @@ id: string;

package.json

 {
   "name": "@bem-react/di",
-  "version": "2.2.2",
+  "version": "2.2.3",
   "description": "BEM React Dependency Injection",
@@ -28,5 +28,3 @@ "homepage": "https://github.com/bem/bem-react/tree/master/packages/di",
     "build": "node ../../scripts/rollup/build.js",
-    "lint": "__DEV__=1 tsc -p . --noEmit && tslint -p . -t stylish",
-    "unit": "../../node_modules/.bin/mocha --opts ../../mocha.opts --",
-    "test": "../../node_modules/.bin/nyc npm run unit test/*.test.tsx"
+    "unit": "../../node_modules/.bin/jest --config ../../.config/jest/jest.config.js"
   },
@@ -52,3 +50,3 @@ "peerDependencies": {
   },
-  "gitHead": "66c9e7002906b49f716747c96123dd1bdeddf6ca"
+  "gitHead": "2d0812109bdb4f8d8d4d507e3585e51ddb556ed5"
 }

No alert changes

Improved metrics

Total package byte prevSize

43474

increased by0.76%

Lines of code

268

increased by0.75%

No dependency changes