@bfwk/di-editor - npm Package Compare versions

Comparing version 0.6.24 to 0.6.25

CHANGELOG.md

@@ -6,10 +6,18 @@ # Change Log
 
-## [0.6.24](https://github.com/salesforce/builder-framework/compare/v0.6.23...v0.6.24) (2021-05-28)
+## [0.6.25](https://github.com/salesforce/builder-framework/compare/v0.6.24...v0.6.25) (2021-06-02)
 
-**Note:** Version bump only for package @bfwk/di-editor
 
+### Bug Fixes
 
+* **di-editor:** read provided expression contexts from builder ([#50](https://github.com/salesforce/builder-framework/issues/50)) ([d765183](https://github.com/salesforce/builder-framework/commit/d76518385854194af8addeee37648a7a050a42e2))
 
 
+### Features
 
+* **di-editor:** decouple interaction/service selector from di editor ([#70](https://github.com/salesforce/builder-framework/issues/70)) ([07fbbc1](https://github.com/salesforce/builder-framework/commit/07fbbc1dbdfb7e5080422d2ab090e1e143dfd1d1))
+
+
+
+
+
 ## [0.6.7](https://git.soma.salesforce.com/BuilderFramework/builder-framework/compare/v0.6.6...v0.6.7) (2021-04-05)
@@ -16,0 +24,0 @@

dist/index.js

@@ -201,3 +201,2 @@ import { ObservableCreator, clone, isEqual, WireValueChangeObservers, generateGuid, generateAdapterId, createWireAdapterFactory, configureObservers } from '@bfwk/utils';
                 .sourceEvent;
-            const eventContext = await this.getSourceEventContext(sourceEvent);
             const editorData = this.builderSpecificData
@@ -207,13 +206,16 @@ ? this.builderSpecificData
             editorData.suppressPublish = true;
-            if (eventContext) {
-                const contextMap = this.convertContextsToMap();
-                contextMap.set(eventContext.contextName, eventContext.schema);
-                editorData.contexts = contextMap;
+            const contextMap = this.convertContextsToMap();
+            if (!this.contexts) {
+                const eventContext = await this.getSourceEventContext(sourceEvent);
+                if (eventContext) {
+                    contextMap.set(eventContext.contextName, eventContext.schema);
+                }
             }
+            editorData.contexts = contextMap;
             const serviceParams = {
-                serviceTypeName: 'FlexipageServices',
-                serviceName: 'ComponentService',
-                methodName: 'updateProperties',
+                serviceTypeName: this._diValue.targetService.targetType,
+                serviceName: this._diValue.targetService.targetName,
+                methodName: this._diValue.targetService.targetMethod,
             };
-            const descriptionProvider = this.targetSelectors[0].shapeProviderProvider(targetService.componentName, serviceParams);
+            const descriptionProvider = this.targetSelectors[0].shapeProviderProvider(targetService && targetService.componentName, serviceParams);
             const revisedProvider = await this.transformDescription(descriptionProvider);
@@ -235,2 +237,3 @@ this.propertySheet = this.propertySheetFactory.createMetadataDrivenPropertySheet(revisedProvider, this.convertToPropertyState(targetService, this._diValue.bindings), editorData);
         bindingState.id = targetService.instanceIdentifier;
+        bindings = bindings || [];
         bindings.forEach(binding => {
@@ -265,3 +268,8 @@ bindingState[binding.targetElementName] = {
                 instanceIdentifier: targetService.instanceIdentifier,
-                extendedProperties: { componentName: targetService.componentName },
+                extendedProperties: {
+                    componentName: targetService.componentName,
+                    targetType: targetService.targetType,
+                    targetName: targetService.targetName,
+                    targetMethod: targetService.targetMethod,
+                },
             };
@@ -300,3 +308,6 @@ }
             targetService.extendedProperties &&
-            targetService.extendedProperties.componentName) {
+            targetService.extendedProperties.componentName &&
+            targetService.extendedProperties.targetType &&
+            targetService.extendedProperties.targetName &&
+            targetService.extendedProperties.targetMethod) {
             return {
@@ -306,2 +317,5 @@ kind: targetService.kind,
                 componentName: targetService.extendedProperties.componentName,
+                targetType: targetService.extendedProperties.targetType,
+                targetName: targetService.extendedProperties.targetName,
+                targetMethod: targetService.extendedProperties.targetMethod,
             };
@@ -308,0 +322,0 @@ }

dist/types/di-editor.d.ts

@@ -13,2 +13,5 @@ import { Observable, Guid } from '@bfwk/utils';
     instanceIdentifier: string;
+    targetType: string;
+    targetName: string;
+    targetMethod: string;
 }
@@ -15,0 +18,0 @@ export declare type ComponentInstanceIdentifier = string;

package.json

 {
   "name": "@bfwk/di-editor",
-  "version": "0.6.24",
+  "version": "0.6.25",
   "description": "DI Editor",
@@ -31,10 +31,10 @@ "type": "module",
   "dependencies": {
-    "@bfwk/command": "0.6.24",
-    "@bfwk/data-service": "0.6.24",
-    "@bfwk/document-model": "0.6.24",
-    "@bfwk/error-handler": "0.6.24",
-    "@bfwk/instrumentation": "0.6.24",
-    "@bfwk/property-editor": "0.6.24",
-    "@bfwk/pub-sub": "0.6.24",
-    "@bfwk/utils": "0.6.24",
+    "@bfwk/command": "0.6.25",
+    "@bfwk/data-service": "0.6.25",
+    "@bfwk/document-model": "0.6.25",
+    "@bfwk/error-handler": "0.6.25",
+    "@bfwk/instrumentation": "0.6.25",
+    "@bfwk/property-editor": "0.6.25",
+    "@bfwk/pub-sub": "0.6.25",
+    "@bfwk/utils": "0.6.25",
     "@lcem/declarative-type-validator": "0.6.8"
@@ -41,0 +41,0 @@ },

No alert changes

Improved metrics

Total package byte prevSize

37981

increased by3.61%

Lines of code

641

increased by2.72%

Dependency changes

• + Added@bfwk/command@0.6.25(transitive)

• + Added@bfwk/data-service@0.6.25(transitive)

• + Added@bfwk/document-model@0.6.25(transitive)

• + Added@bfwk/error-handler@0.6.25(transitive)

• + Added@bfwk/expression-completion@0.6.25(transitive)

• + Added@bfwk/instrumentation@0.6.25(transitive)

• + Added@bfwk/property-editor@0.6.25(transitive)

• + Added@bfwk/pub-sub@0.6.25(transitive)

• + Added@bfwk/sf-selector@0.6.25(transitive)

• + Added@bfwk/store@0.6.25(transitive)

• + Added@bfwk/undo-redo@0.6.25(transitive)

• + Added@bfwk/utils@0.6.25(transitive)

• - Removed@bfwk/command@0.6.24(transitive)

• - Removed@bfwk/data-service@0.6.24(transitive)

• - Removed@bfwk/document-model@0.6.24(transitive)

• - Removed@bfwk/error-handler@0.6.24(transitive)

• - Removed@bfwk/expression-completion@0.6.24(transitive)

• - Removed@bfwk/instrumentation@0.6.24(transitive)

• - Removed@bfwk/property-editor@0.6.24(transitive)

• - Removed@bfwk/pub-sub@0.6.24(transitive)

• - Removed@bfwk/sf-selector@0.6.24(transitive)

• - Removed@bfwk/store@0.6.24(transitive)

• - Removed@bfwk/undo-redo@0.6.24(transitive)

• - Removed@bfwk/utils@0.6.24(transitive)

• Updated@bfwk/command@0.6.25

• Updated@bfwk/data-service@0.6.25

• Updated@bfwk/document-model@0.6.25

• Updated@bfwk/error-handler@0.6.25

• Updated@bfwk/instrumentation@0.6.25

• Updated@bfwk/property-editor@0.6.25

• Updated@bfwk/pub-sub@0.6.25

• Updated@bfwk/utils@0.6.25