@bfwk/editor - npm Package Compare versions

Comparing version 0.7.13 to 0.7.14

CHANGELOG.md

@@ -6,3 +6,3 @@ # Change Log
 
-## [0.7.13](https://github.com/salesforce/builder-framework/compare/v0.7.12...v0.7.13) (2021-09-09)
+## [0.7.14](https://github.com/salesforce/builder-framework/compare/v0.7.13...v0.7.14) (2021-09-10)
 
@@ -12,3 +12,3 @@
 
-* show the DI editor properly in the right panel @W-9809812 ([#252](https://github.com/salesforce/builder-framework/issues/252)) ([7b9a252](https://github.com/salesforce/builder-framework/commit/7b9a25235722c5f52b1b2d519c5e3040f7c061b6))
+* enable items in the slot editor to have events & datasources ([#257](https://github.com/salesforce/builder-framework/issues/257)) ([88bc2d5](https://github.com/salesforce/builder-framework/commit/88bc2d56b1b1cbcb76bbb3c9e1c2e3b4ed4ffde5))
 
@@ -15,0 +15,0 @@

dist/index.js

@@ -602,3 +602,2 @@ import { createStore } from '@bfwk/store-redux';
         this.diEditor = undefined;
-        this._dataProvidersAllowed = false;
         this.extendedPropertyState = {
@@ -610,2 +609,5 @@ propertyState: {},
         this.selectObservableCreator = new ObservableCreator();
+        // LEFT to not break Bentobox before corresponding PR goes in
+        // TO BE REMOVED after PR#264 bentobox goes in
+        this._dataProvidersAllowed = false;
         this.documentModel = documentModel;
@@ -688,8 +690,2 @@ this.documentModel.subscribe(this.handleDocumentModelChange.bind(this));
     }
-    // should come from the Description metadata - mechanism TBD
-    // TEMPORARY - don't check in without some other test that won't break existing Builders
-    // default to false, only turn it on by a subclass
-    setDataProvidersAllowed(type) {
-        this._dataProvidersAllowed = false;
-    }
     async getContexts() {
@@ -701,2 +697,29 @@ return {};
     }
+    async getEventSheetForComponent(componentId) {
+        if (componentId) {
+            const eventState = this.getInitialEventState(this.documentModel, componentId);
+            return this.createExtendedEventSheet(this.getNodeIdentifier(this.documentModel, componentId), eventState);
+        }
+        return { events: [] };
+    }
+    getDataProvidersForComponent(componentId) {
+        if (componentId) {
+            const providersState = this.getInitialDPState(this.documentModel, componentId);
+            return clone(providersState, true);
+        }
+        return [];
+    }
+    getTypeForComponent(componentId) {
+        if (componentId) {
+            return this.getNodeIdentifier(this.documentModel, componentId);
+        }
+        return '';
+    }
+    areDataProvidersAllowedForComponent(componentId) {
+        if (componentId) {
+            const type = this.getNodeIdentifier(this.documentModel, componentId);
+            return type ? this.areDataProvidersAllowed(type) : false;
+        }
+        return false;
+    }
     async emitSelectedPropertySheet() {
@@ -711,3 +734,2 @@ const type = this.getNodeIdentifier(this.documentModel, this.selectedId);
         this.eventSheet = await this.createExtendedEventSheet(this.getNodeIdentifier(this.documentModel, this.selectedId), this.extendedPropertyState.eventState);
-        this.setDataProvidersAllowed(type);
         if (propertySheetClass === 'MetadataDrivenPropertySheet') {
@@ -838,4 +860,5 @@ this.selectedPropertySheet = this.createMetadataDrivenPropertySheet(this.toCapturePropertySheetLabel(this, this.getPropertySheetDescriptionProvider(type)), this.extendedPropertyState.propertyState, data);
     }
-    areDataProvidersAllowed() {
-        return this._dataProvidersAllowed;
+    // default - should be overridden by subclasses
+    areDataProvidersAllowed(type) {
+        return false;
     }
@@ -842,0 +865,0 @@ getExtendedPropertyState(docModel, id) {

dist/types/framework-property-sheet-container.d.ts

@@ -35,6 +35,6 @@ import { BasePropertySheetContainer, PropertySheet, PropertySheetDescription, PropertySheetDescriptionProvider, PropertySheetUiDefinition, PropertyState, PropertyValidationService } from '@bfwk/property-editor';
     protected diEditor?: DIEditor;
-    protected _dataProvidersAllowed: boolean;
     protected extendedPropertyState: ExtendedPropertyState;
     private selectObservableCreator;
     private selectObservable;
+    protected _dataProvidersAllowed: boolean;
     protected constructor(publisher: PubSub, errorHandler: ErrorHandler, documentModel: DocumentModel, instrumentationService: InstrumentationService, validationService: PropertyValidationService, customEditorsByPropertyType?: Map<string, string>, builderSpecificData?: any);
@@ -48,5 +48,8 @@ getSelectObservable(): Observable;
     protected buildData(componentId: string): Promise<any>;
-    protected setDataProvidersAllowed(type: string): void;
     protected getContexts(): Promise<Record<string, JsonSchema>>;
     protected createMetadataDrivenPropertySheet(propertySheetDescriptionProvider: PropertySheetDescriptionProvider, initialState: PropertyState, data?: any): PropertySheet;
+    getEventSheetForComponent(componentId?: string): Promise<EventSheet>;
+    getDataProvidersForComponent(componentId?: string): DataProviderNode[];
+    getTypeForComponent(componentId?: string): string;
+    areDataProvidersAllowedForComponent(componentId?: string): boolean;
     protected emitSelectedPropertySheet(): Promise<void>;
@@ -67,3 +70,3 @@ private toCapturePropertySheetLabel;
     issueDPDeleteCommand(dpID: Guid, componentID: Guid): void;
-    areDataProvidersAllowed(): boolean;
+    areDataProvidersAllowed(type: string): boolean;
     protected getExtendedPropertyState(docModel: DocumentModel, id: Guid): ExtendedPropertyState;
@@ -70,0 +73,0 @@ protected getInitialState(docModel: DocumentModel, id: Guid): PropertyState;

package.json

 {
   "name": "@bfwk/editor",
-  "version": "0.7.13",
+  "version": "0.7.14",
   "description": "LBF Editor",
@@ -31,18 +31,18 @@ "type": "module",
   "dependencies": {
-    "@bfwk/canvas": "0.7.13",
-    "@bfwk/command": "0.7.13",
-    "@bfwk/data-service": "0.7.13",
-    "@bfwk/di-editor": "0.7.13",
-    "@bfwk/document-model": "0.7.13",
-    "@bfwk/dp-editor": "0.7.13",
-    "@bfwk/elements-palette": "0.7.13",
-    "@bfwk/error-handler": "0.7.13",
-    "@bfwk/instrumentation": "0.7.13",
-    "@bfwk/property-editor": "0.7.13",
-    "@bfwk/pub-sub": "0.7.13",
-    "@bfwk/sf-selector": "0.7.13",
-    "@bfwk/store": "0.7.13",
-    "@bfwk/store-redux": "0.7.13",
-    "@bfwk/undo-redo": "0.7.13",
-    "@bfwk/utils": "0.7.13",
+    "@bfwk/canvas": "0.7.14",
+    "@bfwk/command": "0.7.14",
+    "@bfwk/data-service": "0.7.14",
+    "@bfwk/di-editor": "0.7.14",
+    "@bfwk/document-model": "0.7.14",
+    "@bfwk/dp-editor": "0.7.14",
+    "@bfwk/elements-palette": "0.7.14",
+    "@bfwk/error-handler": "0.7.14",
+    "@bfwk/instrumentation": "0.7.14",
+    "@bfwk/property-editor": "0.7.14",
+    "@bfwk/pub-sub": "0.7.14",
+    "@bfwk/sf-selector": "0.7.14",
+    "@bfwk/store": "0.7.14",
+    "@bfwk/store-redux": "0.7.14",
+    "@bfwk/undo-redo": "0.7.14",
+    "@bfwk/utils": "0.7.14",
     "@lwc/wire-service": "2.2.9"
@@ -49,0 +49,0 @@ },

No alert changes

Improved metrics

Total package byte prevSize

77935

increased by1.41%

Lines of code

1232

increased by2.16%

Dependency changes

• + Added@bfwk/canvas@0.7.14(transitive)

• + Added@bfwk/command@0.7.14(transitive)

• + Added@bfwk/data-service@0.7.14(transitive)

• + Added@bfwk/di-editor@0.7.14(transitive)

• + Added@bfwk/document-model@0.7.14(transitive)

• + Added@bfwk/dp-editor@0.7.14(transitive)

• + Added@bfwk/elements-palette@0.7.14(transitive)

• + Added@bfwk/error-handler@0.7.14(transitive)

• + Added@bfwk/expression-completion@0.7.14(transitive)

• + Added@bfwk/instrumentation@0.7.14(transitive)

• + Added@bfwk/property-editor@0.7.14(transitive)

• + Added@bfwk/pub-sub@0.7.14(transitive)

• + Added@bfwk/sf-selector@0.7.14(transitive)

• + Added@bfwk/store@0.7.14(transitive)

• + Added@bfwk/store-redux@0.7.14(transitive)

• + Added@bfwk/undo-redo@0.7.14(transitive)

• + Added@bfwk/utils@0.7.14(transitive)

• - Removed@bfwk/canvas@0.7.13(transitive)

• - Removed@bfwk/command@0.7.13(transitive)

• - Removed@bfwk/data-service@0.7.13(transitive)

• - Removed@bfwk/di-editor@0.7.13(transitive)

• - Removed@bfwk/document-model@0.7.13(transitive)

• - Removed@bfwk/dp-editor@0.7.13(transitive)

• - Removed@bfwk/elements-palette@0.7.13(transitive)

• - Removed@bfwk/error-handler@0.7.13(transitive)

• - Removed@bfwk/expression-completion@0.7.13(transitive)

• - Removed@bfwk/instrumentation@0.7.13(transitive)

• - Removed@bfwk/property-editor@0.7.13(transitive)

• - Removed@bfwk/pub-sub@0.7.13(transitive)

• - Removed@bfwk/sf-selector@0.7.13(transitive)

• - Removed@bfwk/store@0.7.13(transitive)

• - Removed@bfwk/store-redux@0.7.13(transitive)

• - Removed@bfwk/undo-redo@0.7.13(transitive)

• - Removed@bfwk/utils@0.7.13(transitive)

• Updated@bfwk/canvas@0.7.14

• Updated@bfwk/command@0.7.14

• Updated@bfwk/data-service@0.7.14

• Updated@bfwk/di-editor@0.7.14

• Updated@bfwk/document-model@0.7.14

• Updated@bfwk/dp-editor@0.7.14

• Updated@bfwk/elements-palette@0.7.14

• Updated@bfwk/error-handler@0.7.14

• Updated@bfwk/instrumentation@0.7.14

• Updated@bfwk/property-editor@0.7.14

• Updated@bfwk/pub-sub@0.7.14

• Updated@bfwk/sf-selector@0.7.14

• Updated@bfwk/store@0.7.14

• Updated@bfwk/store-redux@0.7.14

• Updated@bfwk/undo-redo@0.7.14

• Updated@bfwk/utils@0.7.14