@blocksuite/virgo - npm Package Compare versions

Comparing version 0.4.0-20230216011811-2776d93 to 0.4.0-20230216093909-90a4996

dist/components/base-text.d.ts

 import { LitElement } from 'lit';
 import { z } from 'zod';
 import type { DeltaInsert } from '../types.js';
-export declare const baseTextAttributes: z.ZodOptional<z.ZodObject<{
+export declare const baseTextAttributes: z.ZodObject<{
     bold: z.ZodOptional<z.ZodBoolean>;
@@ -28,3 +28,3 @@ italic: z.ZodOptional<z.ZodBoolean>;
     link?: string | undefined;
-}>>;
+}>;
 export type BaseTextAttributes = z.infer<typeof baseTextAttributes>;
@@ -31,0 +31,0 @@ export declare class BaseText extends LitElement {

dist/components/base-text.js

@@ -13,4 +13,3 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
 import { VirgoUnitText } from './virgo-unit-text.js';
-export const baseTextAttributes = z
-    .object({
+export const baseTextAttributes = z.object({
     bold: z.boolean().optional(),
@@ -23,7 +22,4 @@ italic: z.boolean().optional(),
     link: z.string().optional(),
-})
-    .optional();
+});
 function virgoTextStyles(props) {
-    if (!props)
-        return styleMap({});
     let textDecorations = '';
@@ -66,7 +62,8 @@ if (props.underline) {
         unitText.str = this.delta.insert;
+        const style = this.delta.attributes
+            ? virgoTextStyles(this.delta.attributes)
+            : styleMap({});
         // we need to avoid \n appearing before and after the span element, which will
         // cause the unexpected space
-        return html `<span
-      data-virgo-element="true"
-      style=${virgoTextStyles(this.delta.attributes)}
+        return html `<span data-virgo-element="true" style=${style}
       >${unitText}</span
@@ -73,0 +70,0 @@ >`;

dist/utils/render.js

@@ -6,3 +6,3 @@ import { BaseText, baseTextAttributes } from '../components/base-text.js';
 export function baseRenderElement(delta) {
-    const parseResult = baseTextAttributes.parse(delta.attributes);
+    const parseResult = baseTextAttributes.optional().parse(delta.attributes);
     const baseText = new BaseText();
@@ -9,0 +9,0 @@ baseText.delta = {

dist/virgo.d.ts

@@ -40,3 +40,3 @@ import { Signal } from '@blocksuite/global/utils';
     insertLineBreak(vRange: VRange): void;
-    formatText(vRange: VRange, attributes: NonNullable<TextAttributes>, options?: {
+    formatText(vRange: VRange, attributes: TextAttributes, options?: {
         match?: (delta: DeltaInsert, deltaVRange: VRange) => boolean;
@@ -43,0 +43,0 @@ mode?: 'replace' | 'merge';

package.json

 {
   "name": "@blocksuite/virgo",
-  "version": "0.4.0-20230216011811-2776d93",
+  "version": "0.4.0-20230216093909-90a4996",
   "description": "A micro editor.",
@@ -26,3 +26,3 @@ "main": "dist/index.js",
   "dependencies": {
-    "@blocksuite/global": "0.4.0-20230216011811-2776d93",
+    "@blocksuite/global": "0.4.0-20230216093909-90a4996",
     "zod": "^3.20.6"
@@ -29,0 +29,0 @@ },

src/components/base-text.ts

@@ -10,13 +10,11 @@ import { html, LitElement } from 'lit';
 
-export const baseTextAttributes = z
-  .object({
-    bold: z.boolean().optional(),
-    italic: z.boolean().optional(),
-    underline: z.boolean().optional(),
-    strikethrough: z.boolean().optional(),
-    inlineCode: z.boolean().optional(),
-    color: z.string().optional(),
-    link: z.string().optional(),
-  })
-  .optional();
+export const baseTextAttributes = z.object({
+  bold: z.boolean().optional(),
+  italic: z.boolean().optional(),
+  underline: z.boolean().optional(),
+  strikethrough: z.boolean().optional(),
+  inlineCode: z.boolean().optional(),
+  color: z.string().optional(),
+  link: z.string().optional(),
+});
 
@@ -28,4 +26,2 @@ export type BaseTextAttributes = z.infer<typeof baseTextAttributes>;
 ): ReturnType<typeof styleMap> {
-  if (!props) return styleMap({});
-
   let textDecorations = '';
@@ -72,8 +68,9 @@ if (props.underline) {
     unitText.str = this.delta.insert;
+    const style = this.delta.attributes
+      ? virgoTextStyles(this.delta.attributes)
+      : styleMap({});
 
     // we need to avoid \n appearing before and after the span element, which will
     // cause the unexpected space
-    return html`<span
-      data-virgo-element="true"
-      style=${virgoTextStyles(this.delta.attributes)}
+    return html`<span data-virgo-element="true" style=${style}
       >${unitText}</span
@@ -80,0 +77,0 @@ >`;

src/utils/render.ts

@@ -8,3 +8,3 @@ import { BaseText, baseTextAttributes } from '../components/base-text.js';
 export function baseRenderElement(delta: DeltaInsert): TextElement {
-  const parseResult = baseTextAttributes.parse(delta.attributes);
+  const parseResult = baseTextAttributes.optional().parse(delta.attributes);
 
@@ -11,0 +11,0 @@ const baseText = new BaseText();

src/virgo.ts

@@ -231,3 +231,3 @@ import { assertExists, Signal } from '@blocksuite/global/utils';
     vRange: VRange,
-    attributes: NonNullable<TextAttributes>,
+    attributes: TextAttributes,
     options: {
@@ -234,0 +234,0 @@ match?: (delta: DeltaInsert, deltaVRange: VRange) => boolean;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

237259

increased by0.01%

Worsened metrics

Lines of code

3377

decreased by-0.15%

Dependency changes

• + Added@blocksuite/global@0.4.0-20230216093909-90a4996(transitive)

• - Removed@blocksuite/global@0.4.0-20230216011811-2776d93(transitive)

• Updated@blocksuite/global@0.4.0-20230216093909-90a4996