@brightspace-hmc/siren-sdk - npm Package Compare versions

Comparing version 2.137.0 to 2.137.1

package.json

 {
   "name": "@brightspace-hmc/siren-sdk",
-  "version": "2.137.0",
+  "version": "2.137.1",
   "type": "module",
@@ -5,0 +5,0 @@ "description": "",

src/es6/Entity.js

@@ -88,3 +88,3 @@ import { dispose, entityFactory, updateEntity } from './EntityFactory.js';
 					reject = null;
-				} else {
+				} else if (entity) {
 					Promise.all(entity._subEntitiesLoadStatus).then(() => {
@@ -95,2 +95,6 @@ resolve && resolve();
 					});
+				} else {
+					resolve && resolve();
+					resolve = null;
+					reject = null;
 				}
@@ -97,0 +101,0 @@ });

src/es6/EntityFactory.js

@@ -69,2 +69,15 @@ import 'd2l-polymer-siren-behaviors/store/entity-store.js';
 	const onChangeWrapped = (entity, error) => {
+
+		if (!entity && error) {
+			// Prevent errors from being thrown in the Firefox & Safari console when the user navigates away while fetches are in progress
+			// https://desire2learn.atlassian.net/browse/GAUD-158
+			if (
+				(error['name'] === 'TypeError' && (error['message'] === 'NetworkError when attempting to fetch resource.' || error['message'] === 'Load failed')) ||
+				(error['name'] === 'AbortError' && error['message'] === 'The operation was aborted')
+			) {
+				console.warn(`${error.toString()} (Possibly due to navigation while fetching)`);
+				return;
+			}
+		}
+
 		if (entity) {
@@ -71,0 +84,0 @@ onChange(new entityType(entity, token, entityListener));

No alert changes

Improved metrics

Total package byte prevSize

408989

increased by0.16%

Lines of code

11315

increased by0.13%

No dependency changes