@cartridge/controller - npm Package Compare versions

Comparing version 0.2.1 to 0.2.3

lib/device.js

@@ -18,3 +18,2 @@ "use strict";
 const signer_1 = require("./signer");
-const constants_1 = require("starknet/dist/constants");
 class DeviceAccount extends starknet_1.Account {
@@ -83,17 +82,2 @@ constructor(address, keychain, options) {
             }
-            if (!transactionsDetail.nonce) {
-                transactionsDetail.nonce = 0; //await this.getNonce();
-            }
-            if (!transactionsDetail.version) {
-                transactionsDetail.version = 1;
-            }
-            if (!transactionsDetail.maxFee) {
-                try {
-                    transactionsDetail.maxFee = "100"; // (await this.estimateFee(calls, { nonce: transactionsDetail.nonce })).suggestedMaxFee
-                }
-                catch (e) {
-                    console.error(e);
-                    throw e;
-                }
-            }
             try {
@@ -108,10 +92,3 @@ return yield this.keychain.execute(calls, abis, transactionsDetail);
             }
-            window.open(`${this.url}/execute?${query_string_1.default.stringify({
-                origin: window.origin,
-                calls: JSON.stringify(calls),
-                nonce: transactionsDetail.nonce,
-                version: transactionsDetail.version,
-                maxFee: transactionsDetail.maxFee,
-                chainId: transactionsDetail.chainId ? transactionsDetail.chainId : constants_1.StarknetChainId.TESTNET,
-            })}`, "_blank", "height=650,width=400");
+            window.open(`${this.url}/execute?${query_string_1.default.stringify(Object.assign(Object.assign({}, transactionsDetail), { origin: window.origin, calls: JSON.stringify(calls) }))}`, "_blank", "height=650,width=450");
             return this.keychain.execute(calls, abis, transactionsDetail, true);
@@ -132,3 +109,3 @@ });
                 typedData: JSON.stringify(typedData),
-            })}`, "_blank", "height=650,width=400");
+            })}`, "_blank", "height=650,width=450");
             return this.keychain.signMessage(typedData, this.address);
@@ -135,0 +112,0 @@ });

lib/index.d.ts

@@ -12,3 +12,3 @@ /// <reference types="node" />
     private url;
-    account: AccountInterface | undefined;
+    account?: AccountInterface;
     constructor(policies?: Policy[], options?: {
@@ -20,3 +20,3 @@ url?: string;
     probe(): Promise<boolean | null>;
-    register(username: string, credential: {
+    register(username: string, credentialId: string, credential: {
         x: string;
@@ -33,6 +33,5 @@ y: string;
         assertion: import("./types").Assertion;
-        transactionHash: string;
     } | null>;
-    provision(address: string): Promise<string | null>;
-    connect(): Promise<AccountInterface | null>;
+    provision(address: string, credentialId: string): Promise<string | null>;
+    connect(): Promise<AccountInterface | undefined>;
     disconnect(): Promise<void | null>;
@@ -39,0 +38,0 @@ revoke(origin: string, policy: Policy[]): Promise<void> | null;

lib/index.js

@@ -100,3 +100,3 @@ "use strict";
     // Register a new device key.
-    register(username, credential) {
+    register(username, credentialId, credential) {
         return __awaiter(this, void 0, void 0, function* () {
@@ -107,3 +107,3 @@ if (!this.keychain) {
             }
-            return yield this.keychain.register(username, credential);
+            return yield this.keychain.register(username, credentialId, credential);
         });
@@ -120,3 +120,3 @@ }
     }
-    provision(address) {
+    provision(address, credentialId) {
         return __awaiter(this, void 0, void 0, function* () {
@@ -127,3 +127,3 @@ if (!this.keychain) {
             }
-            return this.keychain.provision(address);
+            return this.keychain.provision(address, credentialId);
         });
@@ -138,3 +138,3 @@ }
                 console.error("not ready for connect");
-                return null;
+                return;
             }
@@ -141,0 +141,0 @@ if (!!document.hasStorageAccess) {

lib/inject.d.ts

@@ -57,3 +57,3 @@ import { AccountInterface, ProviderInterface } from "starknet";
     isConnected: boolean;
-    account?: AccountInterface;
+    account?: AccountInterface | undefined;
     selectedAddress?: string;
@@ -60,0 +60,0 @@ subscriptions: WalletEvents[];

lib/inject.js

@@ -23,3 +23,3 @@ "use strict";
         this.version = "0.0.1";
-        this.icon = "data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iNTIiIGhlaWdodD0iNDQiIHZpZXdCb3g9IjAgMCA1MiA0NCIgZmlsbD0ibm9uZSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KPHBhdGggZD0iTTE4LjE2MzIgMTguNTcxMUgzMy42NzM0VjE0LjY1MzFIMTguMTY3MUMxOC4xNjcxIDE1LjA1MzQgMTguMTYzMiAxOC42MDggMTguMTYzMiAxOC41NzExWiIgZmlsbD0iIzBGMTQxMCIvPgo8cGF0aCBkPSJNNDQuNDIwMyAxMC41TDM0Ljk0MjkgNi41QzM0LjMyIDYuMTk1NzQgMzMuNjQwNCA2LjAyNTQzIDMyLjk0OCA2SDE5LjA1MTlDMTguMzU5IDYuMDI1NDggMTcuNjc5IDYuMTk1NzkgMTcuMDU1NiA2LjVMNy41Nzk1MyAxMC41QzcuMTIxMDggMTAuNzMzOCA2LjczNzUzIDExLjA5MjMgNi40NzI3MSAxMS41MzQ0QzYuMjA3OSAxMS45NzY1IDYuMDcyNSAxMi40ODQzIDYuMDgyMDEgMTIuOTk5OVYyOS4wMDI0QzYuMDgyMDEgMjkuNTAyNCA2LjA4MjAxIDMwLjAwMjQgNi41ODA3NSAzMC41MDI0TDkuNTc0NDkgMzMuNTAyM0MxMC4wNzMyIDM0LjAwMjMgMTAuNDQ3NiAzNC4wMDIzIDExLjA3MDcgMzQuMDAyM0gxNy45MjYxQzE3LjkyNjEgMzQuNDMyMiAxNy45MjYxIDM4LjAzODYgMTcuOTI2MSAzNy45OTk3SDM0LjEzMlYzMy45OTcxSDE3LjkzOTFWMzAuMDAyNEgxMC41NzJDMTAuMDczMiAzMC4wMDI0IDEwLjA3MzIgMjkuNTAyNCAxMC4wNzMyIDI5LjUwMjRWMTAuNUMxMC4wNzMyIDEwLjUgMTAuMDczMiA5Ljk5OTk2IDEwLjU3MiA5Ljk5OTk2SDQxLjQyOTJDNDEuOTI3OSA5Ljk5OTk2IDQxLjkyNzkgMTAuNSA0MS45Mjc5IDEwLjVWMjkuNTAyNEM0MS45Mjc5IDI5LjUwMjQgNDEuOTI3OSAzMC4wMDI0IDQxLjQyOTIgMzAuMDAyNEgzNC4xMzU5VjM0LjAwMjNINDAuOTMwNEM0MS41NTM1IDM0LjAwMjMgNDEuOTI3OSAzNC4wMDIzIDQyLjQyNjYgMzMuNTAyM0w0NS40MTkxIDMwLjUwMjRDNDUuOTE3OCAzMC4wMDI0IDQ1LjkxNzggMjkuNTAyNCA0NS45MTc4IDI5LjAwMjRWMTIuOTk5OUM0NS45MjcyIDEyLjQ4NDQgNDUuNzkxNyAxMS45NzY2IDQ1LjUyNjkgMTEuNTM0NUM0NS4yNjIxIDExLjA5MjQgNDQuODc4NyAxMC43MzM5IDQ0LjQyMDMgMTAuNVoiIGZpbGw9IiMwRjE0MTAiLz4KPC9zdmc+Cg==";
+        this.icon = "data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iNjkiIGhlaWdodD0iNTciIHZpZXdCb3g9IjAgMCA2OSA1NyIgZmlsbD0ibm9uZSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KPHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBjbGlwLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik0yMy41NTEzIDAuMDM5MDYyNUg0NC42Mjc4TDQ0LjcwMTIgMC4wNDE3NTc4QzQ2LjI2MjQgMC4wOTkwOTkyIDQ3Ljc5NDggMC40NzQ3OTUgNDkuMjA0OSAxLjE0NTA5TDYzLjUyMjcgNy4xODc5NUw2My42NTIyIDcuMjU0MDRDNjUuMDExOCA3Ljk0ODEyIDY2LjE0NzggOS4wMTA3NyA2Ni45MzE2IDEwLjMxOTNDNjcuNzA4MSAxMS42MTU3IDY4LjEwODUgMTMuMTAyMSA2OC4wODg5IDE0LjYxMjFWMzguNjg0QzY4LjA4ODkgMzguNzEgNjguMDg5IDM4LjczNzYgNjguMDg5MSAzOC43NjY2QzY4LjA5MTQgMzkuNjQwOSA2OC4wOTc0IDQxLjgzNTYgNjYuMTY5NyA0My43NjgxTDYxLjY2MjYgNDguMjg2NUM2MC44OTEzIDQ5LjA1OTggNTkuOTY3IDQ5LjY3NDkgNTguODA3IDQ5Ljk4NDlDNTcuOTIxNyA1MC4yMjE1IDU3LjA1MzUgNTAuMjE3IDU2LjY2MyA1MC4yMTVDNTYuNjMxMSA1MC4yMTQ4IDU2LjYwMjQgNTAuMjE0NyA1Ni41NzcxIDUwLjIxNDdMNTAuMzM4NSA1MC4yMDk5TDUwLjMzNjIgNTYuMjM1M0gxNy45MjkzVjUwLjIxNDdIMTEuNjA0QzExLjU3ODggNTAuMjE0NyAxMS41NTAxIDUwLjIxNDggMTEuNTE4MiA1MC4yMTVDMTEuMTI3NiA1MC4yMTcgMTAuMjU5NSA1MC4yMjE1IDkuMzc0MTYgNDkuOTg0OUM4LjIxNDUgNDkuNjc0OSA3LjI5MDQgNDkuMDYwMiA2LjUxOTEyIDQ4LjI4NzFMMi4wMTAxMSA0My43Njg3QzAuMDgyNDUwMyA0MS44MzYyIDAuMDg3Nzg0NCAzOS42NDA5IDAuMDkwMTUyNCAzOC43NjY2QzAuMDkwMjMwOSAzOC43Mzc2IDAuMDkwMzA1NSAzOC43MSAwLjA5MDMwNTUgMzguNjg0VjE0LjYxMjdDMC4wNzA0MyAxMy4xMDI1IDAuNDcwNjMgMTEuNjE1NyAxLjI0NzI5IDEwLjMxOTJDMi4wMzEzOSA5LjAxMDE4IDMuMTY3OTIgNy45NDczOCA0LjUyODExIDcuMjUzNUw0LjY1Njk3IDcuMTg3NzZMMTguOTcyOCAxLjE0NDg5QzIwLjM4MzUgMC40NzQ4MDggMjEuOTE2MiAwLjA5OTE5NTUgMjMuNDc3OCAwLjA0MTc2NUwyMy41NTEzIDAuMDM5MDYyNVoiIGZpbGw9IiMwRjE0MTAiLz4KPHBhdGggZD0iTTIyLjI4NjMgMjIuOTcyOUg0NS42NDdWMTcuMDcxN0gyMi4yOTIyQzIyLjI5MjIgMTcuNjc0NiAyMi4yODYzIDIyLjk3MjkgMjIuMjg2MyAyMi45NzI5WiIgZmlsbD0iI0ZCQ0I0QSIvPgo8cGF0aCBkPSJNNjEuODMzNCAxMC44MTY3TDQ3LjU1OTEgNC43OTIxM0M0Ni42MjA4IDQuMzMzODggNDUuNTk3NCA0LjA3NzM3IDQ0LjU1NDQgNC4wMzkwNkgyMy42MjQ4QzIyLjU4MTIgNC4wNzc0NCAyMS41NTcxIDQuMzMzOTQgMjAuNjE4MiA0Ljc5MjEzTDYuMzQ1NzkgMTAuODE2N0M1LjY1NTMgMTEuMTY4OSA1LjA3NzYxIDExLjcwODggNC42Nzg3NiAxMi4zNzQ3QzQuMjc5OSAxMy4wNDA1IDQuMDc1OTggMTMuODA1NCA0LjA5MDMxIDE0LjU4MlYzOC42ODRDNC4wOTAzMSAzOS40MzcxIDQuMDkwMyA0MC4xOTAxIDQuODQxNDggNDAuOTQzMkw5LjM1MDQ5IDQ1LjQ2MTZDMTAuMTAxNyA0Ni4yMTQ3IDEwLjY2NTUgNDYuMjE0NyAxMS42MDQgNDYuMjE0N0gyMS45MjkzQzIxLjkyOTMgNDYuODYyMSAyMS45MjkzIDUyLjIzNTMgMjEuOTI5MyA1Mi4yMzUzSDQ2LjMzNzdWNDYuMjA2OUgyMS45NDg4VjQwLjE5MDFIMTAuODUyOEMxMC4xMDE3IDQwLjE5MDEgMTAuMTAxNyAzOS40MzcxIDEwLjEwMTcgMzkuNDM3MVYxMC44MTY3QzEwLjEwMTcgMTAuODE2NyAxMC4xMDE3IDEwLjA2MzYgMTAuODUyOCAxMC4wNjM2SDU3LjMyODNDNTguMDc5NSAxMC4wNjM2IDU4LjA3OTUgMTAuODE2NyA1OC4wNzk1IDEwLjgxNjdWMzkuNDM3MUM1OC4wNzk1IDM5LjQzNzEgNTguMDc5NSA0MC4xOTAxIDU3LjMyODMgNDAuMTkwMUg0Ni4zNDM2TDQ2LjMzNzcgNDYuMjA2OUw1Ni41NzcxIDQ2LjIxNDdDNTcuNTE1NiA0Ni4yMTQ3IDU4LjA3OTUgNDYuMjE0NyA1OC44MzA3IDQ1LjQ2MTZMNjMuMzM3NyA0MC45NDMyQzY0LjA4ODkgNDAuMTkwMSA2NC4wODg5IDM5LjQzNzEgNjQuMDg4OSAzOC42ODRWMTQuNTgyQzY0LjEwMyAxMy44MDU1IDYzLjg5OSAxMy4wNDA2IDYzLjUwMDEgMTIuMzc0OEM2My4xMDEzIDExLjcwOSA2Mi41MjM4IDExLjE2OTEgNjEuODMzNCAxMC44MTY3WiIgZmlsbD0iI0ZCQ0I0QSIvPgo8L3N2Zz4K";
         this.provider = starknet_1.defaultProvider;
@@ -32,10 +32,13 @@ this.isConnected = false;
         this.enable = () => __awaiter(this, void 0, void 0, function* () {
-            const account = yield this.controller.connect();
-            if (!account) {
+            this.account = yield this.controller.connect();
+            if (!this.account) {
                 return [];
             }
-            return [account.address];
+            this.isConnected = true;
+            return [this.account.address];
         });
         this.isPreauthorized = () => __awaiter(this, void 0, void 0, function* () {
-            return this.controller.ready().then(this.controller.probe).then(connected => !!connected);
+            return this.controller.ready().then(() => {
+                return this.controller.probe();
+            }).then(connected => !!connected);
         });
@@ -42,0 +45,0 @@ this.on = (type, handler) => {

lib/types.d.ts

@@ -41,4 +41,4 @@ /// <reference types="node" />
     }, sync?: boolean): Promise<InvokeFunctionResponse>;
-    provision(address: string): Promise<string>;
-    register(username: string, credential: {
+    provision(address: string, credentialId: string): Promise<string>;
+    register(username: string, credentialId: string, credential: {
         x: string;
@@ -55,3 +55,2 @@ y: string;
         assertion: Assertion;
-        transactionHash: string;
     }>;
@@ -58,0 +57,0 @@ logout(): Promise<void>;

package.json

 {
   "name": "@cartridge/controller",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "description": "Cartridge Controller",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

New alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Fixed alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

74645

increased by0.4%

Worsened metrics

Lines of code

1200

decreased by-1.4%

No dependency changes